Merge remote-tracking branch 'upstream/main' into speed

std::less<LWOSCENEID> already does this in a map.

.dockerignore

@@ -3,8 +3,8 @@ Dockerfile
 *.md
 logo.png
 versions.txt
+build.sh
 docker-compose.yml
 .env
 docker/__pycache__
 .env.example
-build

.env.example

@@ -1,7 +1,9 @@
 # Full path to the LEGO Universe client
-CLIENT_PATH=./client
+CLIENT_PATH=/Users/someuser/LEGO Universe
+# Can improve build time
+BUILD_THREADS=1
 # Updates NET_VERSION in CMakeVariables.txt
-NET_VERSION=171022
+BUILD_VERSION=171022
 # make sure this is a long random string
 # grab a "SHA 256-bit Key" from here: https://keygen.io/
 ACCOUNT_MANAGER_SECRET=
@@ -10,5 +12,6 @@ EXTERNAL_IP=localhost
 # Database values
 # Be careful with special characters here. It is more safe to use normal characters and/or numbers.
 MARIADB_USER=darkflame
-MARIADB_PASSWORD=
+MARIADB_PASSWORD=SECRET_VALUE_CHANGE_ME
+MARIADB_ROOT_PASSWORD=SECRET_VALUE_CHANGE_ME
 MARIADB_DATABASE=darkflame

.github/workflows/build-and-push-docker.yml

@@ -1,56 +0,0 @@
-name: CI
-
-on:
-  push:
-    branches:
-      - "main"
-    tags:
-      - "v*.*.*"
-  pull_request:
-    branches:
-      - "main"
-
-env:
-  REGISTRY: ghcr.io
-  IMAGE_NAME: ${{ github.repository }}
-
-jobs:
-  build-and-push-image:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      packages: write
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-        with:
-          submodules: recursive
-
-      - name: Log in to the Container registry
-        uses: docker/login-action@v3
-        with:
-          registry: ${{ env.REGISTRY }}
-          username: ${{ github.actor }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Extract metadata (tags, labels) for Docker
-        id: meta
-        uses: docker/metadata-action@v5
-        with:
-          images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
-          # generate Docker tags based on the following events/attributes
-          tags: |
-            type=ref,event=pr
-            type=raw,value=latest,enable=${{ github.ref == format('refs/heads/{0}', 'main') }}
-            type=semver,pattern={{version}}
-            type=semver,pattern={{major}}.{{minor}}
-            type=semver,pattern={{major}}
-
-      - name: Build and push Docker image
-        uses: docker/build-push-action@v5
-        with:
-          context: .
-          push: ${{ github.event_name != 'pull_request' }}
-          tags: ${{ steps.meta.outputs.tags }}
-          labels: ${{ steps.meta.outputs.labels }}

.gitignore

@@ -122,4 +122,3 @@ docker/__pycache__
 docker-compose.override.yml
 
 !*Test.bin
-!cmake/*

.gitmodules

@@ -14,6 +14,6 @@
 	path = thirdparty/mariadb-connector-cpp
 	url = https://github.com/mariadb-corporation/mariadb-connector-cpp.git
 	ignore = dirty
-[submodule "thirdparty/magic_enum"]
+[submodule "thirdparty/AccountManager"]
-	path = thirdparty/magic_enum
+	path = thirdparty/AccountManager
-	url = https://github.com/Neargye/magic_enum.git
+	url = https://github.com/DarkflameUniverse/AccountManager

CMakeLists.txt

@@ -2,8 +2,7 @@ cmake_minimum_required(VERSION 3.18)
 project(Darkflame)
 include(CTest)
 
-set(CMAKE_CXX_STANDARD 20)
+set (CMAKE_CXX_STANDARD 17)
-set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake")
 
 # Read variables from file
 FILE(READ "${CMAKE_SOURCE_DIR}/CMakeVariables.txt" variables)
@@ -15,26 +14,30 @@ string(REPLACE "\n" ";" variables ${variables})
 foreach(variable ${variables})
 	# If the string contains a #, skip it
 	if(NOT "${variable}" MATCHES "#")
+
 		# Split the variable into name and value
 		string(REPLACE "=" ";" variable ${variable})
 
 		# Check that the length of the variable is 2 (name and value)
 		list(LENGTH variable length)
-
 		if(${length} EQUAL 2)
+
 			list(GET variable 0 variable_name)
 			list(GET variable 1 variable_value)
 
 			# Set the variable
 			set(${variable_name} ${variable_value})
 
+			# Add compiler definition
+			set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D${variable_name}=${variable_value}")
+
 			message(STATUS "Variable: ${variable_name} = ${variable_value}")
 		endif()
 	endif()
 endforeach()
 
 # Set the version
-set(PROJECT_VERSION "\"${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}\"")
+set(PROJECT_VERSION "${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}")
 
 # Echo the version
 message(STATUS "Version: ${PROJECT_VERSION}")
@@ -50,22 +53,19 @@ set(RECASTNAVIGATION_EXAMPLES OFF CACHE BOOL "" FORCE)
 # Disabled misleading indentation as DL_LinkedList from RakNet has a weird indent.
 # Disabled no-register
 # Disabled unknown pragmas because Linux doesn't understand Windows pragmas.
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DPROJECT_VERSION=${PROJECT_VERSION}")
 if(UNIX)
-	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O2 -Wuninitialized -fPIC")
+	if(APPLE)
-	add_compile_definitions(_GLIBCXX_USE_CXX11_ABI=0 _GLIBCXX_USE_CXX17_ABI=0)
+		set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++17 -O2 -Wuninitialized -D_GLIBCXX_USE_CXX11_ABI=0 -D_GLIBCXX_USE_CXX17_ABI=0 -fPIC")
-
+	else()
-	if(NOT APPLE)
+		set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++17 -O2 -Wuninitialized -D_GLIBCXX_USE_CXX11_ABI=0 -D_GLIBCXX_USE_CXX17_ABI=0 -static-libgcc -fPIC -lstdc++fs")
-		set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libgcc -lstdc++fs")
 	endif()
-
+	if (__dynamic AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-	if(${DYNAMIC} AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
 		set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -rdynamic")
 	endif()
-
+	if (__ggdb)
-	if(${GGDB})
 		set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -ggdb")
 	endif()
-
 	set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=c99 -O2 -fPIC")
 elseif(MSVC)
 	# Skip warning for invalid conversion from size_t to uint32_t for all targets below for now
@@ -98,19 +98,11 @@ make_directory(${CMAKE_BINARY_DIR}/logs)
 # Copy resource files on first build
 set(RESOURCE_FILES "sharedconfig.ini" "authconfig.ini" "chatconfig.ini" "worldconfig.ini" "masterconfig.ini" "blacklist.dcf")
 message(STATUS "Checking resource file integrity")
-
-include(Utils)
-UpdateConfigOption(${PROJECT_BINARY_DIR}/authconfig.ini "port" "auth_server_port")
-UpdateConfigOption(${PROJECT_BINARY_DIR}/chatconfig.ini "port" "chat_server_port")
-UpdateConfigOption(${PROJECT_BINARY_DIR}/masterconfig.ini "port" "master_server_port")
-
 foreach (resource_file ${RESOURCE_FILES})
 	set(file_size 0)
-
 	if (EXISTS ${PROJECT_BINARY_DIR}/${resource_file})
 		file(SIZE ${PROJECT_BINARY_DIR}/${resource_file} file_size)
 	endif()
-
 	if (${file_size} EQUAL 0)
 		configure_file(
 			${CMAKE_SOURCE_DIR}/resources/${resource_file} ${PROJECT_BINARY_DIR}/${resource_file}
@@ -123,39 +115,30 @@ foreach(resource_file ${RESOURCE_FILES})
 		string(REPLACE "\\\n" "" current_file_contents ${current_file_contents})
 		string(REPLACE "\n" ";" current_file_contents ${current_file_contents})
 		set(parsed_current_file_contents "")
-
 		# Remove comment lines so they do not interfere with the variable parsing
 		foreach (line ${current_file_contents})
 			string(FIND ${line} "#" is_comment)
-
 			if (NOT ${is_comment} EQUAL 0)
 				string(APPEND parsed_current_file_contents ${line})
 			endif()
 		endforeach()
-
 		file(READ ${CMAKE_SOURCE_DIR}/resources/${resource_file} depot_file_contents)
 		string(REPLACE "\\\n" "" depot_file_contents ${depot_file_contents})
 		string(REPLACE "\n" ";" depot_file_contents ${depot_file_contents})
 		set(line_to_add "")
-
 		foreach (line ${depot_file_contents})
 			string(FIND ${line} "#" is_comment)
-
 			if (NOT ${is_comment} EQUAL 0)
 				string(REPLACE "=" ";" line_split ${line})
 				list(GET line_split 0 variable_name)
-
 				if (NOT ${parsed_current_file_contents} MATCHES ${variable_name})
 					message(STATUS "Adding missing config option " ${variable_name} " to " ${resource_file})
 					set(line_to_add ${line_to_add} ${line})
-
 					foreach (line_to_append ${line_to_add})
 						file(APPEND ${PROJECT_BINARY_DIR}/${resource_file} "\n" ${line_to_append})
 					endforeach()
-
 					file(APPEND ${PROJECT_BINARY_DIR}/${resource_file} "\n")
 				endif()
-
 				set(line_to_add "")
 			else()
 				set(line_to_add ${line_to_add} ${line})
@@ -163,7 +146,6 @@ foreach(resource_file ${RESOURCE_FILES})
 		endforeach()
 	endif()
 endforeach()
-
 message(STATUS "Resource file integrity check complete")
 
 # if navmeshes directory does not exist, create it
@@ -172,14 +154,16 @@ if(NOT EXISTS ${PROJECT_BINARY_DIR}/navmeshes)
 endif()
 
 # Copy navmesh data on first build and extract it
-configure_file(${CMAKE_SOURCE_DIR}/resources/navmeshes.zip ${PROJECT_BINARY_DIR}/navmeshes.zip COPYONLY)
+configure_file(
+	${CMAKE_SOURCE_DIR}/resources/navmeshes.zip ${PROJECT_BINARY_DIR}/navmeshes.zip
+	COPYONLY
+)
 
 file(ARCHIVE_EXTRACT INPUT ${PROJECT_BINARY_DIR}/navmeshes.zip DESTINATION ${PROJECT_BINARY_DIR}/navmeshes)
 file(REMOVE ${PROJECT_BINARY_DIR}/navmeshes.zip)
 
 # Copy vanity files on first build
 set(VANITY_FILES "CREDITS.md" "INFO.md" "TESTAMENT.md" "NPC.xml")
-
 foreach(file ${VANITY_FILES})
 	configure_file("${CMAKE_SOURCE_DIR}/vanity/${file}" "${CMAKE_BINARY_DIR}/vanity/${file}" COPYONLY)
 endforeach()
@@ -187,18 +171,26 @@ endforeach()
 # Move our migrations for MasterServer to run
 file(MAKE_DIRECTORY ${PROJECT_BINARY_DIR}/migrations/dlu/)
 file(GLOB SQL_FILES ${CMAKE_SOURCE_DIR}/migrations/dlu/*.sql)
-
 foreach(file ${SQL_FILES})
 	get_filename_component(file ${file} NAME)
-	configure_file(${CMAKE_SOURCE_DIR}/migrations/dlu/${file} ${PROJECT_BINARY_DIR}/migrations/dlu/${file})
+	if (NOT EXISTS ${PROJECT_BINARY_DIR}/migrations/dlu/${file})
+		configure_file(
+			${CMAKE_SOURCE_DIR}/migrations/dlu/${file} ${PROJECT_BINARY_DIR}/migrations/dlu/${file}
+			COPYONLY
+		)
+	endif()
 endforeach()
 
 file(MAKE_DIRECTORY ${PROJECT_BINARY_DIR}/migrations/cdserver/)
 file(GLOB SQL_FILES ${CMAKE_SOURCE_DIR}/migrations/cdserver/*.sql)
-
 foreach(file ${SQL_FILES})
 	get_filename_component(file ${file} NAME)
-	configure_file(${CMAKE_SOURCE_DIR}/migrations/cdserver/${file} ${PROJECT_BINARY_DIR}/migrations/cdserver/${file})
+	if (NOT EXISTS ${PROJECT_BINARY_DIR}/migrations/cdserver/${file})
+		configure_file(
+			${CMAKE_SOURCE_DIR}/migrations/cdserver/${file} ${PROJECT_BINARY_DIR}/migrations/cdserver/${file}
+			COPYONLY
+		)
+	endif()
 endforeach()
 
 # Create our list of include directories
@@ -206,9 +198,7 @@ set(INCLUDED_DIRECTORIES
 	"dCommon"
 	"dCommon/dClient"
 	"dCommon/dEnums"
-
 	"dChatFilter"
-
 	"dGame"
 	"dGame/dBehaviors"
 	"dGame/dComponents"
@@ -219,14 +209,10 @@ set(INCLUDED_DIRECTORIES
 	"dGame/dPropertyBehaviors"
 	"dGame/dPropertyBehaviors/ControlBehaviorMessages"
 	"dGame/dUtilities"
-
 	"dPhysics"
-
 	"dNavigation"
 	"dNavigation/dTerrain"
-
 	"dZoneManager"
-
 	"dDatabase"
 	"dDatabase/CDClientDatabase"
 	"dDatabase/CDClientDatabase/CDClientTables"
@@ -234,16 +220,83 @@ set(INCLUDED_DIRECTORIES
 	"dDatabase/GameDatabase/ITables"
 	"dDatabase/GameDatabase/MySQL"
 	"dDatabase/GameDatabase/MySQL/Tables"
-
 	"dNet"
+	"dScripts"
+	"dScripts/02_server"
+	"dScripts/ai"
+	"dScripts/client"
+	"dScripts/EquipmentScripts"
+	"dScripts/EquipmentTriggers"
+	"dScripts/zone"
+	"dScripts/02_server/DLU"
+	"dScripts/02_server/Enemy"
+	"dScripts/02_server/Equipment"
+	"dScripts/02_server/Map"
+	"dScripts/02_server/Minigame"
+	"dScripts/02_server/Objects"
+	"dScripts/02_server/Pets"
+	"dScripts/02_server/Enemy/AG"
+	"dScripts/02_server/Enemy/AM"
+	"dScripts/02_server/Enemy/FV"
+	"dScripts/02_server/Enemy/General"
+	"dScripts/02_server/Enemy/Survival"
+	"dScripts/02_server/Enemy/VE"
+	"dScripts/02_server/Enemy/Waves"
+	"dScripts/02_server/Map/AG"
+	"dScripts/02_server/Map/AG_Spider_Queen"
+	"dScripts/02_server/Map/AM"
+	"dScripts/02_server/Map/FV"
+	"dScripts/02_server/Map/General"
+	"dScripts/02_server/Map/GF"
+	"dScripts/02_server/Map/njhub"
+	"dScripts/02_server/Map/NS"
+	"dScripts/02_server/Map/NT"
+	"dScripts/02_server/Map/PR"
+	"dScripts/02_server/Map/Property"
+	"dScripts/02_server/Map/SS"
+	"dScripts/02_server/Map/VE"
+	"dScripts/02_server/Map/FV/Racing"
+	"dScripts/02_server/Map/General/Ninjago"
+	"dScripts/02_server/Map/njhub/boss_instance"
+	"dScripts/02_server/Map/NS/Waves"
+	"dScripts/02_server/Map/Property/AG_Med"
+	"dScripts/02_server/Map/Property/AG_Small"
+	"dScripts/02_server/Map/Property/NS_Med"
+	"dScripts/02_server/Minigame/General"
+	"dScripts/ai/ACT"
+	"dScripts/ai/AG"
+	"dScripts/ai/FV"
+	"dScripts/ai/GENERAL"
+	"dScripts/ai/GF"
+	"dScripts/ai/MINIGAME"
+	"dScripts/ai/NP"
+	"dScripts/ai/NS"
+	"dScripts/ai/PETS"
+	"dScripts/ai/PROPERTY"
+	"dScripts/ai/RACING"
+	"dScripts/ai/SPEC"
+	"dScripts/ai/WILD"
+	"dScripts/ai/ACT/FootRace"
+	"dScripts/ai/MINIGAME/SG_GF"
+	"dScripts/ai/MINIGAME/SG_GF/SERVER"
+	"dScripts/ai/NS/NS_PP_01"
+	"dScripts/ai/NS/WH"
+	"dScripts/ai/PROPERTY/AG"
+	"dScripts/ai/RACING/OBJECTS"
+	"dScripts/client/ai"
+	"dScripts/client/ai/PR"
+	"dScripts/zone/AG"
+	"dScripts/zone/LUPs"
+	"dScripts/zone/PROPERTY"
+	"dScripts/zone/PROPERTY/FV"
+	"dScripts/zone/PROPERTY/GF"
+	"dScripts/zone/PROPERTY/NS"
 
-	"thirdparty/magic_enum/include/magic_enum"
 	"thirdparty/raknet/Source"
 	"thirdparty/tinyxml2"
 	"thirdparty/recastnavigation"
 	"thirdparty/SQLite"
 	"thirdparty/cpplinq"
-	"thirdparty/cpp-httplib"
 
 	"tests"
 	"tests/dCommonTests"
@@ -256,17 +309,21 @@ if(APPLE)
 	include_directories("/usr/local/include/")
 endif()
 
+if (WIN32)
+	set(INCLUDED_DIRECTORIES ${INCLUDED_DIRECTORIES} "thirdparty/libbcrypt/include")
+elseif (UNIX)
+	set(INCLUDED_DIRECTORIES ${INCLUDED_DIRECTORIES} "thirdparty/libbcrypt")
+	set(INCLUDED_DIRECTORIES ${INCLUDED_DIRECTORIES} "thirdparty/libbcrypt/include/bcrypt")
+endif()
+
+# Add binary directory as an include directory
+include_directories(${PROJECT_BINARY_DIR})
+
 # Actually include the directories from our list
 foreach (dir ${INCLUDED_DIRECTORIES})
 	include_directories(${PROJECT_SOURCE_DIR}/${dir})
 endforeach()
 
-if(NOT WIN32)
-	include_directories("${PROJECT_SOURCE_DIR}/thirdparty/libbcrypt/include/bcrypt")
-endif()
-
-include_directories("${PROJECT_SOURCE_DIR}/thirdparty/libbcrypt/include")
-
 # Add linking directories:
 link_directories(${PROJECT_BINARY_DIR})
 
@@ -314,16 +371,15 @@ add_subdirectory(dGame)
 add_subdirectory(dZoneManager)
 add_subdirectory(dNavigation)
 add_subdirectory(dPhysics)
-add_subdirectory(dServer)
 
 # Create a list of common libraries shared between all binaries
-set(COMMON_LIBRARIES "dCommon" "dDatabase" "dNet" "raknet" "mariadbConnCpp" "magic_enum")
+set(COMMON_LIBRARIES "dCommon" "dDatabase" "dNet" "raknet" "mariadbConnCpp")
 
 # Add platform specific common libraries
 if (UNIX)
 	set(COMMON_LIBRARIES ${COMMON_LIBRARIES} "dl" "pthread")
 
-	if(NOT APPLE AND ${INCLUDE_BACKTRACE})
+	if (NOT APPLE AND __include_backtrace__)
 		set(COMMON_LIBRARIES ${COMMON_LIBRARIES} "backtrace")
 	endif()
 endif()
@@ -334,6 +390,12 @@ add_subdirectory(dAuthServer)
 add_subdirectory(dChatServer)
 add_subdirectory(dMasterServer) # Add MasterServer last so it can rely on the other binaries
 
+# Add our precompiled headers
+target_precompile_headers(
+	dGame PRIVATE
+	${HEADERS_DGAME}
+)
+
 target_precompile_headers(
 	dZoneManager PRIVATE
 	${HEADERS_DZONEMANAGER}
@@ -355,6 +417,6 @@ target_precompile_headers(
 	"$<$<COMPILE_LANGUAGE:CXX>:${PROJECT_SOURCE_DIR}/thirdparty/tinyxml2/tinyxml2.h>"
 )
 
-if(${ENABLE_TESTING})
+if (${__enable_testing__} MATCHES "1")
 	add_subdirectory(tests)
 endif()

CMakeVariables.txt

@@ -1,32 +1,22 @@
 PROJECT_VERSION_MAJOR=1
 PROJECT_VERSION_MINOR=1
 PROJECT_VERSION_PATCH=1
-
+# LICENSE
+LICENSE=AGPL-3.0
 # Debugging
-# Set DYNAMIC to 1 to enable the -rdynamic flag for the linker, yielding some symbols in crashlogs.
+# Set __dynamic to 1 to enable the -rdynamic flag for the linker, yielding some symbols in crashlogs.
-DYNAMIC=1
+__dynamic=1
-
+# Set __ggdb to 1 to enable the -ggdb flag for the linker, including more debug info.
-# Set GGDB to 1 to enable the -ggdb flag for the linker, including more debug info.
+# __ggdb=1
-# Do note, changing this will re-build the whole server
+# Set __include_backtrace__ to 1 to includes the backtrace library for better crashlogs.
-GGDB=0
+# __include_backtrace__=1
-
+# Set __compile_backtrace__ to 1 to compile the backtrace library instead of using system libraries.
-# Set INCLUDE_BACKTRACE to 1 to includes the backtrace library for better crashlogs.
+# __compile_backtrace__=1
-# Do note, changing this will re-build the whole server
-INCLUDE_BACKTRACE=0
-
-# Set COMPILE_BACKTRACE to 1 to compile the backtrace library instead of using system libraries.
-# Do note, changing this will re-build the whole server
-COMPILE_BACKTRACE=0
-
 # Set to the number of jobs (make -j equivalent) to compile the mariadbconn files with.
-MARIADB_CONNECTOR_COMPILE_JOBS=1
+__maria_db_connector_compile_jobs__=1
-
 # When set to 1 and uncommented, compiling and linking testing folders and libraries will be done.
-ENABLE_TESTING=1
+__enable_testing__=1
-
 # The path to OpenSSL.  Change this if your OpenSSL install path is different than the default.
 OPENSSL_ROOT_DIR=/usr/local/opt/openssl@3/
-
+# Uncomment the below line to cache the entire CDClient into memory
-# Whether or not to cache the entire CDClient Database into memory instead of lazy loading.
+# CDCLIENT_CACHE_ALL=1
-# 0 means to lazy load, all other values mean load the entire database.
-CDCLIENT_CACHE_ALL=0

Docker.md

@@ -0,0 +1,46 @@
+# Run the Darkflame Server inside Docker
+
+## What you need
+
+- [Docker](https://docs.docker.com/get-docker/) (Docker Desktop or on Linux normal Docker)
+- [Docker Compose](https://docs.docker.com/compose/install/) (Included in Docker Desktop)
+- LEGO® Universe Client. Check the main [README](./README.md) for details on this.
+
+## Run server inside Docker
+
+1. Copy `.env.example` and save it as `.env` inside the root directory of this repository
+2. Edit the `.env` file and add your path to the root directory of your LEGO® Universe Client after `CLIENT_PATH=`
+3. Update other values in the `.env` file as needed (be sure to update passwords!)
+4. Run `docker compose up -d --build`
+5. Run `docker compose exec darkflame /app/MasterServer -a` and setup your admin account
+6. Follow the directions [here](https://github.com/DarkflameUniverse/AccountManager) to setup regular user accounts. The server will be accessible at: `http://<EXTERNAL_IP>:5000`
+7. Now you can see the output of the server with `docker compose logs -f --tail 100` or `docker compose logs -f --tail 100`. This can help you understand issues and there you can also see when the server finishes it's startup.
+8. You're ready to connect your client!
+
+**NOTE #1**: If you're running an older version of Docker, you may need to use the command `docker-compose` instead of `docker compose`.
+
+**NOTE #2**: To stop the server simply run `docker compose down` and to restart it just run `docker compose up -d` again. No need to run all the steps above every time.
+
+**NOTE #3**: Docker buildkit needs to be enabled. https://docs.docker.com/develop/develop-images/build_enhancements/#to-enable-buildkit-builds
+
+**NOTE #4**: Make sure to run the following in the repo root directory after cloning so submodules are also downloaded.
+```
+git submodule update --init --recursive
+```
+**NOTE #5**: If DarkflameSetup fails due to not having cdclient.fdb, rename CDClient.fdb (in the same folder) to cdclient.fdb
+
+## Disable brickbuildfix
+
+If you don't need the http server running on port 80 do this:
+
+1. Create a file with the name `docker-compose.override.yml` in the root of the repository
+2. Paste this content:
+
+```yml
+services:
+  brickbuildfix:
+    profiles:
+      - donotstart
+```
+
+3. Now run `docker compose up -d`

Docker_Windows.md

@@ -0,0 +1,58 @@
+# Installation under Windows
+## First Run
+1. Navigate to the [Docker download page](https://www.docker.com/products/docker-desktop) and download docker.
+
+    ![Docker Download Page](docker/images/Docker_Download_Page.png)
+
+2. Once the file has finished downloading, run it and proceed through the installation. Make sure, "Install required Windows components for WSL 2" is checked.
+
+    ![Docker Desktop Installer Configuration](docker/images/Docker_Desktop_Installer_Configuration.png)
+
+3. If necessary, restart your computer.
+4. After the restart, Docker Desktop will automatically open. If it does not, simply start it like any other program.
+5. If a window "WSL 2 Installation is incomplete." pops up, follow the link and click "WSL2 Linux kernel update package for x64 machines". Run the downloaded file and once that finishes, click "Restart" in the Docker Desktop window.
+
+    ![WSL 2 download](docker/images/WSL_2_download.png)
+
+6. Wait until Docker Desktop has started. You may skip the tutorial.
+7. You may want to disable "Open Docker Dashboard at startup" in _Settings_ -> _General_
+
+    ![Disable Dashboard Autostart](docker/images/DD_General_Settings.png)
+
+8. Install [Git for Windows](https://git-scm.com/download/win). During the installation, simply confirming the defaults is sufficient.
+9. In the folder you wish to save the Server, right click and select "Git Bash Here".
+10. Type `git clone --recursive https://github.com/DarkflameUniverse/DarkflameServer`
+11. Once the command has completed (you can see you path again and can enter commands), close the window.
+12. Inside the downloaded folder, copy `.env.example` and name the copy `.env`
+13. Open `.env` with Notepad by right-clicking it and selecting _Open With_ -> _More apps_ -> _Notepad_.
+14. Change the text after `CLIENT_PATH=` to the location of your client. This folder must contain either a folder `client` or `legouniverse.exe`.
+    > If you need the extra performance, place the client files in `\\wsl$\<your linux OS>\...` to avoid working across file systems, see [Docker Best Practices](https://docs.docker.com/desktop/windows/wsl/#best-practices) and [WSL documentation](https://docs.microsoft.com/en-us/windows/wsl/filesystems#file-storage-and-performance-across-file-systems).
+
+15. Optionally, you can change the number after `BUILD_THREADS=` to the number of cores / threads your processor has. If your computer crashes while building, you can try to reduce this value.
+16. After `ACCOUNT_MANAGER_SECRET=` paste a "SHA 256-bit Key" from https://keygen.io/
+17. If you are not only hosting a local server, change the value after `EXTERNAL_IP=` to the external IP address of your computer.
+18. Change the two values `SECRET_VALUE_CHANGE_ME` to passwords only you know. Save and close the file.
+19. In the extracted folder hit Shift+Right Click and select "Open PowerShell window here".
+
+    ![Open PowerShell](docker/images/Open_Powershell.png)
+
+17. In the new window, paste (with right click) or type `docker compose up -d --build` and confirm with enter.
+18. Once you see the blinking cursor and the path again, setup has finished and the server is already running.
+
+    ![setup done](docker/images/setup_finished.png)
+
+19. Create an admin account by pasting `docker compose exec darkflame /app/MasterServer -a` and following the prompts.
+
+    ![admin account creation](docker/images/Account_Creation.png)
+
+20. You can now login with these credentials at `http://your_ip:5000` (replace your_ip with your external IP). There you can create your account for playing as well as generate keys for other people to join; use these at `http://your_ip:5000/activate`
+
+## Normal Use
+1. In Docker Desktop you should now see an entry `darkflameserver-main` and when you click on it all containers but `DarkflameSetup` should eventually be green. That means the server is running.
+
+    ![server running](docker/images/Docker_Compose_Finished.png)
+
+2. For troubleshooting, you can check the logs of the various parts by clicking their entry.
+3. You can start and stop the server with the corresponding buttons. Once all containers are grey, the server has shut down, and when all containers but `DarkflameSetup` are green, the server is running. Note that starting and stopping takes some time, please be patient.
+
+    ![start stop buttons](docker/images/DD_Server_Startstop.png)

Dockerfile

@@ -1,51 +0,0 @@
-FROM gcc:12 as build
-
-WORKDIR /app
-
-RUN set -ex; \
-    apt-get update; \
-    apt-get install -y cmake
-
-COPY . /app/
-COPY --chmod=0500 ./build.sh /app/
-
-RUN sed -i 's/MARIADB_CONNECTOR_COMPILE_JOBS__=.*/MARIADB_CONNECTOR_COMPILE_JOBS__=2/' /app/CMakeVariables.txt 
-
-RUN ./build.sh
-
-FROM debian:12 as runtime
-
-WORKDIR /app
-
-RUN --mount=type=cache,id=build-apt-cache,target=/var/cache/apt \
-    apt update && \
-    apt install -y libssl3 libcurl4 && \
-    rm -rf /var/lib/apt/lists/*
-
-# Grab libraries and load them
-COPY --from=build /app/build/mariadbcpp/src/mariadb_connector_cpp-build/libmariadbcpp.so /usr/local/lib/
-COPY --from=build /app/build/mariadbcpp/src/mariadb_connector_cpp-build/libmariadb/libmariadb/libmariadb.so.3 /usr/local/lib
-RUN ldconfig
-
-# Server bins
-COPY --from=build /app/build/*Server /app/
-
-# Necessary suplimentary files
-COPY --from=build /app/build/*.ini /app/configs/
-COPY --from=build /app/build/vanity/*.* /app/vanity/*
-COPY --from=build /app/build/navmeshes /app/navmeshes
-COPY --from=build /app/build/migrations /app/migrations
-COPY --from=build /app/build/*.dcf /app/
-
-# backup of config and vanity files to copy to the host incase 
-# of a mount clobbering the copy from above
-COPY --from=build /app/build/*.ini /app/default-configs/ 
-COPY --from=build /app/build/vanity/*.* /app/default-vanity/*
-
-# needed as the container runs with the root user
-# and therefore sudo doesn't exist
-ENV USE_SUDO_AUTH=0
-ENV DLU_CONFIG_DIR=/app/configs/
-
-COPY --chmod=0500 ./entrypoint.sh /app/
-ENTRYPOINT [ "/app/entrypoint.sh" ]

README.md

@@ -37,7 +37,6 @@ If you would like a setup for a single player server only on a Windows machine,
 * [Verify your setup](#verify-your-setup)
 * [Running the server](#running-the-server)
 * [User Guide](#user-guide)
-* [Docker](#docker)
 
 ## Clone the repository
 If you are on Windows, you will need to download and install git from [here](https://git-scm.com/download/win)
@@ -348,62 +347,6 @@ certutil -hashfile <file> SHA1
 Known good *SHA1* checksum of the Darkflame Universe client:
 - `91498e09b83ce69f46baf9e521d48f23fe502985` (packed client, zip compressed)
 
-
-# Docker
-
-The Darkflame Server is automatically built and published as a Docker Container / [OCI](https://opencontainers.org/) Image to the GitHub Container Registry at:
-[`ghcr.io/darkflameuniverse/darkflameserver`](https://github.com/DarkflameUniverse/DarkflameServer/pkgs/container/darkflameserver).
-
-## Compose
-
-You can use the `docker-compose` tool to [setup a MariaDB database](#database-setup), run the Darkflame Server and manage it with [Nexus Dashboard](https://github.com/DarkflameUniverse/NexusDashboard) all
-at once. For that:
-
-- [Install Docker Desktop](https://docs.docker.com/get-docker/)
-- Open the directory that contains your LU Client
-  - If the `legouniverse.exe` is in a subfolder called `client`, you're good to go. There may also be a folder `versions`.
-  - Otherwise, create a new `client` folder and move the exe and everything else (e.g. `res` and `locale`) in there. This is necessary to work around a bug in the client that will prevent that you to log back in after getting disconnected.
-- Download the [docker-compose.yml](docker-compose.yml) file and place it next to `client`.
-- Download the [.env.example](.env.example) file and place it next to `client` with the file name `.env`
-  - You may get warnings that this name starts with a dot, acknowledge those, this is intentional. Depending on your operating system, you may need to activate showing hidden files (e.g. Ctrl-H in Gnome on Linux) and/or file extensions ("File name extensions" in the "View" tab on Windows).
-  - Update the `ACCOUNT_MANAGER_SECRET` and `MARIADB_PASSWORD` with strong random passwords.
-    - Use a password generator like <https://keygen.io>
-    - Avoid `:` and `@` characters
-    - Once the database user is created, changing the password will not update it, so the server will just fail to connect.
-  - Set `EXTERNAL_IP` to your LAN IP or public IP if you want to host the game for friends & family
-- Open a terminal in the folder with the `docker-compose.yml` and `client`
-- Run `docker compose up -d`
-  - This might require `sudo` on Linux, and a recent version of [docker compose](https://docs.docker.com/compose/install/)
-- Run `docker exec -it dlu-darkflameserver-1 /app/MasterServer -a` and follow the instructions to create the initial admin account
-- Open <http://localhost:8000> to access Nexus Dashboard with the admin account to create normal users
-- Set `AUTHSERVERIP=0:localhost` in `client/boot.cfg`
-  - Replace `localhost` with the value of `EXTERNAL_IP` if you changed that earlier.
-  - Also make sure `UGCUSE3DSERVICES=7:` is set to `0`
-- Launch `legouniverse.exe`
-
-## Standalone
-
-This assumes that you have a database deployed to your host or in another docker container.
-
-A basic deployment of this contianer would look like:
-```sh
-# example docker contianer deployment
-docker run -it \
-    -v /path/to/configs/:/app/configs \
-    -v /path/to/logs/:/app/logs \
-    -v /path/to/dumps/:/app/dumps \
-    -v /path/to/res:/app/res:ro \
-    -v /path/to/resServer:/app/resServer \
-    -e DUMP_FOLDER=/app/dumps \
-    -p 1001:1001/udp \
-    -p 2005:2005/udp \
-    -p 3000-3300:3000-3300/udp \
-ghcr.io/darkflameuniverse/darkflameserver:latest
-```
-You will need to replace the `/path/to/`'s to reflect the paths on your host.
-
-Any config option in the `.ini`'s can be overridden with environmental variables: Ex: `log_to_console=1` from `shared_config.ini` would be overidden like  `-e LOG_TO_CONSOLE=0`
-
 # Development Documentation
 This is a Work in Progress, but below are some quick links to documentaion for systems and structs in the server
 [Networked message structs](https://lcdruniverse.org/lu_packets/lu_packets/index.html)

cmake/Utils.cmake

@@ -1,51 +0,0 @@
-# Parses a config file for a specific option and appends the new option if it does not exist
-# If the new option does exist, this function will do nothing.
-# file_name: The name of the file to parse
-# old_option_name: The name of the option to find
-# new_option_name: The name of the option to add
-function(UpdateConfigOption file_name old_option_name new_option_name)
-	string(APPEND old_option_name "=")
-	string(APPEND new_option_name "=")
-	message(STATUS "Checking " ${file_name} " for " ${old_option_name} " and adding " ${new_option_name} " if it does not exist")
-	if(NOT EXISTS ${file_name}) 
-		message(STATUS ${file_name} " does not exist. Doing nothing")
-		return()
-	endif()
-	file(READ ${file_name} current_file_contents)
-	string(REPLACE "\\\n" "" current_file_contents ${current_file_contents})
-	string(REPLACE "\n" ";" current_file_contents ${current_file_contents})
-	set(parsed_current_file_contents "")
-
-	# Remove comment lines so they do not interfere with the variable parsing
-	foreach(line ${current_file_contents})
-		string(FIND ${line} "#" is_comment)
-
-		if(NOT ${is_comment} EQUAL 0)
-			string(APPEND parsed_current_file_contents ${line})
-		endif()
-	endforeach()
-
-	set(found_new_option -1)
-	set(found_old_option -1)
-	set(current_value -1)
-
-	foreach(line ${current_file_contents})
-		string(FIND ${line} ${old_option_name} old_option_in_file)
-
-		if(${old_option_in_file} EQUAL 0)
-			set(found_old_option 1)
-			set(current_value ${line})
-		endif()
-
-		string(FIND ${line} ${new_option_name} found_new_option_in_file)
-
-		if(${found_new_option_in_file} EQUAL 0)
-			set(found_new_option 1)
-		endif()
-	endforeach(line ${current_file_contents})
-
-	if(${found_old_option} EQUAL 1 AND NOT ${found_new_option} EQUAL 1)
-		string(REPLACE ${old_option_name} ${new_option_name} current_value ${current_value})
-		file(APPEND ${file_name} "\n" ${current_value})
-	endif()
-endfunction()

dAuthServer/AuthServer.cpp

@@ -1,7 +1,6 @@
 #include <iostream>
 #include <string>
 #include <ctime>
-#include <csignal>
 #include <chrono>
 #include <thread>
 
@@ -16,7 +15,7 @@
 
 //RakNet includes:
 #include "RakNetDefines.h"
-#include "MessageIdentifiers.h"
+#include <MessageIdentifiers.h>
 
 //Auth includes:
 #include "AuthPackets.h"
@@ -25,17 +24,15 @@
 #include "eAuthMessageType.h"
 
 #include "Game.h"
-#include "Server.h"
-
-
 namespace Game {
 	Logger* logger = nullptr;
 	dServer* server = nullptr;
 	dConfig* config = nullptr;
-	Game::signal_t lastSignal = 0;
+	bool shouldShutdown = false;
 	std::mt19937 randomEngine;
 }
 
+Logger* SetupLogger();
 void HandlePacket(Packet* packet);
 
 int main(int argc, char** argv) {
@@ -45,17 +42,17 @@ int main(int argc, char** argv) {
 	Diagnostics::SetProcessFileName(argv[0]);
 	Diagnostics::Initialize();
 
-	std::signal(SIGINT, Game::OnSignal);
-	std::signal(SIGTERM, Game::OnSignal);
-
-	Game::config = new dConfig("authconfig.ini");
-
 	//Create all the objects we need to run our service:
-	Server::SetupLogger("AuthServer");
+	Game::logger = SetupLogger();
 	if (!Game::logger) return EXIT_FAILURE;
 
+	//Read our config:
+	Game::config = new dConfig((BinaryPathFinder::GetBinaryDir() / "authconfig.ini").string());
+	Game::logger->SetLogToConsole(Game::config->GetValue("log_to_console") != "0");
+	Game::logger->SetLogDebugStatements(Game::config->GetValue("log_debug_statements") == "1");
+
 	LOG("Starting Auth server...");
-	LOG("Version: %s", PROJECT_VERSION);
+	LOG("Version: %i.%i", PROJECT_VERSION_MAJOR, PROJECT_VERSION_MINOR);
 	LOG("Compiled on: %s", __TIMESTAMP__);
 
 	try {
@@ -77,20 +74,16 @@ int main(int argc, char** argv) {
 		masterIP = masterInfo->ip;
 		masterPort = masterInfo->port;
 	}
-	LOG("Master is at %s:%d", masterIP.c_str(), masterPort);
 
 	Game::randomEngine = std::mt19937(time(0));
 
 	//It's safe to pass 'localhost' here, as the IP is only used as the external IP.
-	uint32_t maxClients = 999;
+	uint32_t maxClients = 50;
 	uint32_t ourPort = 1001; //LU client is hardcoded to use this for auth port, so I'm making it the default.
-	std::string ourIP = "localhost";
+	if (Game::config->GetValue("max_clients") != "") maxClients = std::stoi(Game::config->GetValue("max_clients"));
-	GeneralUtils::TryParse(Game::config->GetValue("max_clients"), maxClients);
+	if (Game::config->GetValue("port") != "") ourPort = std::atoi(Game::config->GetValue("port").c_str());
-	GeneralUtils::TryParse(Game::config->GetValue("auth_server_port"), ourPort);
-	const auto externalIPString = Game::config->GetValue("external_ip");
-	if (!externalIPString.empty()) ourIP = externalIPString;
 
-	Game::server = new dServer(ourIP, ourPort, 0, maxClients, false, true, Game::logger, masterIP, masterPort, ServerType::Auth, Game::config, &Game::lastSignal);
+	Game::server = new dServer(Game::config->GetValue("external_ip"), ourPort, 0, maxClients, false, true, Game::logger, masterIP, masterPort, ServerType::Auth, Game::config, &Game::shouldShutdown);
 
 	//Run it until server gets a kill message from Master:
 	auto t = std::chrono::high_resolution_clock::now();
@@ -103,16 +96,13 @@ int main(int argc, char** argv) {
 
 	AuthPackets::LoadClaimCodes();
 	
-	Game::logger->Flush(); // once immediately before main loop
+	while (!Game::shouldShutdown) {
-	while (!Game::ShouldShutdown()) {
 		//Check if we're still connected to master:
 		if (!Game::server->GetIsConnectedToMaster()) {
 			framesSinceMasterDisconnect++;
 
-			if (framesSinceMasterDisconnect >= authFramerate) {
+			if (framesSinceMasterDisconnect >= authFramerate)
-				LOG("No connection to master!");
 				break; //Exit our loop, shut down.
-			}
 		} else framesSinceMasterDisconnect = 0;
 
 		//In world we'd update our other systems here.
@@ -151,7 +141,6 @@ int main(int argc, char** argv) {
 		std::this_thread::sleep_until(t);
 	}
 
-	LOG("Exited Main Loop! (signal %d)", Game::lastSignal);
 	//Delete our objects here:
 	Database::Destroy("AuthServer");
 	delete Game::server;
@@ -161,6 +150,18 @@ int main(int argc, char** argv) {
 	return EXIT_SUCCESS;
 }
 
+Logger* SetupLogger() {
+	std::string logPath = (BinaryPathFinder::GetBinaryDir() / ("logs/AuthServer_" + std::to_string(time(nullptr)) + ".log")).string();
+	bool logToConsole = false;
+	bool logDebugStatements = false;
+#ifdef _DEBUG
+	logToConsole = true;
+	logDebugStatements = true;
+#endif
+
+	return new Logger(logPath, logToConsole, logDebugStatements);
+}
+
 void HandlePacket(Packet* packet) {
 	if (packet->length < 4) return;
 

dAuthServer/CMakeLists.txt

@@ -1,7 +1,2 @@
 add_executable(AuthServer "AuthServer.cpp")
-
+target_link_libraries(AuthServer ${COMMON_LIBRARIES})
-target_link_libraries(AuthServer ${COMMON_LIBRARIES} dServer)
-
-target_include_directories(AuthServer PRIVATE ${PROJECT_SOURCE_DIR}/dServer)
-
-add_compile_definitions(AuthServer PRIVATE PROJECT_VERSION="\"${PROJECT_VERSION}\"")

dChatServer/CMakeLists.txt

@@ -6,9 +6,6 @@ set(DCHATSERVER_SOURCES
 
 add_executable(ChatServer "ChatServer.cpp")
 add_library(dChatServer ${DCHATSERVER_SOURCES})
-target_include_directories(dChatServer PRIVATE ${PROJECT_SOURCE_DIR}/dServer)
-add_compile_definitions(ChatServer PRIVATE PROJECT_VERSION="\"${PROJECT_VERSION}\"")
 
 target_link_libraries(dChatServer ${COMMON_LIBRARIES} dChatFilter)
-target_link_libraries(ChatServer ${COMMON_LIBRARIES} dChatFilter dChatServer dServer)
+target_link_libraries(ChatServer ${COMMON_LIBRARIES} dChatFilter dChatServer)
-

dChatServer/ChatIgnoreList.cpp

@@ -2,6 +2,7 @@
 #include "PlayerContainer.h"
 #include "eChatInternalMessageType.h"
 #include "BitStreamUtils.h"
+#include "PacketUtils.h"
 #include "Game.h"
 #include "Logger.h"
 #include "eObjectBits.h"
@@ -25,15 +26,17 @@ void ChatIgnoreList::GetIgnoreList(Packet* packet) {
 	LWOOBJID playerId;
 	inStream.Read(playerId);
 
-	auto& receiver = Game::playerContainer.GetPlayerDataMutable(playerId);
+	auto* receiver = Game::playerContainer.GetPlayerData(playerId);
 	if (!receiver) {
 		LOG("Tried to get ignore list, but player %llu not found in container", playerId);
 		return;
 	}
 
-	if (!receiver.ignoredPlayers.empty()) {
+	if (!receiver->ignoredPlayers.empty()) {
-		LOG_DEBUG("Player %llu already has an ignore list, but is requesting it again.", playerId);
+		LOG_DEBUG("Player %llu already has an ignore list", playerId);
-	} else {
+		return;
+	}
+
 	auto ignoreList = Database::Get()->GetIgnoreList(static_cast<uint32_t>(playerId));
 	if (ignoreList.empty()) {
 		LOG_DEBUG("Player %llu has no ignores", playerId);
@@ -41,20 +44,19 @@ void ChatIgnoreList::GetIgnoreList(Packet* packet) {
 	}
 
 	for (auto& ignoredPlayer : ignoreList) {
-			receiver.ignoredPlayers.emplace_back(ignoredPlayer.name, ignoredPlayer.id);
+		receiver->ignoredPlayers.push_back(IgnoreData{ ignoredPlayer.id, ignoredPlayer.name });
-			GeneralUtils::SetBit(receiver.ignoredPlayers.back().playerId, eObjectBits::CHARACTER);
+		GeneralUtils::SetBit(receiver->ignoredPlayers.back().playerId, eObjectBits::CHARACTER);
-			GeneralUtils::SetBit(receiver.ignoredPlayers.back().playerId, eObjectBits::PERSISTENT);
+		GeneralUtils::SetBit(receiver->ignoredPlayers.back().playerId, eObjectBits::PERSISTENT);
-		}
 	}
 
 	CBITSTREAM;
-	WriteOutgoingReplyHeader(bitStream, receiver.playerID, ChatIgnoreList::Response::GET_IGNORE);
+	WriteOutgoingReplyHeader(bitStream, receiver->playerID, ChatIgnoreList::Response::GET_IGNORE);
 
 	bitStream.Write<uint8_t>(false); // Probably is Is Free Trial, but we don't care about that
 	bitStream.Write<uint16_t>(0); // literally spacing due to struct alignment
 
-	bitStream.Write<uint16_t>(receiver.ignoredPlayers.size());
+	bitStream.Write<uint16_t>(receiver->ignoredPlayers.size());
-	for (const auto& ignoredPlayer : receiver.ignoredPlayers) {
+	for (const auto& ignoredPlayer : receiver->ignoredPlayers) {
 		bitStream.Write(ignoredPlayer.playerId);
 		bitStream.Write(LUWString(ignoredPlayer.playerName, 36));
 	}
@@ -67,40 +69,40 @@ void ChatIgnoreList::AddIgnore(Packet* packet) {
 	LWOOBJID playerId;
 	inStream.Read(playerId);
 
-	auto& receiver = Game::playerContainer.GetPlayerDataMutable(playerId);
+	auto* receiver = Game::playerContainer.GetPlayerData(playerId);
 	if (!receiver) {
 		LOG("Tried to get ignore list, but player %llu not found in container", playerId);
 		return;
 	}
 
 	constexpr int32_t MAX_IGNORES = 32;
-	if (receiver.ignoredPlayers.size() > MAX_IGNORES) {
+	if (receiver->ignoredPlayers.size() > MAX_IGNORES) {
 		LOG_DEBUG("Player %llu has too many ignores", playerId);
 		return;
 	}
 
 	inStream.IgnoreBytes(4); // ignore some garbage zeros idk
 
-	LUWString toIgnoreName;
+	LUWString toIgnoreName(33);
 	inStream.Read(toIgnoreName);
 	std::string toIgnoreStr = toIgnoreName.GetAsString();
 
 	CBITSTREAM;
-	WriteOutgoingReplyHeader(bitStream, receiver.playerID, ChatIgnoreList::Response::ADD_IGNORE);
+	WriteOutgoingReplyHeader(bitStream, receiver->playerID, ChatIgnoreList::Response::ADD_IGNORE);
 
 	// Check if the player exists
 	LWOOBJID ignoredPlayerId = LWOOBJID_EMPTY;
-	if (toIgnoreStr == receiver.playerName || toIgnoreStr.find("[GM]") == 0) {
+	if (toIgnoreStr == receiver->playerName || toIgnoreStr.find("[GM]") == 0) {
 		LOG_DEBUG("Player %llu tried to ignore themselves", playerId);
 
 		bitStream.Write(ChatIgnoreList::AddResponse::GENERAL_ERROR);
-	} else if (std::count(receiver.ignoredPlayers.begin(), receiver.ignoredPlayers.end(), toIgnoreStr) > 0) {
+	} else if (std::count(receiver->ignoredPlayers.begin(), receiver->ignoredPlayers.end(), toIgnoreStr) > 0) {
 		LOG_DEBUG("Player %llu is already ignoring %s", playerId, toIgnoreStr.c_str());
 
 		bitStream.Write(ChatIgnoreList::AddResponse::ALREADY_IGNORED);
 	} else {
 		// Get the playerId falling back to query if not online
-		const auto& playerData = Game::playerContainer.GetPlayerData(toIgnoreStr);
+		auto* playerData = Game::playerContainer.GetPlayerData(toIgnoreStr);
 		if (!playerData) {
 			// Fall back to query
 			auto player = Database::Get()->GetCharacterInfo(toIgnoreStr);
@@ -110,7 +112,7 @@ void ChatIgnoreList::AddIgnore(Packet* packet) {
 				ignoredPlayerId = player->id;
 			}
 		} else {
-			ignoredPlayerId = playerData.playerID;
+			ignoredPlayerId = playerData->playerID;
 		}
 
 		if (ignoredPlayerId != LWOOBJID_EMPTY) {
@@ -118,7 +120,7 @@ void ChatIgnoreList::AddIgnore(Packet* packet) {
 			GeneralUtils::SetBit(ignoredPlayerId, eObjectBits::CHARACTER);
 			GeneralUtils::SetBit(ignoredPlayerId, eObjectBits::PERSISTENT);
 
-			receiver.ignoredPlayers.emplace_back(toIgnoreStr, ignoredPlayerId);
+			receiver->ignoredPlayers.push_back(IgnoreData{ ignoredPlayerId, toIgnoreStr });
 			LOG_DEBUG("Player %llu is ignoring %s", playerId, toIgnoreStr.c_str());
 
 			bitStream.Write(ChatIgnoreList::AddResponse::SUCCESS);
@@ -139,7 +141,7 @@ void ChatIgnoreList::RemoveIgnore(Packet* packet) {
 	LWOOBJID playerId;
 	inStream.Read(playerId);
 
-	auto& receiver = Game::playerContainer.GetPlayerDataMutable(playerId);
+	auto* receiver = Game::playerContainer.GetPlayerData(playerId);
 	if (!receiver) {
 		LOG("Tried to get ignore list, but player %llu not found in container", playerId);
 		return;
@@ -147,21 +149,21 @@ void ChatIgnoreList::RemoveIgnore(Packet* packet) {
 
 	inStream.IgnoreBytes(4); // ignore some garbage zeros idk
 
-	LUWString removedIgnoreName;
+	LUWString removedIgnoreName(33);
 	inStream.Read(removedIgnoreName);
 	std::string removedIgnoreStr = removedIgnoreName.GetAsString();
 
-	auto toRemove = std::remove(receiver.ignoredPlayers.begin(), receiver.ignoredPlayers.end(), removedIgnoreStr);
+	auto toRemove = std::remove(receiver->ignoredPlayers.begin(), receiver->ignoredPlayers.end(), removedIgnoreStr);
-	if (toRemove == receiver.ignoredPlayers.end()) {
+	if (toRemove == receiver->ignoredPlayers.end()) {
 		LOG_DEBUG("Player %llu is not ignoring %s", playerId, removedIgnoreStr.c_str());
 		return;
 	}
 
 	Database::Get()->RemoveIgnore(static_cast<uint32_t>(playerId), static_cast<uint32_t>(toRemove->playerId));
-	receiver.ignoredPlayers.erase(toRemove, receiver.ignoredPlayers.end());
+	receiver->ignoredPlayers.erase(toRemove, receiver->ignoredPlayers.end());
 
 	CBITSTREAM;
-	WriteOutgoingReplyHeader(bitStream, receiver.playerID, ChatIgnoreList::Response::REMOVE_IGNORE);
+	WriteOutgoingReplyHeader(bitStream, receiver->playerID, ChatIgnoreList::Response::REMOVE_IGNORE);
 
 	bitStream.Write<int8_t>(0);
 	LUWString playerNameSend(removedIgnoreStr, 33);

dChatServer/ChatPacketHandler.cpp

@@ -25,7 +25,7 @@ void ChatPacketHandler::HandleFriendlistRequest(Packet* packet) {
 	LWOOBJID playerID = 0;
 	inStream.Read(playerID);
 
-	auto& player = Game::playerContainer.GetPlayerDataMutable(playerID);
+	auto player = Game::playerContainer.GetPlayerData(playerID);
 	if (!player) return;
 
 	auto friendsList = Database::Get()->GetFriendsList(playerID);
@@ -37,15 +37,15 @@ void ChatPacketHandler::HandleFriendlistRequest(Packet* packet) {
 		GeneralUtils::SetBit(fd.friendID, eObjectBits::CHARACTER);
 
 		fd.isBestFriend = friendData.isBestFriend; //0 = friends, 1 = left_requested, 2 = right_requested, 3 = both_accepted - are now bffs
-		if (fd.isBestFriend) player.countOfBestFriends += 1;
+		if (fd.isBestFriend) player->countOfBestFriends += 1;
 		fd.friendName = friendData.friendName;
 
 		//Now check if they're online:
-		const auto& fr = Game::playerContainer.GetPlayerData(fd.friendID);
+		auto fr = Game::playerContainer.GetPlayerData(fd.friendID);
 
 		if (fr) {
 			fd.isOnline = true;
-			fd.zoneID = fr.zoneID;
+			fd.zoneID = fr->zoneID;
 
 			//Since this friend is online, we need to update them on the fact that we've just logged in:
 			SendFriendUpdate(fr, player, 1, fd.isBestFriend);
@@ -54,7 +54,7 @@ void ChatPacketHandler::HandleFriendlistRequest(Packet* packet) {
 			fd.zoneID = LWOZONEID();
 		}
 
-		player.friends.push_back(fd);
+		player->friends.push_back(fd);
 	}
 
 	//Now, we need to send the friendlist to the server they came from:
@@ -66,13 +66,13 @@ void ChatPacketHandler::HandleFriendlistRequest(Packet* packet) {
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CLIENT, eClientMessageType::GET_FRIENDS_LIST_RESPONSE);
 	bitStream.Write<uint8_t>(0);
 	bitStream.Write<uint16_t>(1); //Length of packet -- just writing one as it doesn't matter, client skips it.
-	bitStream.Write<uint16_t>(player.friends.size());
+	bitStream.Write((uint16_t)player->friends.size());
 
-	for (const auto& data : player.friends) {
+	for (auto& data : player->friends) {
 		data.Serialize(bitStream);
 	}
 
-	SystemAddress sysAddr = player.sysAddr;
+	SystemAddress sysAddr = player->sysAddr;
 	SEND_PACKET;
 }
 
@@ -95,49 +95,51 @@ void ChatPacketHandler::HandleFriendRequest(Packet* packet) {
 	char isBestFriendRequest{};
 	inStream.Read(isBestFriendRequest);
 
-	auto& requestor = Game::playerContainer.GetPlayerDataMutable(requestorPlayerID);
+	auto requestor = Game::playerContainer.GetPlayerData(requestorPlayerID);
 	if (!requestor) {
 		LOG("No requestor player %llu sent to %s found.", requestorPlayerID, playerName.c_str());
 		return;
 	}
 
-	if (requestor.playerName == playerName) {
+	if (requestor->playerName == playerName) {
 		SendFriendResponse(requestor, requestor, eAddFriendResponseType::MYTHRAN);
 		return;
 	};
-
+	std::unique_ptr<PlayerData> requestee(Game::playerContainer.GetPlayerData(playerName));
-	auto& requestee = Game::playerContainer.GetPlayerDataMutable(playerName);
 
 	// Check if player is online first
 	if (isBestFriendRequest && !requestee) {
-		for (auto& friendDataCandidate : requestor.friends) {
+		for (auto friendDataCandidate : requestor->friends) {
-			if (friendDataCandidate.friendName != playerName) continue;
+			if (friendDataCandidate.friendName == playerName) {
+				requestee.reset(new PlayerData());
 				// Setup the needed info since you can add a best friend offline.
-			requestee.playerID = friendDataCandidate.friendID;
+				requestee->playerID = friendDataCandidate.friendID;
-			requestee.playerName = friendDataCandidate.friendName;
+				requestee->playerName = friendDataCandidate.friendName;
-			requestee.zoneID = LWOZONEID();
+				requestee->zoneID = LWOZONEID();
 
 				FriendData requesteeFriendData{};
-			requesteeFriendData.friendID = requestor.playerID;
+				requesteeFriendData.friendID = requestor->playerID;
-			requesteeFriendData.friendName = requestor.playerName;
+				requesteeFriendData.friendName = requestor->playerName;
 				requesteeFriendData.isFTP = false;
 				requesteeFriendData.isOnline = false;
-			requesteeFriendData.zoneID = requestor.zoneID;
+				requesteeFriendData.zoneID = requestor->zoneID;
-			requestee.friends.push_back(requesteeFriendData);
+				requestee->friends.push_back(requesteeFriendData);
-			requestee.sysAddr = UNASSIGNED_SYSTEM_ADDRESS;
+				requestee->sysAddr = UNASSIGNED_SYSTEM_ADDRESS;
 				break;
 			}
 		}
+	}
 
 	// If at this point we dont have a target, then they arent online and we cant send the request.
 	// Send the response code that corresponds to what the error is.
 	if (!requestee) {
-		requestee.playerName = playerName;
+		requestee.reset(new PlayerData());
+		requestee->playerName = playerName;
 		auto responseType = Database::Get()->GetCharacterInfo(playerName)
 			? eAddFriendResponseType::NOTONLINE
 			: eAddFriendResponseType::INVALIDCHARACTER;
 
-		SendFriendResponse(requestor, requestee, responseType);
+		SendFriendResponse(requestor, requestee.get(), responseType);
 		return;
 	}
 
@@ -145,7 +147,7 @@ void ChatPacketHandler::HandleFriendRequest(Packet* packet) {
 
 		uint8_t oldBestFriendStatus{};
 		uint8_t bestFriendStatus{};
-		auto bestFriendInfo = Database::Get()->GetBestFriendStatus(requestorPlayerID, requestee.playerID);
+		auto bestFriendInfo = Database::Get()->GetBestFriendStatus(requestorPlayerID, requestee->playerID);
 		if (bestFriendInfo) {
 			// Get the IDs
 			LWOOBJID queryPlayerID = bestFriendInfo->playerCharacterId;
@@ -172,48 +174,51 @@ void ChatPacketHandler::HandleFriendRequest(Packet* packet) {
 		// Only do updates if there was a change in the bff status.
 		if (oldBestFriendStatus != bestFriendStatus) {
 			auto maxBestFriends = Game::playerContainer.GetMaxNumberOfBestFriends();
-			if (requestee.countOfBestFriends >= maxBestFriends || requestor.countOfBestFriends >= maxBestFriends) {
+			if (requestee->countOfBestFriends >= maxBestFriends || requestor->countOfBestFriends >= maxBestFriends) {
-				if (requestee.countOfBestFriends >= maxBestFriends) {
+				if (requestee->countOfBestFriends >= maxBestFriends) {
-					SendFriendResponse(requestor, requestee, eAddFriendResponseType::THEIRFRIENDLISTFULL, false);
+					SendFriendResponse(requestor, requestee.get(), eAddFriendResponseType::THEIRFRIENDLISTFULL, false);
 				}
-				if (requestor.countOfBestFriends >= maxBestFriends) {
+				if (requestor->countOfBestFriends >= maxBestFriends) {
-					SendFriendResponse(requestor, requestee, eAddFriendResponseType::YOURFRIENDSLISTFULL, false);
+					SendFriendResponse(requestor, requestee.get(), eAddFriendResponseType::YOURFRIENDSLISTFULL, false);
 				}
 			} else {
 				// Then update the database with this new info.
-				Database::Get()->SetBestFriendStatus(requestorPlayerID, requestee.playerID, bestFriendStatus);
+				Database::Get()->SetBestFriendStatus(requestorPlayerID, requestee->playerID, bestFriendStatus);
 				// Sent the best friend update here if the value is 3
 				if (bestFriendStatus == 3U) {
-					requestee.countOfBestFriends += 1;
+					requestee->countOfBestFriends += 1;
-					requestor.countOfBestFriends += 1;
+					requestor->countOfBestFriends += 1;
-					if (requestee.sysAddr != UNASSIGNED_SYSTEM_ADDRESS) SendFriendResponse(requestee, requestor, eAddFriendResponseType::ACCEPTED, false, true);
+					if (requestee->sysAddr != UNASSIGNED_SYSTEM_ADDRESS) SendFriendResponse(requestee.get(), requestor, eAddFriendResponseType::ACCEPTED, false, true);
-					if (requestor.sysAddr != UNASSIGNED_SYSTEM_ADDRESS) SendFriendResponse(requestor, requestee, eAddFriendResponseType::ACCEPTED, false, true);
+					if (requestor->sysAddr != UNASSIGNED_SYSTEM_ADDRESS) SendFriendResponse(requestor, requestee.get(), eAddFriendResponseType::ACCEPTED, false, true);
-					for (auto& friendData : requestor.friends) {
+					for (auto& friendData : requestor->friends) {
-						if (friendData.friendID == requestee.playerID) {
+						if (friendData.friendID == requestee->playerID) {
 							friendData.isBestFriend = true;
 						}
 					}
-					for (auto& friendData : requestee.friends) {
+					for (auto& friendData : requestee->friends) {
-						if (friendData.friendID == requestor.playerID) {
+						if (friendData.friendID == requestor->playerID) {
 							friendData.isBestFriend = true;
 						}
 					}
 				}
 			}
 		} else {
-			if (requestor.sysAddr != UNASSIGNED_SYSTEM_ADDRESS) SendFriendResponse(requestor, requestee, eAddFriendResponseType::WAITINGAPPROVAL, true, true);
+			if (requestor->sysAddr != UNASSIGNED_SYSTEM_ADDRESS) SendFriendResponse(requestor, requestee.get(), eAddFriendResponseType::WAITINGAPPROVAL, true, true);
 		}
 	} else {
 		auto maxFriends = Game::playerContainer.GetMaxNumberOfFriends();
-		if (requestee.friends.size() >= maxFriends) {
+		if (requestee->friends.size() >= maxFriends) {
-			SendFriendResponse(requestor, requestee, eAddFriendResponseType::THEIRFRIENDLISTFULL, false);
+			SendFriendResponse(requestor, requestee.get(), eAddFriendResponseType::THEIRFRIENDLISTFULL, false);
-		} else if (requestor.friends.size() >= maxFriends) {
+		} else if (requestor->friends.size() >= maxFriends) {
-			SendFriendResponse(requestor, requestee, eAddFriendResponseType::YOURFRIENDSLISTFULL, false);
+			SendFriendResponse(requestor, requestee.get(), eAddFriendResponseType::YOURFRIENDSLISTFULL, false);
 		} else {
 			// Do not send this if we are requesting to be a best friend.
-			SendFriendRequest(requestee, requestor);
+			SendFriendRequest(requestee.get(), requestor);
 		}
 	}
+
+	// If the player is actually a player and not a ghost one defined above, release it from being deleted.
+	if (requestee->sysAddr != UNASSIGNED_SYSTEM_ADDRESS) requestee.release();
 }
 
 void ChatPacketHandler::HandleFriendResponse(Packet* packet) {
@@ -225,8 +230,8 @@ void ChatPacketHandler::HandleFriendResponse(Packet* packet) {
 	std::string friendName = PacketUtils::ReadString(0x15, packet, true);
 
 	//Now to try and find both of these:
-	auto& requestor = Game::playerContainer.GetPlayerDataMutable(playerID);
+	auto requestor = Game::playerContainer.GetPlayerData(playerID);
-	auto& requestee = Game::playerContainer.GetPlayerDataMutable(friendName);
+	auto requestee = Game::playerContainer.GetPlayerData(friendName);
 	if (!requestor || !requestee) return;
 
 	eAddFriendResponseType serverResponseCode{};
@@ -249,8 +254,8 @@ void ChatPacketHandler::HandleFriendResponse(Packet* packet) {
 
 	// Now that we have handled the base cases, we need to check the other cases.
 	if (serverResponseCode == eAddFriendResponseType::ACCEPTED) {
-		for (const auto& friendData : requestor.friends) {
+		for (auto friendData : requestor->friends) {
-			if (friendData.friendID == requestee.playerID) {
+			if (friendData.friendID == requestee->playerID) {
 				serverResponseCode = eAddFriendResponseType::ALREADYFRIEND;
 				if (friendData.isBestFriend) {
 					isAlreadyBestFriends = 1U;
@@ -262,23 +267,25 @@ void ChatPacketHandler::HandleFriendResponse(Packet* packet) {
 	// This message is NOT sent for best friends and is handled differently for those requests.
 	if (serverResponseCode == eAddFriendResponseType::ACCEPTED) {
 		// Add the each player to the others friend list.
-		auto& requestorData = requestee.friends.emplace_back();
+		FriendData requestorData;
-		requestorData.zoneID = requestor.zoneID;
+		requestorData.zoneID = requestor->zoneID;
-		requestorData.friendID = requestor.playerID;
+		requestorData.friendID = requestor->playerID;
-		requestorData.friendName = requestor.playerName;
+		requestorData.friendName = requestor->playerName;
 		requestorData.isBestFriend = false;
 		requestorData.isFTP = false;
 		requestorData.isOnline = true;
+		requestee->friends.push_back(requestorData);
 
-		auto& requesteeData = requestor.friends.emplace_back();
+		FriendData requesteeData;
-		requesteeData.zoneID = requestee.zoneID;
+		requesteeData.zoneID = requestee->zoneID;
-		requesteeData.friendID = requestee.playerID;
+		requesteeData.friendID = requestee->playerID;
-		requesteeData.friendName = requestee.playerName;
+		requesteeData.friendName = requestee->playerName;
 		requesteeData.isBestFriend = false;
 		requesteeData.isFTP = false;
 		requesteeData.isOnline = true;
+		requestor->friends.push_back(requesteeData);
 
-		Database::Get()->AddFriend(requestor.playerID, requestee.playerID);
+		Database::Get()->AddFriend(requestor->playerID, requestee->playerID);
 	}
 
 	if (serverResponseCode != eAddFriendResponseType::DECLINED) SendFriendResponse(requestor, requestee, serverResponseCode, isAlreadyBestFriends);
@@ -306,27 +313,26 @@ void ChatPacketHandler::HandleRemoveFriend(Packet* packet) {
 	Database::Get()->RemoveFriend(playerID, friendID);
 
 	//Now, we need to send an update to notify the sender (and possibly, receiver) that their friendship has been ended:
-	auto& goonA = Game::playerContainer.GetPlayerDataMutable(playerID);
+	auto goonA = Game::playerContainer.GetPlayerData(playerID);
 	if (goonA) {
 		// Remove the friend from our list of friends
-		for (auto friendData = goonA.friends.cbegin(); friendData != goonA.friends.cend(); friendData++) {
+		for (auto friendData = goonA->friends.begin(); friendData != goonA->friends.end(); friendData++) {
-			if (friendData->friendID == friendID) {
+			if ((*friendData).friendID == friendID) {
-				if (friendData->isBestFriend) --goonA.countOfBestFriends;
+				if ((*friendData).isBestFriend) --goonA->countOfBestFriends;
-				goonA.friends.erase(friendData);
+				goonA->friends.erase(friendData);
 				break;
 			}
 		}
 		SendRemoveFriend(goonA, friendName, true);
 	}
 
-	auto& goonB = Game::playerContainer.GetPlayerDataMutable(friendID);
+	auto goonB = Game::playerContainer.GetPlayerData(friendID);
 	if (!goonB) return;
-
 	// Do it again for other person
-	for (auto friendData = goonB.friends.cbegin(); friendData != goonB.friends.cend(); friendData++) {
+	for (auto friendData = goonB->friends.begin(); friendData != goonB->friends.end(); friendData++) {
-		if (friendData->friendID == playerID) {
+		if ((*friendData).friendID == playerID) {
-			if (friendData->isBestFriend) --goonB.countOfBestFriends;
+			if ((*friendData).isBestFriend) --goonB->countOfBestFriends;
-			goonB.friends.erase(friendData);
+			goonB->friends.erase(friendData);
 			break;
 		}
 	}
@@ -340,11 +346,13 @@ void ChatPacketHandler::HandleChatMessage(Packet* packet) {
 	LWOOBJID playerID = LWOOBJID_EMPTY;
 	inStream.Read(playerID);
 
-	const auto& sender = Game::playerContainer.GetPlayerData(playerID);
+	auto* sender = Game::playerContainer.GetPlayerData(playerID);
 
-	if (!sender) return;
+	if (sender == nullptr) return;
 
-	if (sender.GetIsMuted()) return;
+	if (Game::playerContainer.GetIsMuted(sender)) return;
+
+	const auto senderName = std::string(sender->playerName.c_str());
 
 	inStream.SetReadOffset(0x14 * 8);
 
@@ -353,7 +361,7 @@ void ChatPacketHandler::HandleChatMessage(Packet* packet) {
 
 	std::string message = PacketUtils::ReadString(0x66, packet, true, 512);
 
-	LOG("Got a message from (%s) [%d]: %s", sender.playerName.c_str(), channel, message.c_str());
+	LOG("Got a message from (%s) [%d]: %s", senderName.c_str(), channel, message.c_str());
 
 	if (channel != 8) return;
 
@@ -362,28 +370,30 @@ void ChatPacketHandler::HandleChatMessage(Packet* packet) {
 	if (team == nullptr) return;
 
 	for (const auto memberId : team->memberIDs) {
-		const auto& otherMember = Game::playerContainer.GetPlayerData(memberId);
+		auto* otherMember = Game::playerContainer.GetPlayerData(memberId);
 
-		if (!otherMember) return;
+		if (otherMember == nullptr) return;
+
+		const auto otherName = std::string(otherMember->playerName.c_str());
 
 		CBITSTREAM;
 		BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-		bitStream.Write(otherMember.playerID);
+		bitStream.Write(otherMember->playerID);
 
 		BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT, eChatMessageType::PRIVATE_CHAT_MESSAGE);
-		bitStream.Write(otherMember.playerID);
+		bitStream.Write(otherMember->playerID);
 		bitStream.Write<uint8_t>(8);
 		bitStream.Write<unsigned int>(69);
-		bitStream.Write(LUWString(sender.playerName));
+		bitStream.Write(LUWString(senderName));
-		bitStream.Write(sender.playerID);
+		bitStream.Write(sender->playerID);
 		bitStream.Write<uint16_t>(0);
 		bitStream.Write<uint8_t>(0); //not mythran nametag
-		bitStream.Write(LUWString(otherMember.playerName));
+		bitStream.Write(LUWString(otherName));
 		bitStream.Write<uint8_t>(0); //not mythran for receiver
 		bitStream.Write<uint8_t>(0); //teams?
 		bitStream.Write(LUWString(message, 512));
 
-		SystemAddress sysAddr = otherMember.sysAddr;
+		SystemAddress sysAddr = otherMember->sysAddr;
 		SEND_PACKET;
 	}
 }
@@ -394,32 +404,35 @@ void ChatPacketHandler::HandlePrivateChatMessage(Packet* packet) {
 	std::string message = PacketUtils::ReadString(0xAA, packet, true, 512);
 
 	//Get the bois:
-	const auto& goonA = Game::playerContainer.GetPlayerData(senderID);
+	auto goonA = Game::playerContainer.GetPlayerData(senderID);
-	const auto& goonB = Game::playerContainer.GetPlayerData(receiverName);
+	auto goonB = Game::playerContainer.GetPlayerData(receiverName);
 	if (!goonA || !goonB) return;
 
-	if (goonA.GetIsMuted()) return;
+	if (Game::playerContainer.GetIsMuted(goonA)) return;
+
+	std::string goonAName = goonA->playerName.c_str();
+	std::string goonBName = goonB->playerName.c_str();
 
 	//To the sender:
 	{
 		CBITSTREAM;
 		BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-		bitStream.Write(goonA.playerID);
+		bitStream.Write(goonA->playerID);
 
 		BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT, eChatMessageType::PRIVATE_CHAT_MESSAGE);
-		bitStream.Write(goonA.playerID);
+		bitStream.Write(goonA->playerID);
 		bitStream.Write<uint8_t>(7);
 		bitStream.Write<unsigned int>(69);
-		bitStream.Write(LUWString(goonA.playerName));
+		bitStream.Write(LUWString(goonAName));
-		bitStream.Write(goonA.playerID);
+		bitStream.Write(goonA->playerID);
 		bitStream.Write<uint16_t>(0);
 		bitStream.Write<uint8_t>(0); //not mythran nametag
-		bitStream.Write(LUWString(goonB.playerName));
+		bitStream.Write(LUWString(goonBName));
 		bitStream.Write<uint8_t>(0); //not mythran for receiver
 		bitStream.Write<uint8_t>(0); //success
 		bitStream.Write(LUWString(message, 512));
 
-		SystemAddress sysAddr = goonA.sysAddr;
+		SystemAddress sysAddr = goonA->sysAddr;
 		SEND_PACKET;
 	}
 
@@ -427,22 +440,22 @@ void ChatPacketHandler::HandlePrivateChatMessage(Packet* packet) {
 	{
 		CBITSTREAM;
 		BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-		bitStream.Write(goonB.playerID);
+		bitStream.Write(goonB->playerID);
 
 		BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT, eChatMessageType::PRIVATE_CHAT_MESSAGE);
-		bitStream.Write(goonA.playerID);
+		bitStream.Write(goonA->playerID);
 		bitStream.Write<uint8_t>(7);
 		bitStream.Write<unsigned int>(69);
-		bitStream.Write(LUWString(goonA.playerName));
+		bitStream.Write(LUWString(goonAName));
-		bitStream.Write(goonA.playerID);
+		bitStream.Write(goonA->playerID);
 		bitStream.Write<uint16_t>(0);
 		bitStream.Write<uint8_t>(0); //not mythran nametag
-		bitStream.Write(LUWString(goonB.playerName));
+		bitStream.Write(LUWString(goonBName));
 		bitStream.Write<uint8_t>(0); //not mythran for receiver
 		bitStream.Write<uint8_t>(3); //new whisper
 		bitStream.Write(LUWString(message, 512));
 
-		SystemAddress sysAddr = goonB.sysAddr;
+		SystemAddress sysAddr = goonB->sysAddr;
 		SEND_PACKET;
 	}
 }
@@ -453,9 +466,11 @@ void ChatPacketHandler::HandleTeamInvite(Packet* packet) {
 	inStream.Read(playerID);
 	std::string invitedPlayer = PacketUtils::ReadString(0x14, packet, true);
 
-	const auto& player = Game::playerContainer.GetPlayerData(playerID);
+	auto* player = Game::playerContainer.GetPlayerData(playerID);
 
-	if (!player) return;
+	if (player == nullptr) {
+		return;
+	}
 
 	auto* team = Game::playerContainer.GetTeam(playerID);
 
@@ -463,11 +478,13 @@ void ChatPacketHandler::HandleTeamInvite(Packet* packet) {
 		team = Game::playerContainer.CreateTeam(playerID);
 	}
 
-	const auto& other = Game::playerContainer.GetPlayerData(invitedPlayer);
+	auto* other = Game::playerContainer.GetPlayerData(invitedPlayer);
 
-	if (!other) return;
+	if (other == nullptr) {
+		return;
+	}
 
-	if (Game::playerContainer.GetTeam(other.playerID) != nullptr) {
+	if (Game::playerContainer.GetTeam(other->playerID) != nullptr) {
 		return;
 	}
 
@@ -541,12 +558,12 @@ void ChatPacketHandler::HandleTeamKick(Packet* packet) {
 
 	LOG("(%llu) kicking (%s) from team", playerID, kickedPlayer.c_str());
 
-	const auto& kicked = Game::playerContainer.GetPlayerData(kickedPlayer);
+	auto* kicked = Game::playerContainer.GetPlayerData(kickedPlayer);
 
 	LWOOBJID kickedId = LWOOBJID_EMPTY;
 
-	if (kicked) {
+	if (kicked != nullptr) {
-		kickedId = kicked.playerID;
+		kickedId = kicked->playerID;
 	} else {
 		kickedId = Game::playerContainer.GetId(GeneralUtils::UTF8ToUTF16(kickedPlayer));
 	}
@@ -571,16 +588,16 @@ void ChatPacketHandler::HandleTeamPromote(Packet* packet) {
 
 	LOG("(%llu) promoting (%s) to team leader", playerID, promotedPlayer.c_str());
 
-	const auto& promoted = Game::playerContainer.GetPlayerData(promotedPlayer);
+	auto* promoted = Game::playerContainer.GetPlayerData(promotedPlayer);
 
-	if (!promoted) return;
+	if (promoted == nullptr) return;
 
 	auto* team = Game::playerContainer.GetTeam(playerID);
 
 	if (team != nullptr) {
 		if (team->leaderID != playerID) return;
 
-		Game::playerContainer.PromoteMember(team, promoted.playerID);
+		Game::playerContainer.PromoteMember(team, promoted->playerID);
 	}
 }
 
@@ -613,10 +630,10 @@ void ChatPacketHandler::HandleTeamStatusRequest(Packet* packet) {
 	inStream.Read(playerID);
 
 	auto* team = Game::playerContainer.GetTeam(playerID);
-	const auto& data = Game::playerContainer.GetPlayerData(playerID);
+	auto* data = Game::playerContainer.GetPlayerData(playerID);
 
-	if (team != nullptr && data) {
+	if (team != nullptr && data != nullptr) {
-		if (team->local && data.zoneID.GetMapID() != team->zoneId.GetMapID() && data.zoneID.GetCloneID() != team->zoneId.GetCloneID()) {
+		if (team->local && data->zoneID.GetMapID() != team->zoneId.GetMapID() && data->zoneID.GetCloneID() != team->zoneId.GetCloneID()) {
 			Game::playerContainer.RemoveMember(team, playerID, false, false, true, true);
 
 			return;
@@ -636,49 +653,49 @@ void ChatPacketHandler::HandleTeamStatusRequest(Packet* packet) {
 
 		Game::playerContainer.TeamStatusUpdate(team);
 
-		const auto leaderName = GeneralUtils::UTF8ToUTF16(data.playerName);
+		const auto leaderName = GeneralUtils::UTF8ToUTF16(data->playerName);
 
 		for (const auto memberId : team->memberIDs) {
-			const auto& otherMember = Game::playerContainer.GetPlayerData(memberId);
+			auto* otherMember = Game::playerContainer.GetPlayerData(memberId);
 
 			if (memberId == playerID) continue;
 
 			const auto memberName = Game::playerContainer.GetName(memberId);
 
-			if (otherMember) {
+			if (otherMember != nullptr) {
-				ChatPacketHandler::SendTeamSetOffWorldFlag(otherMember, data.playerID, data.zoneID);
+				ChatPacketHandler::SendTeamSetOffWorldFlag(otherMember, data->playerID, data->zoneID);
 			}
-			ChatPacketHandler::SendTeamAddPlayer(data, false, team->local, false, memberId, memberName, otherMember ? otherMember.zoneID : LWOZONEID(0, 0, 0));
+			ChatPacketHandler::SendTeamAddPlayer(data, false, team->local, false, memberId, memberName, otherMember != nullptr ? otherMember->zoneID : LWOZONEID(0, 0, 0));
 		}
 
 		Game::playerContainer.UpdateTeamsOnWorld(team, false);
 	}
 }
 
-void ChatPacketHandler::SendTeamInvite(const PlayerData& receiver, const PlayerData& sender) {
+void ChatPacketHandler::SendTeamInvite(PlayerData* receiver, PlayerData* sender) {
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 
 	//portion that will get routed:
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CLIENT, eClientMessageType::TEAM_INVITE);
 
-	bitStream.Write(LUWString(sender.playerName.c_str()));
+	bitStream.Write(LUWString(sender->playerName.c_str()));
-	bitStream.Write(sender.playerID);
+	bitStream.Write(sender->playerID);
 
-	SystemAddress sysAddr = receiver.sysAddr;
+	SystemAddress sysAddr = receiver->sysAddr;
 	SEND_PACKET;
 }
 
-void ChatPacketHandler::SendTeamInviteConfirm(const PlayerData& receiver, bool bLeaderIsFreeTrial, LWOOBJID i64LeaderID, LWOZONEID i64LeaderZoneID, uint8_t ucLootFlag, uint8_t ucNumOfOtherPlayers, uint8_t ucResponseCode, std::u16string wsLeaderName) {
+void ChatPacketHandler::SendTeamInviteConfirm(PlayerData* receiver, bool bLeaderIsFreeTrial, LWOOBJID i64LeaderID, LWOZONEID i64LeaderZoneID, uint8_t ucLootFlag, uint8_t ucNumOfOtherPlayers, uint8_t ucResponseCode, std::u16string wsLeaderName) {
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 
 	//portion that will get routed:
 	CMSGHEADER;
 
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 	bitStream.Write(eGameMessageType::TEAM_INVITE_CONFIRM);
 
 	bitStream.Write(bLeaderIsFreeTrial);
@@ -688,24 +705,24 @@ void ChatPacketHandler::SendTeamInviteConfirm(const PlayerData& receiver, bool b
 	bitStream.Write(ucLootFlag);
 	bitStream.Write(ucNumOfOtherPlayers);
 	bitStream.Write(ucResponseCode);
-	bitStream.Write<uint32_t>(wsLeaderName.size());
+	bitStream.Write(static_cast<uint32_t>(wsLeaderName.size()));
 	for (const auto character : wsLeaderName) {
 		bitStream.Write(character);
 	}
 
-	SystemAddress sysAddr = receiver.sysAddr;
+	SystemAddress sysAddr = receiver->sysAddr;
 	SEND_PACKET;
 }
 
-void ChatPacketHandler::SendTeamStatus(const PlayerData& receiver, LWOOBJID i64LeaderID, LWOZONEID i64LeaderZoneID, uint8_t ucLootFlag, uint8_t ucNumOfOtherPlayers, std::u16string wsLeaderName) {
+void ChatPacketHandler::SendTeamStatus(PlayerData* receiver, LWOOBJID i64LeaderID, LWOZONEID i64LeaderZoneID, uint8_t ucLootFlag, uint8_t ucNumOfOtherPlayers, std::u16string wsLeaderName) {
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 
 	//portion that will get routed:
 	CMSGHEADER;
 
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 	bitStream.Write(eGameMessageType::TEAM_GET_STATUS_RESPONSE);
 
 	bitStream.Write(i64LeaderID);
@@ -713,70 +730,70 @@ void ChatPacketHandler::SendTeamStatus(const PlayerData& receiver, LWOOBJID i64L
 	bitStream.Write<uint32_t>(0); // BinaryBuffe, no clue what's in here
 	bitStream.Write(ucLootFlag);
 	bitStream.Write(ucNumOfOtherPlayers);
-	bitStream.Write<uint32_t>(wsLeaderName.size());
+	bitStream.Write(static_cast<uint32_t>(wsLeaderName.size()));
 	for (const auto character : wsLeaderName) {
 		bitStream.Write(character);
 	}
 
-	SystemAddress sysAddr = receiver.sysAddr;
+	SystemAddress sysAddr = receiver->sysAddr;
 	SEND_PACKET;
 }
 
-void ChatPacketHandler::SendTeamSetLeader(const PlayerData& receiver, LWOOBJID i64PlayerID) {
+void ChatPacketHandler::SendTeamSetLeader(PlayerData* receiver, LWOOBJID i64PlayerID) {
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 
 	//portion that will get routed:
 	CMSGHEADER;
 
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 	bitStream.Write(eGameMessageType::TEAM_SET_LEADER);
 
 	bitStream.Write(i64PlayerID);
 
-	SystemAddress sysAddr = receiver.sysAddr;
+	SystemAddress sysAddr = receiver->sysAddr;
 	SEND_PACKET;
 }
 
-void ChatPacketHandler::SendTeamAddPlayer(const PlayerData& receiver, bool bIsFreeTrial, bool bLocal, bool bNoLootOnDeath, LWOOBJID i64PlayerID, std::u16string wsPlayerName, LWOZONEID zoneID) {
+void ChatPacketHandler::SendTeamAddPlayer(PlayerData* receiver, bool bIsFreeTrial, bool bLocal, bool bNoLootOnDeath, LWOOBJID i64PlayerID, std::u16string wsPlayerName, LWOZONEID zoneID) {
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 
 	//portion that will get routed:
 	CMSGHEADER;
 
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 	bitStream.Write(eGameMessageType::TEAM_ADD_PLAYER);
 
 	bitStream.Write(bIsFreeTrial);
 	bitStream.Write(bLocal);
 	bitStream.Write(bNoLootOnDeath);
 	bitStream.Write(i64PlayerID);
-	bitStream.Write<uint32_t>(wsPlayerName.size());
+	bitStream.Write(static_cast<uint32_t>(wsPlayerName.size()));
 	for (const auto character : wsPlayerName) {
 		bitStream.Write(character);
 	}
 	bitStream.Write1();
-	if (receiver.zoneID.GetCloneID() == zoneID.GetCloneID()) {
+	if (receiver->zoneID.GetCloneID() == zoneID.GetCloneID()) {
 		zoneID = LWOZONEID(zoneID.GetMapID(), zoneID.GetInstanceID(), 0);
 	}
 	bitStream.Write(zoneID);
 
-	SystemAddress sysAddr = receiver.sysAddr;
+	SystemAddress sysAddr = receiver->sysAddr;
 	SEND_PACKET;
 }
 
-void ChatPacketHandler::SendTeamRemovePlayer(const PlayerData& receiver, bool bDisband, bool bIsKicked, bool bIsLeaving, bool bLocal, LWOOBJID i64LeaderID, LWOOBJID i64PlayerID, std::u16string wsPlayerName) {
+void ChatPacketHandler::SendTeamRemovePlayer(PlayerData* receiver, bool bDisband, bool bIsKicked, bool bIsLeaving, bool bLocal, LWOOBJID i64LeaderID, LWOOBJID i64PlayerID, std::u16string wsPlayerName) {
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 
 	//portion that will get routed:
 	CMSGHEADER;
 
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 	bitStream.Write(eGameMessageType::TEAM_REMOVE_PLAYER);
 
 	bitStream.Write(bDisband);
@@ -785,37 +802,37 @@ void ChatPacketHandler::SendTeamRemovePlayer(const PlayerData& receiver, bool bD
 	bitStream.Write(bLocal);
 	bitStream.Write(i64LeaderID);
 	bitStream.Write(i64PlayerID);
-	bitStream.Write<uint32_t>(wsPlayerName.size());
+	bitStream.Write(static_cast<uint32_t>(wsPlayerName.size()));
 	for (const auto character : wsPlayerName) {
 		bitStream.Write(character);
 	}
 
-	SystemAddress sysAddr = receiver.sysAddr;
+	SystemAddress sysAddr = receiver->sysAddr;
 	SEND_PACKET;
 }
 
-void ChatPacketHandler::SendTeamSetOffWorldFlag(const PlayerData& receiver, LWOOBJID i64PlayerID, LWOZONEID zoneID) {
+void ChatPacketHandler::SendTeamSetOffWorldFlag(PlayerData* receiver, LWOOBJID i64PlayerID, LWOZONEID zoneID) {
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 
 	//portion that will get routed:
 	CMSGHEADER;
 
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 	bitStream.Write(eGameMessageType::TEAM_SET_OFF_WORLD_FLAG);
 
 	bitStream.Write(i64PlayerID);
-	if (receiver.zoneID.GetCloneID() == zoneID.GetCloneID()) {
+	if (receiver->zoneID.GetCloneID() == zoneID.GetCloneID()) {
 		zoneID = LWOZONEID(zoneID.GetMapID(), zoneID.GetInstanceID(), 0);
 	}
 	bitStream.Write(zoneID);
 
-	SystemAddress sysAddr = receiver.sysAddr;
+	SystemAddress sysAddr = receiver->sysAddr;
 	SEND_PACKET;
 }
 
-void ChatPacketHandler::SendFriendUpdate(const PlayerData& friendData, const PlayerData& playerData, uint8_t notifyType, uint8_t isBestFriend) {
+void ChatPacketHandler::SendFriendUpdate(PlayerData* friendData, PlayerData* playerData, uint8_t notifyType, uint8_t isBestFriend) {
 	/*chat notification is displayed if log in / out and friend is updated in friends list
 		[u8] - update type
 		Update types
@@ -831,36 +848,38 @@ void ChatPacketHandler::SendFriendUpdate(const PlayerData& friendData, const Pla
 
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(friendData.playerID);
+	bitStream.Write(friendData->playerID);
 
 	//portion that will get routed:
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CLIENT, eClientMessageType::UPDATE_FRIEND_NOTIFY);
 	bitStream.Write<uint8_t>(notifyType);
 
-	std::string playerName = playerData.playerName.c_str();
+	std::string playerName = playerData->playerName.c_str();
 
 	bitStream.Write(LUWString(playerName));
 
-	bitStream.Write(playerData.zoneID.GetMapID());
+	bitStream.Write(playerData->zoneID.GetMapID());
-	bitStream.Write(playerData.zoneID.GetInstanceID());
+	bitStream.Write(playerData->zoneID.GetInstanceID());
 
-	if (playerData.zoneID.GetCloneID() == friendData.zoneID.GetCloneID()) {
+	if (playerData->zoneID.GetCloneID() == friendData->zoneID.GetCloneID()) {
 		bitStream.Write(0);
 	} else {
-		bitStream.Write(playerData.zoneID.GetCloneID());
+		bitStream.Write(playerData->zoneID.GetCloneID());
 	}
 
 	bitStream.Write<uint8_t>(isBestFriend); //isBFF
 	bitStream.Write<uint8_t>(0); //isFTP
 
-	SystemAddress sysAddr = friendData.sysAddr;
+	SystemAddress sysAddr = friendData->sysAddr;
 	SEND_PACKET;
 }
 
-void ChatPacketHandler::SendFriendRequest(const PlayerData& receiver, const PlayerData& sender) {
+void ChatPacketHandler::SendFriendRequest(PlayerData* receiver, PlayerData* sender) {
+	if (!receiver || !sender) return;
+
 	//Make sure people aren't requesting people that they're already friends with:
-	for (const auto& fr : receiver.friends) {
+	for (auto fr : receiver->friends) {
-		if (fr.friendID == sender.playerID) {
+		if (fr.friendID == sender->playerID) {
 			SendFriendResponse(sender, receiver, eAddFriendResponseType::ALREADYFRIEND, fr.isBestFriend);
 			return; //we have this player as a friend, yeet this function so it doesn't send another request.
 		}
@@ -868,50 +887,54 @@ void ChatPacketHandler::SendFriendRequest(const PlayerData& receiver, const Play
 
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 
 	//portion that will get routed:
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CLIENT, eClientMessageType::ADD_FRIEND_REQUEST);
-	bitStream.Write(LUWString(sender.playerName));
+	bitStream.Write(LUWString(sender->playerName.c_str()));
 	bitStream.Write<uint8_t>(0); // This is a BFF flag however this is unused in live and does not have an implementation client side.
 
-	SystemAddress sysAddr = receiver.sysAddr;
+	SystemAddress sysAddr = receiver->sysAddr;
 	SEND_PACKET;
 }
 
-void ChatPacketHandler::SendFriendResponse(const PlayerData& receiver, const PlayerData& sender, eAddFriendResponseType responseCode, uint8_t isBestFriendsAlready, uint8_t isBestFriendRequest) {
+void ChatPacketHandler::SendFriendResponse(PlayerData* receiver, PlayerData* sender, eAddFriendResponseType responseCode, uint8_t isBestFriendsAlready, uint8_t isBestFriendRequest) {
+	if (!receiver || !sender) return;
+
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 
 	// Portion that will get routed:
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CLIENT, eClientMessageType::ADD_FRIEND_RESPONSE);
 	bitStream.Write(responseCode);
 	// For all requests besides accepted, write a flag that says whether or not we are already best friends with the receiver.
-	bitStream.Write<uint8_t>(responseCode != eAddFriendResponseType::ACCEPTED ? isBestFriendsAlready : sender.sysAddr != UNASSIGNED_SYSTEM_ADDRESS);
+	bitStream.Write<uint8_t>(responseCode != eAddFriendResponseType::ACCEPTED ? isBestFriendsAlready : sender->sysAddr != UNASSIGNED_SYSTEM_ADDRESS);
 	// Then write the player name
-	bitStream.Write(LUWString(sender.playerName));
+	bitStream.Write(LUWString(sender->playerName.c_str()));
 	// Then if this is an acceptance code, write the following extra info.
 	if (responseCode == eAddFriendResponseType::ACCEPTED) {
-		bitStream.Write(sender.playerID);
+		bitStream.Write(sender->playerID);
-		bitStream.Write(sender.zoneID);
+		bitStream.Write(sender->zoneID);
 		bitStream.Write(isBestFriendRequest); //isBFF
 		bitStream.Write<uint8_t>(0); //isFTP
 	}
-	SystemAddress sysAddr = receiver.sysAddr;
+	SystemAddress sysAddr = receiver->sysAddr;
 	SEND_PACKET;
 }
 
-void ChatPacketHandler::SendRemoveFriend(const PlayerData& receiver, std::string& personToRemove, bool isSuccessful) {
+void ChatPacketHandler::SendRemoveFriend(PlayerData* receiver, std::string& personToRemove, bool isSuccessful) {
+	if (!receiver) return;
+
 	CBITSTREAM;
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CHAT_INTERNAL, eChatInternalMessageType::ROUTE_TO_PLAYER);
-	bitStream.Write(receiver.playerID);
+	bitStream.Write(receiver->playerID);
 
 	//portion that will get routed:
 	BitStreamUtils::WriteHeader(bitStream, eConnectionType::CLIENT, eClientMessageType::REMOVE_FRIEND_RESPONSE);
 	bitStream.Write<uint8_t>(isSuccessful); //isOnline
 	bitStream.Write(LUWString(personToRemove));
 
-	SystemAddress sysAddr = receiver.sysAddr;
+	SystemAddress sysAddr = receiver->sysAddr;
 	SEND_PACKET;
 }

dChatServer/ChatPacketHandler.h

@@ -4,7 +4,6 @@
 #include "BitStream.h"
 
 struct PlayerData;
-
 enum class eAddFriendResponseType : uint8_t;
 
 namespace ChatPacketHandler {
@@ -24,18 +23,18 @@ namespace ChatPacketHandler {
 	void HandleTeamLootOption(Packet* packet);
 	void HandleTeamStatusRequest(Packet* packet);
 
-	void SendTeamInvite(const PlayerData& receiver, const PlayerData& sender);
+	void SendTeamInvite(PlayerData* receiver, PlayerData* sender);
-	void SendTeamInviteConfirm(const PlayerData& receiver, bool bLeaderIsFreeTrial, LWOOBJID i64LeaderID, LWOZONEID i64LeaderZoneID, uint8_t ucLootFlag, uint8_t ucNumOfOtherPlayers, uint8_t ucResponseCode, std::u16string wsLeaderName);
+	void SendTeamInviteConfirm(PlayerData* receiver, bool bLeaderIsFreeTrial, LWOOBJID i64LeaderID, LWOZONEID i64LeaderZoneID, uint8_t ucLootFlag, uint8_t ucNumOfOtherPlayers, uint8_t ucResponseCode, std::u16string wsLeaderName);
-	void SendTeamStatus(const PlayerData& receiver, LWOOBJID i64LeaderID, LWOZONEID i64LeaderZoneID, uint8_t ucLootFlag, uint8_t ucNumOfOtherPlayers, std::u16string wsLeaderName);
+	void SendTeamStatus(PlayerData* receiver, LWOOBJID i64LeaderID, LWOZONEID i64LeaderZoneID, uint8_t ucLootFlag, uint8_t ucNumOfOtherPlayers, std::u16string wsLeaderName);
-	void SendTeamSetLeader(const PlayerData& receiver, LWOOBJID i64PlayerID);
+	void SendTeamSetLeader(PlayerData* receiver, LWOOBJID i64PlayerID);
-	void SendTeamAddPlayer(const PlayerData& receiver, bool bIsFreeTrial, bool bLocal, bool bNoLootOnDeath, LWOOBJID i64PlayerID, std::u16string wsPlayerName, LWOZONEID zoneID);
+	void SendTeamAddPlayer(PlayerData* receiver, bool bIsFreeTrial, bool bLocal, bool bNoLootOnDeath, LWOOBJID i64PlayerID, std::u16string wsPlayerName, LWOZONEID zoneID);
-	void SendTeamRemovePlayer(const PlayerData& receiver, bool bDisband, bool bIsKicked, bool bIsLeaving, bool bLocal, LWOOBJID i64LeaderID, LWOOBJID i64PlayerID, std::u16string wsPlayerName);
+	void SendTeamRemovePlayer(PlayerData* receiver, bool bDisband, bool bIsKicked, bool bIsLeaving, bool bLocal, LWOOBJID i64LeaderID, LWOOBJID i64PlayerID, std::u16string wsPlayerName);
-	void SendTeamSetOffWorldFlag(const PlayerData& receiver, LWOOBJID i64PlayerID, LWOZONEID zoneID);
+	void SendTeamSetOffWorldFlag(PlayerData* receiver, LWOOBJID i64PlayerID, LWOZONEID zoneID);
 
 	//FriendData is the player we're SENDING this stuff to. Player is the friend that changed state.
-	void SendFriendUpdate(const PlayerData& friendData, const PlayerData& playerData, uint8_t notifyType, uint8_t isBestFriend);
+	void SendFriendUpdate(PlayerData* friendData, PlayerData* playerData, uint8_t notifyType, uint8_t isBestFriend);
 
-	void SendFriendRequest(const PlayerData& receiver, const PlayerData& sender);
+	void SendFriendRequest(PlayerData* receiver, PlayerData* sender);
-	void SendFriendResponse(const PlayerData& receiver, const PlayerData& sender, eAddFriendResponseType responseCode, uint8_t isBestFriendsAlready = 0U, uint8_t isBestFriendRequest = 0U);
+	void SendFriendResponse(PlayerData* receiver, PlayerData* sender, eAddFriendResponseType responseCode, uint8_t isBestFriendsAlready = 0U, uint8_t isBestFriendRequest = 0U);
-	void SendRemoveFriend(const PlayerData& receiver, std::string& personToRemove, bool isSuccessful);
+	void SendRemoveFriend(PlayerData* receiver, std::string& personToRemove, bool isSuccessful);
 };

dChatServer/ChatServer.cpp

@@ -22,11 +22,10 @@
 #include "ChatIgnoreList.h"
 
 #include "Game.h"
-#include "Server.h"
 
 //RakNet includes:
 #include "RakNetDefines.h"
-#include "MessageIdentifiers.h"
+#include <MessageIdentifiers.h>
 
 namespace Game {
 	Logger* logger = nullptr;
@@ -34,11 +33,12 @@ namespace Game {
 	dConfig* config = nullptr;
 	dChatFilter* chatFilter = nullptr;
 	AssetManager* assetManager = nullptr;
-	Game::signal_t lastSignal = 0;
+	bool shouldShutdown = false;
 	std::mt19937 randomEngine;
 	PlayerContainer playerContainer;
 }
 
+Logger* SetupLogger();
 void HandlePacket(Packet* packet);
 
 int main(int argc, char** argv) {
@@ -48,19 +48,17 @@ int main(int argc, char** argv) {
 	Diagnostics::SetProcessFileName(argv[0]);
 	Diagnostics::Initialize();
 
-	std::signal(SIGINT, Game::OnSignal);
-	std::signal(SIGTERM, Game::OnSignal);
-
-	Game::config = new dConfig("chatconfig.ini");
-
 	//Create all the objects we need to run our service:
-	Server::SetupLogger("ChatServer");
+	Game::logger = SetupLogger();
 	if (!Game::logger) return EXIT_FAILURE;
 
 	//Read our config:
+	Game::config = new dConfig((BinaryPathFinder::GetBinaryDir() / "chatconfig.ini").string());
+	Game::logger->SetLogToConsole(Game::config->GetValue("log_to_console") != "0");
+	Game::logger->SetLogDebugStatements(Game::config->GetValue("log_debug_statements") == "1");
 
 	LOG("Starting Chat server...");
-	LOG("Version: %s", PROJECT_VERSION);
+	LOG("Version: %i.%i", PROJECT_VERSION_MAJOR, PROJECT_VERSION_MINOR);
 	LOG("Compiled on: %s", __TIMESTAMP__);
 
 	try {
@@ -98,19 +96,14 @@ int main(int argc, char** argv) {
 		masterPort = masterInfo->port;
 	}
 	//It's safe to pass 'localhost' here, as the IP is only used as the external IP.
-	uint32_t maxClients = 999;
+	uint32_t maxClients = 50;
 	uint32_t ourPort = 1501;
-	std::string ourIP = "localhost";
+	if (Game::config->GetValue("max_clients") != "") maxClients = std::stoi(Game::config->GetValue("max_clients"));
-	GeneralUtils::TryParse(Game::config->GetValue("max_clients"), maxClients);
+	if (Game::config->GetValue("port") != "") ourPort = std::atoi(Game::config->GetValue("port").c_str());
-	GeneralUtils::TryParse(Game::config->GetValue("chat_server_port"), ourPort);
-	const auto externalIPString = Game::config->GetValue("external_ip");
-	if (!externalIPString.empty()) ourIP = externalIPString;
 
-	Game::server = new dServer(ourIP, ourPort, 0, maxClients, false, true, Game::logger, masterIP, masterPort, ServerType::Chat, Game::config, &Game::lastSignal);
+	Game::server = new dServer(Game::config->GetValue("external_ip"), ourPort, 0, maxClients, false, true, Game::logger, masterIP, masterPort, ServerType::Chat, Game::config, &Game::shouldShutdown);
 
-	bool dontGenerateDCF = false;
+	Game::chatFilter = new dChatFilter(Game::assetManager->GetResPath().string() + "/chatplus_en_us", bool(std::stoi(Game::config->GetValue("dont_generate_dcf"))));
-	GeneralUtils::TryParse(Game::config->GetValue("dont_generate_dcf"), dontGenerateDCF);
-	Game::chatFilter = new dChatFilter(Game::assetManager->GetResPath().string() + "/chatplus_en_us", dontGenerateDCF);
 	
 	Game::randomEngine = std::mt19937(time(0));
 
@@ -125,8 +118,7 @@ int main(int argc, char** argv) {
 	uint32_t framesSinceMasterDisconnect = 0;
 	uint32_t framesSinceLastSQLPing = 0;
 
-	Game::logger->Flush(); // once immediately before main loop
+	while (!Game::shouldShutdown) {
-	while (!Game::ShouldShutdown()) {
 		//Check if we're still connected to master:
 		if (!Game::server->GetIsConnectedToMaster()) {
 			framesSinceMasterDisconnect++;
@@ -181,6 +173,18 @@ int main(int argc, char** argv) {
 	return EXIT_SUCCESS;
 }
 
+Logger* SetupLogger() {
+	std::string logPath = (BinaryPathFinder::GetBinaryDir() / ("logs/ChatServer_" + std::to_string(time(nullptr)) + ".log")).string();
+	bool logToConsole = false;
+	bool logDebugStatements = false;
+#ifdef _DEBUG
+	logToConsole = true;
+	logDebugStatements = true;
+#endif
+
+	return new Logger(logPath, logToConsole, logDebugStatements);
+}
+
 void HandlePacket(Packet* packet) {
 	if (packet->data[0] == ID_DISCONNECTION_NOTIFICATION || packet->data[0] == ID_CONNECTION_LOST) {
 		LOG("A server has disconnected, erasing their connected players from the list.");

dChatServer/PlayerContainer.cpp

@@ -28,32 +28,27 @@ TeamData::TeamData() {
 
 void PlayerContainer::InsertPlayer(Packet* packet) {
 	CINSTREAM_SKIP_HEADER;
-	LWOOBJID playerId;
+	PlayerData* data = new PlayerData();
-	if (!inStream.Read(playerId)) {
+	inStream.Read(data->playerID);
-		LOG("Failed to read player ID");
-		return;
-	}
-
-	auto& data = m_Players[playerId];
-	data.playerID = playerId;
 
 	uint32_t len;
 	inStream.Read<uint32_t>(len);
 
 	for (int i = 0; i < len; i++) {
 		char character; inStream.Read<char>(character);
-		data.playerName += character;
+		data->playerName += character;
 	}
 
-	inStream.Read(data.zoneID);
+	inStream.Read(data->zoneID);
-	inStream.Read(data.muteExpire);
+	inStream.Read(data->muteExpire);
-	data.sysAddr = packet->systemAddress;
+	data->sysAddr = packet->systemAddress;
 
-	m_Names[data.playerID] = GeneralUtils::UTF8ToUTF16(data.playerName);
+	m_Names[data->playerID] = GeneralUtils::UTF8ToUTF16(data->playerName);
 
-	LOG("Added user: %s (%llu), zone: %i", data.playerName.c_str(), data.playerID, data.zoneID.GetMapID());
+	m_Players.insert(std::make_pair(data->playerID, data));
+	LOG("Added user: %s (%llu), zone: %i", data->playerName.c_str(), data->playerID, data->zoneID.GetMapID());
 
-	Database::Get()->UpdateActivityLog(data.playerID, eActivityType::PlayerLoggedIn, data.zoneID.GetMapID());
+	Database::Get()->UpdateActivityLog(data->playerID, eActivityType::PlayerLoggedIn, data->zoneID.GetMapID());
 }
 
 void PlayerContainer::RemovePlayer(Packet* packet) {
@@ -62,27 +57,26 @@ void PlayerContainer::RemovePlayer(Packet* packet) {
 	inStream.Read(playerID);
 
 	//Before they get kicked, we need to also send a message to their friends saying that they disconnected.
-	const auto& player = GetPlayerData(playerID);
+	std::unique_ptr<PlayerData> player(this->GetPlayerData(playerID));
 
-	if (!player) {
+	if (player == nullptr) {
-		LOG("Failed to find user: %llu", playerID);
 		return;
 	}
 
-	for (const auto& fr : player.friends) {
+	for (auto& fr : player->friends) {
-		const auto& fd = this->GetPlayerData(fr.friendID);
+		auto fd = this->GetPlayerData(fr.friendID);
-		if (fd) ChatPacketHandler::SendFriendUpdate(fd, player, 0, fr.isBestFriend);
+		if (fd) ChatPacketHandler::SendFriendUpdate(fd, player.get(), 0, fr.isBestFriend);
 	}
 
 	auto* team = GetTeam(playerID);
 
 	if (team != nullptr) {
-		const auto memberName = GeneralUtils::UTF8ToUTF16(player.playerName);
+		const auto memberName = GeneralUtils::UTF8ToUTF16(std::string(player->playerName.c_str()));
 
 		for (const auto memberId : team->memberIDs) {
-			const auto& otherMember = GetPlayerData(memberId);
+			auto* otherMember = GetPlayerData(memberId);
 
-			if (!otherMember) continue;
+			if (otherMember == nullptr) continue;
 
 			ChatPacketHandler::SendTeamSetOffWorldFlag(otherMember, playerID, { 0, 0, 0 });
 		}
@@ -91,7 +85,7 @@ void PlayerContainer::RemovePlayer(Packet* packet) {
 	LOG("Removed user: %llu", playerID);
 	m_Players.erase(playerID);
 
-	Database::Get()->UpdateActivityLog(playerID, eActivityType::PlayerLoggedOut, player.zoneID.GetMapID());
+	Database::Get()->UpdateActivityLog(playerID, eActivityType::PlayerLoggedOut, player->zoneID.GetMapID());
 }
 
 void PlayerContainer::MuteUpdate(Packet* packet) {
@@ -101,15 +95,15 @@ void PlayerContainer::MuteUpdate(Packet* packet) {
 	time_t expire = 0;
 	inStream.Read(expire);
 
-	auto& player = this->GetPlayerDataMutable(playerID);
+	auto* player = this->GetPlayerData(playerID);
 
-	if (!player) {
+	if (player == nullptr) {
 		LOG("Failed to find user: %llu", playerID);
 
 		return;
 	}
 
-	player.muteExpire = expire;
+	player->muteExpire = expire;
 
 	BroadcastMuteUpdate(playerID, expire);
 }
@@ -209,9 +203,9 @@ TeamData* PlayerContainer::GetTeam(LWOOBJID playerID) {
 void PlayerContainer::AddMember(TeamData* team, LWOOBJID playerID) {
 	if (team->memberIDs.size() >= 4){
 		LOG("Tried to add player to team that already had 4 players");
-		const auto& player = GetPlayerData(playerID);
+		auto* player = GetPlayerData(playerID);
 		if (!player) return;
-		ChatPackets::SendSystemMessage(player.sysAddr, u"The teams is full! You have not been added to a team!");
+		ChatPackets::SendSystemMessage(player->sysAddr, u"The teams is full! You have not been added to a team!");
 		return;
 	}
 
@@ -221,18 +215,18 @@ void PlayerContainer::AddMember(TeamData* team, LWOOBJID playerID) {
 
 	team->memberIDs.push_back(playerID);
 
-	const auto& leader = GetPlayerData(team->leaderID);
+	auto* leader = GetPlayerData(team->leaderID);
-	const auto& member = GetPlayerData(playerID);
+	auto* member = GetPlayerData(playerID);
 
-	if (!leader || !member) return;
+	if (leader == nullptr || member == nullptr) return;
 
-	const auto leaderName = GeneralUtils::UTF8ToUTF16(leader.playerName);
+	const auto leaderName = GeneralUtils::UTF8ToUTF16(leader->playerName);
-	const auto memberName = GeneralUtils::UTF8ToUTF16(member.playerName);
+	const auto memberName = GeneralUtils::UTF8ToUTF16(member->playerName);
 
-	ChatPacketHandler::SendTeamInviteConfirm(member, false, leader.playerID, leader.zoneID, team->lootFlag, 0, 0, leaderName);
+	ChatPacketHandler::SendTeamInviteConfirm(member, false, leader->playerID, leader->zoneID, team->lootFlag, 0, 0, leaderName);
 
 	if (!team->local) {
-		ChatPacketHandler::SendTeamSetLeader(member, leader.playerID);
+		ChatPacketHandler::SendTeamSetLeader(member, leader->playerID);
 	} else {
 		ChatPacketHandler::SendTeamSetLeader(member, LWOOBJID_EMPTY);
 	}
@@ -240,16 +234,16 @@ void PlayerContainer::AddMember(TeamData* team, LWOOBJID playerID) {
 	UpdateTeamsOnWorld(team, false);
 
 	for (const auto memberId : team->memberIDs) {
-		const auto& otherMember = GetPlayerData(memberId);
+		auto* otherMember = GetPlayerData(memberId);
 
 		if (otherMember == member) continue;
 
 		const auto otherMemberName = GetName(memberId);
 
-		ChatPacketHandler::SendTeamAddPlayer(member, false, team->local, false, memberId, otherMemberName, otherMember ? otherMember.zoneID : LWOZONEID(0, 0, 0));
+		ChatPacketHandler::SendTeamAddPlayer(member, false, team->local, false, memberId, otherMemberName, otherMember != nullptr ? otherMember->zoneID : LWOZONEID(0, 0, 0));
 
-		if (otherMember) {
+		if (otherMember != nullptr) {
-			ChatPacketHandler::SendTeamAddPlayer(otherMember, false, team->local, false, member.playerID, memberName, member.zoneID);
+			ChatPacketHandler::SendTeamAddPlayer(otherMember, false, team->local, false, member->playerID, memberName, member->zoneID);
 		}
 	}
 }
@@ -259,9 +253,9 @@ void PlayerContainer::RemoveMember(TeamData* team, LWOOBJID playerID, bool disba
 
 	if (index == team->memberIDs.end()) return;
 
-	const auto& member = GetPlayerData(playerID);
+	auto* member = GetPlayerData(playerID);
 
-	if (member && !silent) {
+	if (member != nullptr && !silent) {
 		ChatPacketHandler::SendTeamSetLeader(member, LWOOBJID_EMPTY);
 	}
 
@@ -272,9 +266,9 @@ void PlayerContainer::RemoveMember(TeamData* team, LWOOBJID playerID, bool disba
 			continue;
 		}
 
-		const auto& otherMember = GetPlayerData(memberId);
+		auto* otherMember = GetPlayerData(memberId);
 
-		if (!otherMember) continue;
+		if (otherMember == nullptr) continue;
 
 		ChatPacketHandler::SendTeamRemovePlayer(otherMember, disband, kicked, leaving, false, team->leaderID, playerID, memberName);
 	}
@@ -296,9 +290,9 @@ void PlayerContainer::PromoteMember(TeamData* team, LWOOBJID newLeader) {
 	team->leaderID = newLeader;
 
 	for (const auto memberId : team->memberIDs) {
-		const auto& otherMember = GetPlayerData(memberId);
+		auto* otherMember = GetPlayerData(memberId);
 
-		if (!otherMember) continue;
+		if (otherMember == nullptr) continue;
 
 		ChatPacketHandler::SendTeamSetLeader(otherMember, newLeader);
 	}
@@ -310,14 +304,14 @@ void PlayerContainer::DisbandTeam(TeamData* team) {
 	if (index == mTeams.end()) return;
 
 	for (const auto memberId : team->memberIDs) {
-		const auto& otherMember = GetPlayerData(memberId);
+		auto* otherMember = GetPlayerData(memberId);
 
-		if (!otherMember) continue;
+		if (otherMember == nullptr) continue;
 
-		const auto memberName = GeneralUtils::UTF8ToUTF16(otherMember.playerName);
+		const auto memberName = GeneralUtils::UTF8ToUTF16(otherMember->playerName);
 
 		ChatPacketHandler::SendTeamSetLeader(otherMember, LWOOBJID_EMPTY);
-		ChatPacketHandler::SendTeamRemovePlayer(otherMember, true, false, false, team->local, team->leaderID, otherMember.playerID, memberName);
+		ChatPacketHandler::SendTeamRemovePlayer(otherMember, true, false, false, team->local, team->leaderID, otherMember->playerID, memberName);
 	}
 
 	UpdateTeamsOnWorld(team, true);
@@ -332,19 +326,19 @@ void PlayerContainer::TeamStatusUpdate(TeamData* team) {
 
 	if (index == mTeams.end()) return;
 
-	const auto& leader = GetPlayerData(team->leaderID);
+	auto* leader = GetPlayerData(team->leaderID);
 
-	if (!leader) return;
+	if (leader == nullptr) return;
 
-	const auto leaderName = GeneralUtils::UTF8ToUTF16(leader.playerName);
+	const auto leaderName = GeneralUtils::UTF8ToUTF16(leader->playerName);
 
 	for (const auto memberId : team->memberIDs) {
-		const auto& otherMember = GetPlayerData(memberId);
+		auto* otherMember = GetPlayerData(memberId);
 
-		if (!otherMember) continue;
+		if (otherMember == nullptr) continue;
 
 		if (!team->local) {
-			ChatPacketHandler::SendTeamStatus(otherMember, team->leaderID, leader.zoneID, team->lootFlag, 0, leaderName);
+			ChatPacketHandler::SendTeamStatus(otherMember, team->leaderID, leader->zoneID, team->lootFlag, 0, leaderName);
 		}
 	}
 
@@ -360,7 +354,7 @@ void PlayerContainer::UpdateTeamsOnWorld(TeamData* team, bool deleteTeam) {
 
 	if (!deleteTeam) {
 		bitStream.Write(team->lootFlag);
-		bitStream.Write<char>(team->memberIDs.size());
+		bitStream.Write(static_cast<char>(team->memberIDs.size()));
 		for (const auto memberID : team->memberIDs) {
 			bitStream.Write(memberID);
 		}
@@ -370,42 +364,23 @@ void PlayerContainer::UpdateTeamsOnWorld(TeamData* team, bool deleteTeam) {
 }
 
 std::u16string PlayerContainer::GetName(LWOOBJID playerID) {
-	const auto iter = m_Names.find(playerID);
+	const auto& pair = m_Names.find(playerID);
 
-	if (iter == m_Names.end()) return u"";
+	if (pair == m_Names.end()) return u"";
 
-	return iter->second;
+	return pair->second;
 }
 
 LWOOBJID PlayerContainer::GetId(const std::u16string& playerName) {
-	LWOOBJID toReturn = LWOOBJID_EMPTY;
+	for (const auto& pair : m_Names) {
-
+		if (pair.second == playerName) {
-	for (const auto& [id, name] : m_Names) {
+			return pair.first;
-		if (name == playerName) {
-			toReturn = id;
-			break;
 		}
 	}
 
-	return toReturn;
+	return LWOOBJID_EMPTY;
 }
 
-PlayerData& PlayerContainer::GetPlayerDataMutable(const LWOOBJID& playerID) {
+bool PlayerContainer::GetIsMuted(PlayerData* data) {
-	return m_Players[playerID];
+	return data->muteExpire == 1 || data->muteExpire > time(NULL);
-}
-
-PlayerData& PlayerContainer::GetPlayerDataMutable(const std::string& playerName) {
-	for (auto& [id, player] : m_Players) {
-		if (!player) continue;
-		if (player.playerName == playerName) return player;
-	}
-	return m_Players[LWOOBJID_EMPTY];
-}
-
-const PlayerData& PlayerContainer::GetPlayerData(const LWOOBJID& playerID) {
-	return GetPlayerDataMutable(playerID);
-}
-
-const PlayerData& PlayerContainer::GetPlayerData(const std::string& playerName) {
-	return GetPlayerDataMutable(playerName);
 }

dChatServer/PlayerContainer.h

@@ -8,7 +8,6 @@
 #include <unordered_map>
 
 struct IgnoreData {
-	IgnoreData(const std::string& name, const LWOOBJID& id) : playerName(name), playerId(id) {}
 	inline bool operator==(const std::string& other) const noexcept {
 		return playerName == other;
 	}
@@ -17,31 +16,19 @@ struct IgnoreData {
 		return playerId == other;
 	}
 
-	LWOOBJID playerId = LWOOBJID_EMPTY;
+	LWOOBJID playerId;
 	std::string playerName;
 };
 
 struct PlayerData {
-	operator bool() const noexcept {
+	LWOOBJID playerID;
-		return playerID != LWOOBJID_EMPTY;
-	}
-
-	bool operator==(const PlayerData& other) const noexcept {
-		return playerID == other.playerID;
-	}
-
-	bool GetIsMuted() const {
-		return muteExpire == 1 || muteExpire > time(NULL);
-	}
-
-	SystemAddress sysAddr{};
-	LWOZONEID zoneID{};
-	LWOOBJID playerID = LWOOBJID_EMPTY;
-	time_t muteExpire = 0;
-	uint8_t countOfBestFriends = 0;
 	std::string playerName;
+	SystemAddress sysAddr;
+	LWOZONEID zoneID;
 	std::vector<FriendData> friends;
 	std::vector<IgnoreData> ignoredPlayers;
+	time_t muteExpire;
+	uint8_t countOfBestFriends = 0;
 };
 
 struct TeamData {
@@ -65,10 +52,22 @@ public:
 	void CreateTeamServer(Packet* packet);
 	void BroadcastMuteUpdate(LWOOBJID player, time_t time);
 
-	const PlayerData& GetPlayerData(const LWOOBJID& playerID);
+	PlayerData* GetPlayerData(const LWOOBJID& playerID) {
-	const PlayerData& GetPlayerData(const std::string& playerName);
+		auto it = m_Players.find(playerID);
-	PlayerData& GetPlayerDataMutable(const LWOOBJID& playerID);
+		if (it != m_Players.end()) return it->second;
-	PlayerData& GetPlayerDataMutable(const std::string& playerName);
+		return nullptr;
+	}
+
+	PlayerData* GetPlayerData(const std::string& playerName) {
+		for (auto player : m_Players) {
+			if (player.second) {
+				std::string pn = player.second->playerName.c_str();
+				if (pn == playerName) return player.second;
+			}
+		}
+
+		return nullptr;
+	}
 
 	TeamData* CreateLocalTeam(std::vector<LWOOBJID> members);
 	TeamData* CreateTeam(LWOOBJID leader, bool local = false);
@@ -81,12 +80,15 @@ public:
 	void UpdateTeamsOnWorld(TeamData* team, bool deleteTeam);
 	std::u16string GetName(LWOOBJID playerID);
 	LWOOBJID GetId(const std::u16string& playerName);
+	bool GetIsMuted(PlayerData* data);
 	uint32_t GetMaxNumberOfBestFriends() { return m_MaxNumberOfBestFriends; }
 	uint32_t GetMaxNumberOfFriends() { return m_MaxNumberOfFriends; }
 
+	std::map<LWOOBJID, PlayerData*>& GetAllPlayerData() { return m_Players; }
+
 private:
 	LWOOBJID m_TeamIDCounter = 0;
-	std::map<LWOOBJID, PlayerData> m_Players;
+	std::map<LWOOBJID, PlayerData*> m_Players;
 	std::vector<TeamData*> mTeams;
 	std::unordered_map<LWOOBJID, std::u16string> m_Names;
 	uint32_t m_MaxNumberOfBestFriends = 5;

dCommon/AmfSerialize.cpp

@@ -54,17 +54,17 @@ void RakNet::BitStream::Write<AMFBaseValue&>(AMFBaseValue& value) {
  * RakNet writes in the correct byte order - do not reverse this.
  */
 void WriteUInt29(RakNet::BitStream* bs, uint32_t v) {
-	unsigned char b4 = static_cast<unsigned char>(v);
+	unsigned char b4 = (unsigned char)v;
 	if (v < 0x00200000) {
 		b4 = b4 & 0x7F;
 		if (v > 0x7F) {
 			unsigned char b3;
 			v = v >> 7;
-			b3 = static_cast<unsigned char>(v) | 0x80;
+			b3 = ((unsigned char)(v)) | 0x80;
 			if (v > 0x7F) {
 				unsigned char b2;
 				v = v >> 7;
-				b2 = static_cast<unsigned char>(v) | 0x80;
+				b2 = ((unsigned char)(v)) | 0x80;
 				bs->Write(b2);
 			}
 
@@ -76,11 +76,11 @@ void WriteUInt29(RakNet::BitStream* bs, uint32_t v) {
 		unsigned char b3;
 
 		v = v >> 8;
-		b3 = static_cast<unsigned char>(v) | 0x80;
+		b3 = ((unsigned char)(v)) | 0x80;
 		v = v >> 7;
-		b2 = static_cast<unsigned char>(v) | 0x80;
+		b2 = ((unsigned char)(v)) | 0x80;
 		v = v >> 7;
-		b1 = static_cast<unsigned char>(v) | 0x80;
+		b1 = ((unsigned char)(v)) | 0x80;
 
 		bs->Write(b1);
 		bs->Write(b2);
@@ -105,8 +105,8 @@ void WriteFlagNumber(RakNet::BitStream* bs, uint32_t v) {
  * RakNet writes in the correct byte order - do not reverse this.
  */
 void WriteAMFString(RakNet::BitStream* bs, const std::string& str) {
-	WriteFlagNumber(bs, static_cast<uint32_t>(str.size()));
+	WriteFlagNumber(bs, (uint32_t)str.size());
-	bs->Write(str.c_str(), static_cast<uint32_t>(str.size()));
+	bs->Write(str.c_str(), (uint32_t)str.size());
 }
 
 /**

dCommon/AmfSerialize.h

@@ -4,7 +4,7 @@
 #include "Amf3.h"
 
 // RakNet
-#include "BitStream.h"
+#include <BitStream.h>
 
 /*!
  \file AmfSerialize.h

dCommon/BrickByBrickFix.cpp

@@ -51,7 +51,7 @@ uint32_t BrickByBrickFix::TruncateBrokenBrickByBrickXml() {
 
 				if (actualUncompressedSize != -1) {
 					uint32_t previousSize = completeUncompressedModel.size();
-					completeUncompressedModel.append(reinterpret_cast<char*>(uncompressedChunk.get()));
+					completeUncompressedModel.append((char*)uncompressedChunk.get());
 					completeUncompressedModel.resize(previousSize + actualUncompressedSize);
 				} else {
 					LOG("Failed to inflate chunk %i for model %llu.  Error: %i", chunkCount, model.id, err);

dCommon/CMakeLists.txt

@@ -5,7 +5,6 @@ set(DCOMMON_SOURCES
 		"dConfig.cpp"
 		"Diagnostics.cpp"
 		"Logger.cpp"
-		"Game.cpp"
 		"GeneralUtils.cpp"
 		"LDFFormat.cpp"
 		"MD5.cpp"

dCommon/Diagnostics.cpp

@@ -71,7 +71,7 @@ LONG CALLBACK unhandled_handler(EXCEPTION_POINTERS* e) {
 #include <cstring>
 #include <exception>
 
-#if defined(INCLUDE_BACKTRACE)
+#if defined(__include_backtrace__)
 #include <backtrace.h>
 
 #include <backtrace-supported.h>
@@ -115,14 +115,7 @@ void GenerateDump() {
 }
 
 void CatchUnhandled(int sig) {
-	std::exception_ptr eptr = std::current_exception();
+#ifndef __include_backtrace__
-	try {
-		if (eptr) std::rethrow_exception(eptr);
-	} catch(const std::exception& e) {
-		LOG("Caught exception: '%s'", e.what());
-	}
-
-#ifndef INCLUDE_BACKTRACE
 
 	std::string fileName = Diagnostics::GetOutDirectory() + "crash_" + Diagnostics::GetProcessName() + "_" + std::to_string(getpid()) + ".log";
 	LOG("Encountered signal %i, creating crash dump %s", sig, fileName.c_str());
@@ -174,7 +167,7 @@ void CatchUnhandled(int sig) {
 	backtrace_symbols_fd(array, size, STDOUT_FILENO);
 #  endif // defined(__GNUG__)
 
-#else // INCLUDE_BACKTRACE
+#else // __include_backtrace__
 
 	struct backtrace_state* state = backtrace_create_state(
 		Diagnostics::GetProcessFileName().c_str(),
@@ -185,7 +178,7 @@ void CatchUnhandled(int sig) {
 	struct bt_ctx ctx = { state, 0 };
 	Bt(state);
 
-#endif // INCLUDE_BACKTRACE
+#endif // __include_backtrace__
 
 	exit(EXIT_FAILURE);
 }
@@ -204,10 +197,10 @@ void MakeBacktrace() {
 	sigact.sa_sigaction = CritErrHdlr;
 	sigact.sa_flags = SA_RESTART | SA_SIGINFO;
 
-	if (sigaction(SIGSEGV, &sigact, nullptr) != 0 ||
+	if (sigaction(SIGSEGV, &sigact, (struct sigaction*)nullptr) != 0 ||
-		sigaction(SIGFPE, &sigact, nullptr) != 0 ||
+		sigaction(SIGFPE, &sigact, (struct sigaction*)nullptr) != 0 ||
-		sigaction(SIGABRT, &sigact, nullptr) != 0 ||
+		sigaction(SIGABRT, &sigact, (struct sigaction*)nullptr) != 0 ||
-		sigaction(SIGILL, &sigact, nullptr) != 0) {
+		sigaction(SIGILL, &sigact, (struct sigaction*)nullptr) != 0) {
 		fprintf(stderr, "error setting signal handler for %d (%s)\n",
 			SIGSEGV,
 			strsignal(SIGSEGV));

dCommon/Game.cpp

@@ -1,7 +0,0 @@
-#include "Game.h"
-
-namespace Game {
-	void OnSignal(int signal) {
-		lastSignal = signal;
-	}
-}

dCommon/Game.h

@@ -1,8 +1,6 @@
 #pragma once
 
-#include <string>
 #include <random>
-#include <csignal>
 
 class dServer;
 class Logger;
@@ -17,7 +15,6 @@ class dZoneManager;
 class PlayerContainer;
 
 namespace Game {
-	using signal_t = volatile std::sig_atomic_t;
 	extern Logger* logger;
 	extern dServer* server;
 	extern InstanceManager* im;
@@ -27,14 +24,8 @@ namespace Game {
 	extern RakPeerInterface* chatServer;
 	extern AssetManager* assetManager;
 	extern SystemAddress chatSysAddr;
-	extern signal_t lastSignal;
+	extern bool shouldShutdown;
 	extern EntityManager* entityManager;
 	extern dZoneManager* zoneManager;
 	extern PlayerContainer playerContainer;
-	extern std::string projectVersion;
-
-	inline bool ShouldShutdown() {
-		return lastSignal != 0;
-	}
-	void OnSignal(int signal);
 }

dCommon/GeneralUtils.cpp

@@ -53,7 +53,7 @@ bool _IsSuffixChar(uint8_t c) {
 bool GeneralUtils::_NextUTF8Char(std::string_view& slice, uint32_t& out) {
 	size_t rem = slice.length();
 	if (slice.empty()) return false;
-	const uint8_t* bytes = reinterpret_cast<const uint8_t*>(&slice.front());
+	const uint8_t* bytes = (const uint8_t*)&slice.front();
 	if (rem > 0) {
 		uint8_t first = bytes[0];
 		if (first < 0x80) { // 1 byte character

dCommon/GeneralUtils.h

@@ -9,7 +9,7 @@
 #include <functional>
 #include <type_traits>
 #include <stdexcept>
-#include "BitStream.h"
+#include <BitStream.h>
 #include "NiPoint3.h"
 
 #include "Game.h"
@@ -234,18 +234,6 @@ namespace GeneralUtils {
 		return T();
 	}
 
-	/**
-	 * Casts the value of an enum entry to its underlying type
-	 * @param entry Enum entry to cast
-	 * @returns The enum entry's value in its underlying type
-	*/
-	template <typename eType>
-	inline constexpr typename std::underlying_type_t<eType> CastUnderlyingType(const eType entry) {
-		static_assert(std::is_enum_v<eType>, "Not an enum");
-
-		return static_cast<typename std::underlying_type_t<eType>>(entry);
-	}
-
 // on Windows we need to undef these or else they conflict with our numeric limits calls
 // DEVELOPERS DEVELOPERS DEVELOPERS DEVELOPERS DEVELOPERS DEVELOPERS DEVELOPERS DEVELOPERS
 #ifdef _WIN32

dCommon/LDFFormat.h

@@ -63,15 +63,15 @@ private:
 
 	//! Writes the key to the packet
 	void WriteKey(RakNet::BitStream* packet) {
-		packet->Write<uint8_t>(this->key.length() * sizeof(uint16_t));
+		packet->Write(static_cast<uint8_t>(this->key.length() * sizeof(uint16_t)));
 		for (uint32_t i = 0; i < this->key.length(); ++i) {
-			packet->Write<uint16_t>(this->key[i]);
+			packet->Write(static_cast<uint16_t>(this->key[i]));
 		}
 	}
 
 	//! Writes the value to the packet
 	void WriteValue(RakNet::BitStream* packet) {
-		packet->Write<uint8_t>(this->GetValueType());
+		packet->Write(static_cast<uint8_t>(this->GetValueType()));
 		packet->Write(this->value);
 	}
 
@@ -179,30 +179,30 @@ template<> inline eLDFType LDFData<std::string>::GetValueType(void) { return LDF
 // The specialized version for std::u16string (UTF-16)
 template<>
 inline void LDFData<std::u16string>::WriteValue(RakNet::BitStream* packet) {
-	packet->Write<uint8_t>(this->GetValueType());
+	packet->Write(static_cast<uint8_t>(this->GetValueType()));
 
-	packet->Write<uint32_t>(this->value.length());
+	packet->Write(static_cast<uint32_t>(this->value.length()));
 	for (uint32_t i = 0; i < this->value.length(); ++i) {
-		packet->Write<uint16_t>(this->value[i]);
+		packet->Write(static_cast<uint16_t>(this->value[i]));
 	}
 }
 
 // The specialized version for bool
 template<>
 inline void LDFData<bool>::WriteValue(RakNet::BitStream* packet) {
-	packet->Write<uint8_t>(this->GetValueType());
+	packet->Write(static_cast<uint8_t>(this->GetValueType()));
 
-	packet->Write<uint8_t>(this->value);
+	packet->Write(static_cast<uint8_t>(this->value));
 }
 
 // The specialized version for std::string (UTF-8)
 template<>
 inline void LDFData<std::string>::WriteValue(RakNet::BitStream* packet) {
-	packet->Write<uint8_t>(this->GetValueType());
+	packet->Write(static_cast<uint8_t>(this->GetValueType()));
 
-	packet->Write<uint32_t>(this->value.length());
+	packet->Write(static_cast<uint32_t>(this->value.length()));
 	for (uint32_t i = 0; i < this->value.length(); ++i) {
-		packet->Write<uint8_t>(this->value[i]);
+		packet->Write(static_cast<uint8_t>(this->value[i]));
 	}
 }
 

dCommon/Logger.cpp

@@ -6,8 +6,6 @@
 #include <stdarg.h>
 
 Writer::~Writer() {
-	// Flush before we close
-	Flush();
 	// Dont try to close stdcout...
 	if (!m_Outfile || m_IsConsoleWriter) return;
 
@@ -16,7 +14,7 @@ Writer::~Writer() {
 }
 
 void Writer::Log(const char* time, const char* message) {
-	if (!m_Outfile || !m_Enabled) return;
+	if (!m_Outfile) return;
 
 	fputs(time, m_Outfile);
 	fputs(message, m_Outfile);

dCommon/Metrics.cpp

@@ -107,7 +107,7 @@ void Metrics::EndMeasurement(MetricVariable variable) {
 }
 
 float Metrics::ToMiliseconds(int64_t nanoseconds) {
-	return static_cast<float>(nanoseconds) / 1e6;
+	return (float)nanoseconds / 1e6;
 }
 
 std::string Metrics::MetricVariableToString(MetricVariable variable) {
@@ -193,34 +193,34 @@ size_t Metrics::GetPeakRSS() {
 	/* Windows -------------------------------------------------- */
 	PROCESS_MEMORY_COUNTERS info;
 	GetProcessMemoryInfo(GetCurrentProcess(), &info, sizeof(info));
-	return static_cast<size_t>(info.PeakWorkingSetSize);
+	return (size_t)info.PeakWorkingSetSize;
 
 #elif (defined(_AIX) || defined(__TOS__AIX__)) || (defined(__sun__) || defined(__sun) || defined(sun) && (defined(__SVR4) || defined(__svr4__)))
 	/* AIX and Solaris ------------------------------------------ */
 	struct psinfo psinfo;
 	int fd = -1;
 	if ((fd = open("/proc/self/psinfo", O_RDONLY)) == -1)
-		return static_cast<size_t>(0L);      /* Can't open? */
+		return (size_t)0L;      /* Can't open? */
 	if (read(fd, &psinfo, sizeof(psinfo)) != sizeof(psinfo)) {
 		close(fd);
-		return static_cast<size_t>(0L);      /* Can't read? */
+		return (size_t)0L;      /* Can't read? */
 	}
 	close(fd);
-	return static_cast<size_t>(psinfo.pr_rssize * 1024L);
+	return (size_t)(psinfo.pr_rssize * 1024L);
 
 #elif defined(__unix__) || defined(__unix) || defined(unix) || (defined(__APPLE__) && defined(__MACH__))
 	/* BSD, Linux, and OSX -------------------------------------- */
 	struct rusage rusage;
 	getrusage(RUSAGE_SELF, &rusage);
 #if defined(__APPLE__) && defined(__MACH__)
-	return static_cast<size_t>(rusage.ru_maxrss);
+	return (size_t)rusage.ru_maxrss;
 #else
-	return static_cast<size_t>(rusage.ru_maxrss * 1024L);
+	return (size_t)(rusage.ru_maxrss * 1024L);
 #endif
 
 #else
 	/* Unknown OS ----------------------------------------------- */
-	return static_cast<size_t>(0L);          /* Unsupported. */
+	return (size_t)0L;          /* Unsupported. */
 #endif
 
 }
@@ -234,33 +234,33 @@ size_t Metrics::GetCurrentRSS() {
 	/* Windows -------------------------------------------------- */
 	PROCESS_MEMORY_COUNTERS info;
 	GetProcessMemoryInfo(GetCurrentProcess(), &info, sizeof(info));
-	return static_cast<size_t>(info.WorkingSetSize);
+	return (size_t)info.WorkingSetSize;
 
 #elif defined(__APPLE__) && defined(__MACH__)
 	/* OSX ------------------------------------------------------ */
 	struct mach_task_basic_info info;
 	mach_msg_type_number_t infoCount = MACH_TASK_BASIC_INFO_COUNT;
 	if (task_info(mach_task_self(), MACH_TASK_BASIC_INFO,
-		reinterpret_cast<task_info_t>(&info), &infoCount) != KERN_SUCCESS)
+		(task_info_t)&info, &infoCount) != KERN_SUCCESS)
-		return static_cast<size_t>(0L);      /* Can't access? */
+		return (size_t)0L;      /* Can't access? */
-	return static_cast<size_t>(info.resident_size);
+	return (size_t)info.resident_size;
 
 #elif defined(__linux__) || defined(__linux) || defined(linux) || defined(__gnu_linux__)
 	/* Linux ---------------------------------------------------- */
 	long rss = 0L;
 	FILE* fp = NULL;
 	if ((fp = fopen("/proc/self/statm", "r")) == NULL)
-		return static_cast<size_t>(0L);      /* Can't open? */
+		return (size_t)0L;      /* Can't open? */
 	if (fscanf(fp, "%*s%ld", &rss) != 1) {
 		fclose(fp);
-		return static_cast<size_t>(0L);      /* Can't read? */
+		return (size_t)0L;      /* Can't read? */
 	}
 	fclose(fp);
-	return static_cast<size_t>(rss) * static_cast<size_t>(sysconf(_SC_PAGESIZE));
+	return (size_t)rss * (size_t)sysconf(_SC_PAGESIZE);
 
 #else
 	/* AIX, BSD, Solaris, and Unknown OS ------------------------ */
-	return static_cast<size_t>(0L);          /* Unsupported. */
+	return (size_t)0L;          /* Unsupported. */
 #endif
 
 }

dCommon/NiPoint3.cpp

@@ -114,13 +114,13 @@ bool NiPoint3::operator!=(const NiPoint3& point) const {
 //! Operator for subscripting
 float& NiPoint3::operator[](int i) {
 	float* base = &x;
-	return base[i];
+	return (float&)base[i];
 }
 
 //! Operator for subscripting
 const float& NiPoint3::operator[](int i) const {
 	const float* base = &x;
-	return base[i];
+	return (float&)base[i];
 }
 
 //! Operator for addition of vectors
@@ -232,21 +232,10 @@ NiPoint3 NiPoint3::MoveTowards(const NiPoint3& current, const NiPoint3& target,
 	float dx = target.x - current.x;
 	float dy = target.y - current.y;
 	float dz = target.z - current.z;
-
+	float lengthSquared = (float)((double)dx * (double)dx + (double)dy * (double)dy + (double)dz * (double)dz);
-	float lengthSquared = static_cast<float>(
+	if ((double)lengthSquared == 0.0 || (double)maxDistanceDelta >= 0.0 && (double)lengthSquared <= (double)maxDistanceDelta * (double)maxDistanceDelta)
-		static_cast<double>(dx) * static_cast<double>(dx) +
-		static_cast<double>(dy) * static_cast<double>(dy) +
-		static_cast<double>(dz) * static_cast<double>(dz)
-		);
-
-	if (static_cast<double>(lengthSquared) == 0.0
-		|| static_cast<double>(maxDistanceDelta) >= 0.0
-		&& static_cast<double>(lengthSquared)
-		<= static_cast<double>(maxDistanceDelta) * static_cast<double>(maxDistanceDelta)) {
 		return target;
-	}
+	float length = (float)std::sqrt((double)lengthSquared);
-
-	float length = std::sqrt(lengthSquared);
 	return NiPoint3(current.x + dx / length * maxDistanceDelta, current.y + dy / length * maxDistanceDelta, current.z + dz / length * maxDistanceDelta);
 }
 

dCommon/PositionUpdate.h

@@ -1,50 +0,0 @@
-#ifndef __POSITIONUPDATE__H__
-#define __POSITIONUPDATE__H__
-
-#include "NiPoint3.h"
-#include "NiQuaternion.h"
-
-
-struct RemoteInputInfo {
-	RemoteInputInfo() {
-		m_RemoteInputX = 0;
-		m_RemoteInputY = 0;
-		m_IsPowersliding = false;
-		m_IsModified = false;
-	}
-
-	void operator=(const RemoteInputInfo& other) {
-		m_RemoteInputX = other.m_RemoteInputX;
-		m_RemoteInputY = other.m_RemoteInputY;
-		m_IsPowersliding = other.m_IsPowersliding;
-		m_IsModified = other.m_IsModified;
-	}
-
-	bool operator==(const RemoteInputInfo& other) {
-		return m_RemoteInputX == other.m_RemoteInputX && m_RemoteInputY == other.m_RemoteInputY && m_IsPowersliding == other.m_IsPowersliding && m_IsModified == other.m_IsModified;
-	}
-
-	float m_RemoteInputX;
-	float m_RemoteInputY;
-	bool m_IsPowersliding;
-	bool m_IsModified;
-};
-
-struct LocalSpaceInfo {
-	LWOOBJID objectId = LWOOBJID_EMPTY;
-	NiPoint3 position = NiPoint3::ZERO;
-	NiPoint3 linearVelocity = NiPoint3::ZERO;
-};
-
-struct PositionUpdate {
-	NiPoint3 position = NiPoint3::ZERO;
-	NiQuaternion rotation = NiQuaternion::IDENTITY;
-	bool onGround = false;
-	bool onRail = false;
-	NiPoint3 velocity = NiPoint3::ZERO;
-	NiPoint3 angularVelocity = NiPoint3::ZERO;
-	LocalSpaceInfo localSpaceInfo;
-	RemoteInputInfo remoteInputInfo;
-};
-
-#endif  //!__POSITIONUPDATE__H__

dCommon/SHA512.cpp

@@ -1,5 +1,3 @@
-// Source: http://www.zedwood.com/article/cpp-sha512-function
-
 #include "SHA512.h"
 
 #include <cstring>

dCommon/ZCompression.cpp

@@ -1,6 +1,6 @@
 #include "ZCompression.h"
 
-#include "zlib.h"
+#include <zlib.h>
 
 namespace ZCompression {
 	int32_t GetMaxCompressedLength(int32_t nLenSrc) {

dCommon/dClient/AssetManager.cpp

@@ -4,7 +4,7 @@
 #include "Game.h"
 #include "Logger.h"
 
-#include "zlib.h"
+#include <zlib.h>
 
 AssetManager::AssetManager(const std::filesystem::path& path) {
 	if (!std::filesystem::is_directory(path)) {
@@ -81,8 +81,8 @@ bool AssetManager::HasFile(const char* name) {
 	std::replace(fixedName.begin(), fixedName.end(), '/', '\\');
 	if (fixedName.rfind("client\\res\\", 0) != 0) fixedName = "client\\res\\" + fixedName;
 
-	uint32_t crc = crc32b(0xFFFFFFFF, reinterpret_cast<uint8_t*>(const_cast<char*>(fixedName.c_str())), fixedName.size());
+	uint32_t crc = crc32b(0xFFFFFFFF, (uint8_t*)fixedName.c_str(), fixedName.size());
-	crc = crc32b(crc, reinterpret_cast<Bytef*>(const_cast<char*>("\0\0\0\0")), 4);
+	crc = crc32b(crc, (Bytef*)"\0\0\0\0", 4);
 
 	for (const auto& item : this->m_PackIndex->GetPackFileIndices()) {
 		if (item.m_Crc == crc) {
@@ -113,7 +113,7 @@ bool AssetManager::GetFile(const char* name, char** data, uint32_t* len) {
 #endif
 		fseek(file, 0, SEEK_END);
 		*len = ftell(file);
-		*data = static_cast<char*>(malloc(*len));
+		*data = (char*)malloc(*len);
 		fseek(file, 0, SEEK_SET);
 		int32_t readInData = fread(*data, sizeof(uint8_t), *len, file);
 		fclose(file);
@@ -129,8 +129,8 @@ bool AssetManager::GetFile(const char* name, char** data, uint32_t* len) {
 		fixedName = "client\\res\\" + fixedName;
 	}
 	int32_t packIndex = -1;
-	uint32_t crc = crc32b(0xFFFFFFFF, reinterpret_cast<uint8_t*>(const_cast<char*>(fixedName.c_str())), fixedName.size());
+	uint32_t crc = crc32b(0xFFFFFFFF, (uint8_t*)fixedName.c_str(), fixedName.size());
-	crc = crc32b(crc, reinterpret_cast<Bytef*>(const_cast<char*>("\0\0\0\0")), 4);
+	crc = crc32b(crc, (Bytef*)"\0\0\0\0", 4);
 
 	for (const auto& item : this->m_PackIndex->GetPackFileIndices()) {
 		if (item.m_Crc == crc) {
@@ -167,7 +167,7 @@ uint32_t AssetManager::crc32b(uint32_t base, uint8_t* message, size_t l) {
 	crc = base;
 	for (i = 0; i < l; i++) {
 		// xor next byte to upper bits of crc
-		crc ^= (static_cast<unsigned int>(message[i]) << 24);
+		crc ^= (((unsigned int)message[i]) << 24);
 		for (j = 0; j < 8; j++) { // Do eight times.
 			msb = crc >> 31;
 			crc <<= 1;

dCommon/dClient/AssetManager.h

@@ -26,7 +26,7 @@ struct AssetMemoryBuffer : std::streambuf {
 	}
 
 	~AssetMemoryBuffer() {
-		if (m_Success) free(m_Base);
+		free(m_Base);
 	}
 
 	pos_type seekpos(pos_type sp, std::ios_base::openmode which) override {

dCommon/dClient/Pack.cpp

@@ -76,7 +76,7 @@ bool Pack::ReadFileFromPack(uint32_t crc, char** data, uint32_t* len) {
 	fseek(file, pos, SEEK_SET);
 
 	if (!isCompressed) {
-		char* tempData = static_cast<char*>(malloc(pkRecord.m_UncompressedSize));
+		char* tempData = (char*)malloc(pkRecord.m_UncompressedSize);
 		int32_t readInData = fread(tempData, sizeof(uint8_t), pkRecord.m_UncompressedSize, file);
 
 		*data = tempData;
@@ -90,7 +90,7 @@ bool Pack::ReadFileFromPack(uint32_t crc, char** data, uint32_t* len) {
 
 	fseek(file, pos, SEEK_SET);
 
-	char* decompressedData = static_cast<char*>(malloc(pkRecord.m_UncompressedSize));
+	char* decompressedData = (char*)malloc(pkRecord.m_UncompressedSize);
 	uint32_t currentReadPos = 0;
 
 	while (true) {
@@ -100,12 +100,12 @@ bool Pack::ReadFileFromPack(uint32_t crc, char** data, uint32_t* len) {
 		int32_t readInData = fread(&size, sizeof(uint32_t), 1, file);
 		pos += 4; // Move pointer position 4 to the right
 
-		char* chunk = static_cast<char*>(malloc(size));
+		char* chunk = (char*)malloc(size);
 		int32_t readInData2 = fread(chunk, sizeof(int8_t), size, file);
 		pos += size; // Move pointer position the amount of bytes read to the right
 
 		int32_t err;
-		currentReadPos += ZCompression::Decompress(reinterpret_cast<uint8_t*>(chunk), size, reinterpret_cast<uint8_t*>(decompressedData + currentReadPos), ZCompression::MAX_SD0_CHUNK_SIZE, err);
+		currentReadPos += ZCompression::Decompress((uint8_t*)chunk, size, reinterpret_cast<uint8_t*>(decompressedData + currentReadPos), ZCompression::MAX_SD0_CHUNK_SIZE, err);
 
 		free(chunk);
 	}

dCommon/dConfig.cpp

@@ -10,23 +10,8 @@ dConfig::dConfig(const std::string& filepath) {
 	LoadConfig();
 }
 
-std::filesystem::path GetConfigDir() {
-	std::filesystem::path config_dir = BinaryPathFinder::GetBinaryDir();
-	if (const char* env_p = std::getenv("DLU_CONFIG_DIR")) {
-		config_dir /= env_p;
-	}
-	return config_dir;
-}
-
-const bool dConfig::Exists(const std::string& filepath) {
-	std::filesystem::path config_dir = GetConfigDir();
-	return std::filesystem::exists(config_dir / filepath);
-}
-
 void dConfig::LoadConfig() {
-	std::filesystem::path config_dir = GetConfigDir();
+	std::ifstream in(BinaryPathFinder::GetBinaryDir() / m_ConfigFilePath);
-
-	std::ifstream in(config_dir / m_ConfigFilePath);
 	if (!in.good()) return;
 
 	std::string line{};
@@ -34,7 +19,7 @@ void dConfig::LoadConfig() {
 		if (!line.empty() && line.front() != '#') ProcessLine(line);
 	}
 
-	std::ifstream sharedConfig(config_dir / "sharedconfig.ini", std::ios::in);
+	std::ifstream sharedConfig(BinaryPathFinder::GetBinaryDir() / "sharedconfig.ini", std::ios::in);
 	if (!sharedConfig.good()) return;
 
 	line.clear();
@@ -49,11 +34,6 @@ void dConfig::ReloadConfig() {
 }
 
 const std::string& dConfig::GetValue(std::string key) {
-	std::string upper_key(key);
-	std::transform(upper_key.begin(), upper_key.end(), upper_key.begin(), ::toupper);
-	if (const char* env_p = std::getenv(upper_key.c_str())) {
-		this->m_ConfigValues[key] = env_p;
-	}
 	return this->m_ConfigValues[key];
 }
 

dCommon/dConfig.h

@@ -7,11 +7,6 @@ class dConfig {
 public:
 	dConfig(const std::string& filepath);
 
-	/**
-	 * Checks whether the specified filepath exists
-	 */
-	static const bool Exists(const std::string& filepath);
-
 	/**
 	 * Gets the specified key from the config.  Returns an empty string if the value is not found.
 	 *

dCommon/dEnums/StringifiedEnum.h

@@ -1,29 +0,0 @@
-#ifndef __STRINGIFIEDENUM_H__
-#define __STRINGIFIEDENUM_H__
-
-#include <string>
-#include "magic_enum.hpp"
-
-namespace StringifiedEnum {
-	template<typename T>
-	const std::string_view ToString(const T e) {
-		static_assert(std::is_enum_v<T>, "Not an enum"); // Check type
-
-		constexpr auto sv = &magic_enum::enum_entries<T>();
-
-		const auto it = std::lower_bound(
-			sv->begin(), sv->end(), e,
-			[&](const std::pair<T, std::string_view>& lhs, const T rhs) { return lhs.first < rhs; }
-		);
-
-		std::string_view output;
-		if (it != sv->end() && it->first == e) {
-			output = it->second;
-		} else {
-			output = "UNKNOWN";
-		}
-		return output;
-	}
-}
-
-#endif // !__STRINGIFIEDENUM_H__

dCommon/dEnums/dCommonVars.h

@@ -130,7 +130,7 @@ public:
 	LWOOBJID friendID;
 	std::string friendName;
 
-	void Serialize(RakNet::BitStream& bitStream) const {
+	void Serialize(RakNet::BitStream& bitStream) {
 		bitStream.Write<uint8_t>(isOnline);
 		bitStream.Write<uint8_t>(isBestFriend);
 		bitStream.Write<uint8_t>(isFTP);
@@ -148,11 +148,11 @@ public:
 		if (size > maxSize) size = maxSize;
 
 		for (uint32_t i = 0; i < size; ++i) {
-			bitStream.Write<uint16_t>(friendName[i]);
+			bitStream.Write(static_cast<uint16_t>(friendName[i]));
 		}
 
 		for (uint32_t j = 0; j < remSize; ++j) {
-			bitStream.Write<uint16_t>(0);
+			bitStream.Write(static_cast<uint16_t>(0));
 		}
 
 		bitStream.Write<uint32_t>(0); //???

dCommon/dEnums/eGameMessageType.h

@@ -3,8 +3,6 @@
 
 #include <cstdint>
 
-#include "magic_enum.hpp"
-
 enum class eGameMessageType : uint16_t {
     GET_POSITION = 0,
     GET_ROTATION = 1,
@@ -629,7 +627,7 @@ enum class eGameMessageType : uint16_t {
     GET_INSTRUCTION_COUNT = 676,
     GET_IS_NPC = 677,
     ACTIVATE_BUBBLE_BUFF = 678,
-	DECTIVATE_BUBBLE_BUFF = 679, // This is spelled wrong in the client, so we misspell it here.
+    DECTIVATE_BUBBLE_BUFF = 679, // thanks netdevil
     EXHIBIT_VOTE = 680,
     ADD_PET_TO_PLAYER = 681,
     REMOVE_PET_FROM_PLAYER = 682,
@@ -1604,10 +1602,4 @@ enum class eGameMessageType : uint16_t {
     GET_IS_ON_RAIL = 1772
 };
 
-template <>
-struct magic_enum::customize::enum_range<eGameMessageType> {
-	static constexpr int min = 0;
-	static constexpr int max = 1772;
-};
-
 #endif  //!__EGAMEMESSAGETYPE__H__

dCommon/dEnums/ePetAbilityType.h

@@ -1,13 +0,0 @@
-#ifndef __EPETABILITYTYPE__H__
-#define __EPETABILITYTYPE__H__
-
-#include <cstdint>
-
-enum class ePetAbilityType : uint32_t {
-	Invalid,
-	GoToObject,
-	JumpOnObject,
-	DigAtPosition
-};
-
-#endif  //!__EPETABILITYTYPE__H__

dCommon/dEnums/eQuickBuildState.h

@@ -1,15 +0,0 @@
-#ifndef __EQUICKBUILDSTATE__H__
-#define __EQUICKBUILDSTATE__H__
-
-#include <cstdint>
-
-enum class eQuickBuildState : uint32_t {
-	OPEN,
-	COMPLETED = 2,
-	RESETTING = 4,
-	BUILDING,
-	INCOMPLETE
-};
-
-
-#endif  //!__EQUICKBUILDSTATE__H__

dCommon/dEnums/eRebuildState.h

@@ -0,0 +1,15 @@
+#ifndef __EREBUILDSTATE__H__
+#define __EREBUILDSTATE__H__
+
+#include <cstdint>
+
+enum class eRebuildState : uint32_t {
+	OPEN,
+	COMPLETED = 2,
+	RESETTING = 4,
+	BUILDING,
+	INCOMPLETE
+};
+
+
+#endif  //!__EREBUILDSTATE__H__

dCommon/dEnums/eWorldMessageType.h

@@ -3,8 +3,6 @@
 
 #include <cstdint>
 
-#include "magic_enum.hpp"
-
 enum class eWorldMessageType : uint32_t {
 	VALIDATION = 1,  // 				Session info
 	CHARACTER_LIST_REQUEST,
@@ -42,10 +40,4 @@ enum class eWorldMessageType : uint32_t {
 	UI_HELP_TOP_5 = 91
 };
 
-template <>
-struct magic_enum::customize::enum_range<eWorldMessageType> {
-	static constexpr int min = 0;
-	static constexpr int max = 91;
-};
-
 #endif  //!__EWORLDMESSAGETYPE__H__

dDatabase/CDClientDatabase/CDClientDatabase.cpp

@@ -4,13 +4,9 @@
 // Static Variables
 static CppSQLite3DB* conn = new CppSQLite3DB();
 
-// Status Variables
-bool CDClientDatabase::isConnected = false;
-
 //! Opens a connection with the CDClient
 void CDClientDatabase::Connect(const std::string& filename) {
 	conn->open(filename.c_str());
-	isConnected = true;
 }
 
 //! Queries the CDClient

dDatabase/CDClientDatabase/CDClientDatabase.h

@@ -15,10 +15,6 @@
 
 //! The CDClient Database namespace
 namespace CDClientDatabase {
-	/**
-	 * Boolean defining the connection status of CDClient
-	*/
-	extern bool isConnected;
 
 	//! Opens a connection with the CDClient
 	/*!

dDatabase/CDClientDatabase/CDClientManager.cpp

@@ -3,7 +3,6 @@
 #include "CDAnimationsTable.h"
 #include "CDBehaviorParameterTable.h"
 #include "CDBehaviorTemplateTable.h"
-#include "CDClientDatabase.h"
 #include "CDComponentsRegistryTable.h"
 #include "CDCurrencyTableTable.h"
 #include "CDDestructibleComponentTable.h"
@@ -40,13 +39,9 @@
 #include "CDRailActivatorComponent.h"
 #include "CDRewardCodesTable.h"
 
-#include <exception>
-
-#ifndef CDCLIENT_CACHE_ALL
 // Uncomment this to cache the full cdclient database into memory. This will make the server load faster, but will use more memory.
 // A vanilla CDClient takes about 46MB of memory + the regular world data.
 // #define CDCLIENT_CACHE_ALL
-#endif // CDCLIENT_CACHE_ALL
 
 #ifdef CDCLIENT_CACHE_ALL
 	#define CDCLIENT_DONT_CACHE_TABLE(x) x
@@ -54,16 +49,7 @@
 	#define CDCLIENT_DONT_CACHE_TABLE(x)
 #endif
 
-class CDClientConnectionException : public std::exception {
+CDClientManager::CDClientManager() {
-public:
-	virtual const char* what() const throw() {
-		return "CDClientDatabase is not connected!";
-	}
-};
-
-void CDClientManager::LoadValuesFromDatabase() {
-	if (!CDClientDatabase::isConnected) throw CDClientConnectionException();
-
 	CDActivityRewardsTable::Instance().LoadValuesFromDatabase();
 	CDActivitiesTable::Instance().LoadValuesFromDatabase();
 	CDCLIENT_DONT_CACHE_TABLE(CDAnimationsTable::Instance().LoadValuesFromDatabase());
@@ -91,7 +77,6 @@ void CDClientManager::LoadValuesFromDatabase() {
 	CDCLIENT_DONT_CACHE_TABLE(CDObjectsTable::Instance().LoadValuesFromDatabase());
 	CDPhysicsComponentTable::Instance().LoadValuesFromDatabase();
 	CDPackageComponentTable::Instance().LoadValuesFromDatabase();
-	CDPetComponentTable::Instance().LoadValuesFromDatabase();
 	CDProximityMonitorComponentTable::Instance().LoadValuesFromDatabase();
 	CDPropertyEntranceComponentTable::Instance().LoadValuesFromDatabase();
 	CDPropertyTemplateTable::Instance().LoadValuesFromDatabase();
@@ -105,9 +90,3 @@ void CDClientManager::LoadValuesFromDatabase() {
 	CDVendorComponentTable::Instance().LoadValuesFromDatabase();
 	CDZoneTableTable::Instance().LoadValuesFromDatabase();
 }
-
-void CDClientManager::LoadValuesFromDefaults() {
-	LOG("Loading default CDClient tables!");
-
-	CDPetComponentTable::Instance().LoadValuesFromDefaults();
-}

dDatabase/CDClientDatabase/CDClientManager.h

@@ -11,10 +11,7 @@
  */
 class CDClientManager : public Singleton<CDClientManager> {
 public:
-	CDClientManager() = default;
+	CDClientManager();
-
-	void LoadValuesFromDatabase();
-	void LoadValuesFromDefaults();
 
 	/**
 	 * Fetch a table from CDClient

dDatabase/CDClientDatabase/CDClientTables/CDActivitiesTable.cpp

@@ -2,7 +2,7 @@
 
 void CDActivitiesTable::LoadValuesFromDatabase() {
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM Activities");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDActivitiesTable.h

@@ -4,22 +4,22 @@
 #include "CDTable.h"
 
 struct CDActivities {
-	uint32_t ActivityID;
+	unsigned int ActivityID;
-	uint32_t locStatus;
+	unsigned int locStatus;
-	uint32_t instanceMapID;
+	unsigned int instanceMapID;
-	uint32_t minTeams;
+	unsigned int minTeams;
-	uint32_t maxTeams;
+	unsigned int maxTeams;
-	uint32_t minTeamSize;
+	unsigned int minTeamSize;
-	uint32_t maxTeamSize;
+	unsigned int maxTeamSize;
-	uint32_t waitTime;
+	unsigned int waitTime;
-	uint32_t startDelay;
+	unsigned int startDelay;
 	bool requiresUniqueData;
-	uint32_t leaderboardType;
+	unsigned int leaderboardType;
 	bool localize;
-	int32_t optionalCostLOT;
+	int optionalCostLOT;
-	int32_t optionalCostCount;
+	int optionalCostCount;
 	bool showUIRewards;
-	uint32_t CommunityActivityFlagID;
+	unsigned int CommunityActivityFlagID;
 	std::string gate_version;
 	bool noTeamLootOnDeath;
 	float optionalPercentage;

dDatabase/CDClientDatabase/CDClientTables/CDActivityRewardsTable.cpp

@@ -3,7 +3,7 @@
 void CDActivityRewardsTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM ActivityRewards");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDActivityRewardsTable.h

@@ -4,12 +4,12 @@
 #include "CDTable.h"
 
 struct CDActivityRewards {
-	uint32_t objectTemplate;        //!< The object template (?)
+	unsigned int objectTemplate;        //!< The object template (?)
-	uint32_t ActivityRewardIndex;   //!< The activity reward index
+	unsigned int ActivityRewardIndex;   //!< The activity reward index
-	int32_t activityRating;                 //!< The activity rating
+	int activityRating;                 //!< The activity rating
-	uint32_t LootMatrixIndex;       //!< The loot matrix index
+	unsigned int LootMatrixIndex;       //!< The loot matrix index
-	uint32_t CurrencyIndex;         //!< The currency index
+	unsigned int CurrencyIndex;         //!< The currency index
-	uint32_t ChallengeRating;       //!< The challenge rating
+	unsigned int ChallengeRating;       //!< The challenge rating
 	std::string description;            //!< The description
 };
 

dDatabase/CDClientDatabase/CDClientTables/CDAnimationsTable.h

@@ -4,13 +4,13 @@
 #include <list>
 
 struct CDAnimation {
-	// uint32_t animationGroupID;
+	// unsigned int animationGroupID;
 	// std::string animation_type;
 	// The above two are a pair to represent a primary key in the map.
 	std::string animation_name;        //!< The animation name
 	float chance_to_play;           //!< The chance to play the animation
-	UNUSED_COLUMN(uint32_t min_loops;)                 //!< The minimum number of loops
+	UNUSED_COLUMN(unsigned int min_loops;)                 //!< The minimum number of loops
-	UNUSED_COLUMN(uint32_t max_loops;)                 //!< The maximum number of loops
+	UNUSED_COLUMN(unsigned int max_loops;)                 //!< The maximum number of loops
 	float animation_length;         //!< The animation length
 	UNUSED_COLUMN(bool hideEquip;)                 //!< Whether or not to hide the equip
 	UNUSED_COLUMN(bool ignoreUpperBody;)           //!< Whether or not to ignore the upper body

dDatabase/CDClientDatabase/CDClientTables/CDBehaviorTemplateTable.cpp

@@ -3,7 +3,7 @@
 void CDBehaviorTemplateTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM BehaviorTemplate");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDBehaviorTemplateTable.h

@@ -6,9 +6,9 @@
 #include <unordered_set>
 
 struct CDBehaviorTemplate {
-	uint32_t behaviorID;                                         //!< The Behavior ID
+	unsigned int behaviorID;                                         //!< The Behavior ID
-	uint32_t templateID;                                         //!< The Template ID (LOT)
+	unsigned int templateID;                                         //!< The Template ID (LOT)
-	uint32_t effectID;                                           //!< The Effect ID attached
+	unsigned int effectID;                                           //!< The Effect ID attached
 	std::unordered_set<std::string>::iterator effectHandle;          //!< The effect handle
 };
 

dDatabase/CDClientDatabase/CDClientTables/CDBrickIDTableTable.cpp

@@ -3,7 +3,7 @@
 void CDBrickIDTableTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM BrickIDTable");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDBrickIDTableTable.h

@@ -10,8 +10,8 @@
 
  //! BrickIDTable Entry Struct
 struct CDBrickIDTable {
-	uint32_t NDObjectID;
+	unsigned int NDObjectID;
-	uint32_t LEGOBrickID;
+	unsigned int LEGOBrickID;
 };
 
 

dDatabase/CDClientDatabase/CDClientTables/CDComponentsRegistryTable.cpp

@@ -10,7 +10,7 @@ void CDComponentsRegistryTable::LoadValuesFromDatabase() {
 		entry.component_type = static_cast<eReplicaComponentType>(tableData.getIntField("component_type", 0));
 		entry.component_id = tableData.getIntField("component_id", -1);
 
-		this->mappedEntries.insert_or_assign(static_cast<uint64_t>(entry.component_type) << 32 | static_cast<uint64_t>(entry.id), entry.component_id);
+		this->mappedEntries.insert_or_assign(((uint64_t)entry.component_type) << 32 | ((uint64_t)entry.id), entry.component_id);
 		this->mappedEntries.insert_or_assign(entry.id, 0);
 
 		tableData.nextRow();
@@ -22,7 +22,7 @@ void CDComponentsRegistryTable::LoadValuesFromDatabase() {
 int32_t CDComponentsRegistryTable::GetByIDAndType(uint32_t id, eReplicaComponentType componentType, int32_t defaultValue) {
 	auto exists = mappedEntries.find(id);
 	if (exists != mappedEntries.end()) {
-		auto iter = mappedEntries.find(static_cast<uint64_t>(componentType) << 32 | static_cast<uint64_t>(id));
+		auto iter = mappedEntries.find(((uint64_t)componentType) << 32 | ((uint64_t)id));
 		return iter == mappedEntries.end() ? defaultValue : iter->second;
 	}
 
@@ -38,14 +38,15 @@ int32_t CDComponentsRegistryTable::GetByIDAndType(uint32_t id, eReplicaComponent
 		entry.component_type = static_cast<eReplicaComponentType>(tableData.getIntField("component_type", 0));
 		entry.component_id = tableData.getIntField("component_id", -1);
 
-		this->mappedEntries.insert_or_assign(static_cast<uint64_t>(entry.component_type) << 32 | static_cast<uint64_t>(entry.id), entry.component_id);
+		this->mappedEntries.insert_or_assign(((uint64_t)entry.component_type) << 32 | ((uint64_t)entry.id), entry.component_id);
 
 		tableData.nextRow();
 	}
 
 	mappedEntries.insert_or_assign(id, 0);
 
-	auto iter = this->mappedEntries.find(static_cast<uint64_t>(componentType) << 32 | static_cast<uint64_t>(id));
+	auto iter = this->mappedEntries.find(((uint64_t)componentType) << 32 | ((uint64_t)id));
 
 	return iter == this->mappedEntries.end() ? defaultValue : iter->second;
 }
+

dDatabase/CDClientDatabase/CDClientTables/CDComponentsRegistryTable.h

@@ -7,9 +7,9 @@
 
 enum class eReplicaComponentType : uint32_t;
 struct CDComponentsRegistry {
-	uint32_t id;                    //!< The LOT is used as the ID
+	unsigned int id;                    //!< The LOT is used as the ID
 	eReplicaComponentType component_type;        //!< See ComponentTypes enum for values
-	uint32_t component_id;          //!< The ID used within the component's table (0 may either mean it's non-networked, or that the ID is actually 0
+	unsigned int component_id;          //!< The ID used within the component's table (0 may either mean it's non-networked, or that the ID is actually 0
 };
 
 

dDatabase/CDClientDatabase/CDClientTables/CDCurrencyTableTable.cpp

@@ -4,7 +4,7 @@
 void CDCurrencyTableTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM CurrencyTable");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDCurrencyTableTable.h

@@ -10,11 +10,11 @@
 
  //! CurrencyTable Struct
 struct CDCurrencyTable {
-	uint32_t currencyIndex;         //!< The Currency Index
+	unsigned int currencyIndex;         //!< The Currency Index
-	uint32_t npcminlevel;           //!< The minimum level of the npc
+	unsigned int npcminlevel;           //!< The minimum level of the npc
-	uint32_t minvalue;              //!< The minimum currency
+	unsigned int minvalue;              //!< The minimum currency
-	uint32_t maxvalue;              //!< The maximum currency
+	unsigned int maxvalue;              //!< The maximum currency
-	uint32_t id;                    //!< The ID of the currency index
+	unsigned int id;                    //!< The ID of the currency index
 };
 
 //! CurrencyTable table

dDatabase/CDClientDatabase/CDClientTables/CDDestructibleComponentTable.cpp

@@ -2,7 +2,7 @@
 
 void CDDestructibleComponentTable::LoadValuesFromDatabase() {
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM DestructibleComponent");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDDestructibleComponentTable.h

@@ -4,20 +4,20 @@
 #include "CDTable.h"
 
 struct CDDestructibleComponent {
-	uint32_t id;                            //!< The component ID from the ComponentsRegistry Table
+	unsigned int id;                            //!< The component ID from the ComponentsRegistry Table
-	int32_t faction;                       //!< The Faction ID of the object
+	int faction;                       //!< The Faction ID of the object
 	std::string factionList;               //!< A list of the faction IDs
-	int32_t life;                          //!< The amount of life of the object
+	int life;                          //!< The amount of life of the object
-	uint32_t imagination;                   //!< The amount of imagination of the object
+	unsigned int imagination;                   //!< The amount of imagination of the object
-	int32_t LootMatrixIndex;               //!< The Loot Matrix Index
+	int LootMatrixIndex;               //!< The Loot Matrix Index
-	int32_t CurrencyIndex;                 //!< The Currency Index
+	int CurrencyIndex;                 //!< The Currency Index
-	uint32_t level;                         //!< ???
+	unsigned int level;                         //!< ???
 	float armor;                        //!< The amount of armor of the object
-	uint32_t death_behavior;                //!< The behavior ID of the death behavior
+	unsigned int death_behavior;                //!< The behavior ID of the death behavior
 	bool isnpc;                         //!< Whether or not the object is an NPC
-	uint32_t attack_priority;               //!< ???
+	unsigned int attack_priority;               //!< ???
 	bool isSmashable;                   //!< Whether or not the object is smashable
-	int32_t difficultyLevel;               //!< ???
+	int difficultyLevel;               //!< ???
 };
 
 class CDDestructibleComponentTable : public CDTable<CDDestructibleComponentTable> {

dDatabase/CDClientDatabase/CDClientTables/CDEmoteTable.cpp

@@ -20,7 +20,7 @@ void CDEmoteTableTable::LoadValuesFromDatabase() {
 	tableData.finalize();
 }
 
-CDEmoteTable* CDEmoteTableTable::GetEmote(int32_t id) {
+CDEmoteTable* CDEmoteTableTable::GetEmote(int id) {
 	auto itr = entries.find(id);
 	return itr != entries.end() ? &itr->second : nullptr;
 }

dDatabase/CDClientDatabase/CDClientTables/CDEmoteTable.h

@@ -16,11 +16,11 @@ struct CDEmoteTable {
 		gateVersion = "";
 	}
 
-	int32_t ID;
+	int ID;
 	std::string animationName;
 	std::string iconFilename;
-	int32_t locState;
+	int locState;
-	int32_t channel;
+	int channel;
 	bool locked;
 	bool localize;
 	std::string gateVersion;
@@ -33,5 +33,5 @@ private:
 public:
 	void LoadValuesFromDatabase();
 	// Returns an emote by ID
-	CDEmoteTable* GetEmote(int32_t id);
+	CDEmoteTable* GetEmote(int id);
 };

dDatabase/CDClientDatabase/CDClientTables/CDFeatureGatingTable.cpp

@@ -3,7 +3,7 @@
 void CDFeatureGatingTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM FeatureGating");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDInventoryComponentTable.cpp

@@ -3,7 +3,7 @@
 void CDInventoryComponentTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM InventoryComponent");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDInventoryComponentTable.h

@@ -4,9 +4,9 @@
 #include "CDTable.h"
 
 struct CDInventoryComponent {
-	uint32_t id;                //!< The component ID for this object
+	unsigned int id;                //!< The component ID for this object
-	uint32_t itemid;            //!< The LOT of the object
+	unsigned int itemid;            //!< The LOT of the object
-	uint32_t count;             //!< The count of the items the object has
+	unsigned int count;             //!< The count of the items the object has
 	bool equip;             //!< Whether or not to equip the item
 };
 

dDatabase/CDClientDatabase/CDClientTables/CDItemComponentTable.cpp

@@ -5,7 +5,7 @@ CDItemComponent CDItemComponentTable::Default = {};
 
 void CDItemComponentTable::LoadValuesFromDatabase() {
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM ItemComponent");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);
@@ -69,7 +69,7 @@ void CDItemComponentTable::LoadValuesFromDatabase() {
 	tableData.finalize();
 }
 
-const CDItemComponent& CDItemComponentTable::GetItemComponentByID(uint32_t skillID) {
+const CDItemComponent& CDItemComponentTable::GetItemComponentByID(unsigned int skillID) {
 	const auto& it = this->entries.find(skillID);
 	if (it != this->entries.end()) {
 		return it->second;

dDatabase/CDClientDatabase/CDClientTables/CDItemComponentTable.h

@@ -5,60 +5,60 @@
 #include "dCommonVars.h"
 
 struct CDItemComponent {
-	uint32_t id;                        //!< The Component ID
+	unsigned int id;                        //!< The Component ID
 	std::string equipLocation;         //!< The equip location
-	uint32_t baseValue;                 //!< The monetary base value of the item
+	unsigned int baseValue;                 //!< The monetary base value of the item
 	bool isKitPiece;                //!< Whether or not the item belongs to a kit
-	uint32_t rarity;                    //!< The rarity of the item
+	unsigned int rarity;                    //!< The rarity of the item
-	uint32_t itemType;                  //!< The item type
+	unsigned int itemType;                  //!< The item type
 	int64_t itemInfo;                  //!< The item info
 	bool inLootTable;               //!< Whether or not the item is in a loot table
 	bool inVendor;                  //!< Whether or not the item is in a vendor inventory
 	bool isUnique;                  //!< ???
 	bool isBOP;                     //!< ???
 	bool isBOE;                     //!< ???
-	uint32_t reqFlagID;                 //!< User must have completed this flag to get the item
+	unsigned int reqFlagID;                 //!< User must have completed this flag to get the item
-	uint32_t reqSpecialtyID;            //!< ???
+	unsigned int reqSpecialtyID;            //!< ???
-	uint32_t reqSpecRank;               //!< ???
+	unsigned int reqSpecRank;               //!< ???
-	uint32_t reqAchievementID;          //!< The required achievement must be completed
+	unsigned int reqAchievementID;          //!< The required achievement must be completed
-	uint32_t stackSize;                 //!< The stack size of the item
+	unsigned int stackSize;                 //!< The stack size of the item
-	uint32_t color1;                    //!< Something to do with item color...
+	unsigned int color1;                    //!< Something to do with item color...
-	uint32_t decal;                     //!< The decal of the item
+	unsigned int decal;                     //!< The decal of the item
-	uint32_t offsetGroupID;             //!< Something to do with group IDs
+	unsigned int offsetGroupID;             //!< Something to do with group IDs
-	uint32_t buildTypes;                //!< Something to do with building
+	unsigned int buildTypes;                //!< Something to do with building
 	std::string reqPrecondition;       //!< The required precondition
-	uint32_t animationFlag;             //!< The Animation Flag
+	unsigned int animationFlag;             //!< The Animation Flag
-	uint32_t equipEffects;              //!< The effect played when the item is equipped
+	unsigned int equipEffects;              //!< The effect played when the item is equipped
 	bool readyForQA;                //!< ???
-	uint32_t itemRating;                //!< ???
+	unsigned int itemRating;                //!< ???
 	bool isTwoHanded;               //!< Whether or not the item is double handed
-	uint32_t minNumRequired;            //!< Maybe the minimum number required for a mission, or to own this object?
+	unsigned int minNumRequired;            //!< Maybe the minimum number required for a mission, or to own this object?
-	uint32_t delResIndex;               //!< ???
+	unsigned int delResIndex;               //!< ???
-	uint32_t currencyLOT;               //!< ???
+	unsigned int currencyLOT;               //!< ???
-	uint32_t altCurrencyCost;           //!< ???
+	unsigned int altCurrencyCost;           //!< ???
 	std::string subItems;              //!< A comma seperate string of sub items (maybe for multi-itemed things like faction test gear set)
 	UNUSED(std::string audioEventUse);         //!< ???
 	bool noEquipAnimation;          //!< Whether or not there is an equip animation
-	uint32_t commendationLOT;           //!< The commendation LOT
+	unsigned int commendationLOT;           //!< The commendation LOT
-	uint32_t commendationCost;          //!< The commendation cost
+	unsigned int commendationCost;          //!< The commendation cost
 	UNUSED(std::string audioEquipMetaEventSet);    //!< ???
 	std::string currencyCosts;         //!< Used for crafting
 	UNUSED(std::string ingredientInfo);        //!< Unused
-	uint32_t locStatus;                 //!< ???
+	unsigned int locStatus;                 //!< ???
-	uint32_t forgeType;                 //!< Forge Type
+	unsigned int forgeType;                 //!< Forge Type
 	float SellMultiplier;           //!< Something to do with early vendors perhaps (but replaced)
 };
 
 class CDItemComponentTable : public CDTable<CDItemComponentTable> {
 private:
-	std::map<uint32_t, CDItemComponent> entries;
+	std::map<unsigned int, CDItemComponent> entries;
 
 public:
 	void LoadValuesFromDatabase();
 	static std::map<LOT, uint32_t> ParseCraftingCurrencies(const CDItemComponent& itemComponent);
 
 	// Gets an entry by ID
-	const CDItemComponent& GetItemComponentByID(uint32_t skillID);
+	const CDItemComponent& GetItemComponentByID(unsigned int skillID);
 
 	static CDItemComponent Default;
 };

dDatabase/CDClientDatabase/CDClientTables/CDItemSetSkillsTable.cpp

@@ -3,7 +3,7 @@
 void CDItemSetSkillsTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM ItemSetSkills");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);
@@ -44,7 +44,7 @@ const std::vector<CDItemSetSkills>& CDItemSetSkillsTable::GetEntries() const {
 	return this->entries;
 }
 
-std::vector<CDItemSetSkills> CDItemSetSkillsTable::GetBySkillID(uint32_t SkillSetID) {
+std::vector<CDItemSetSkills> CDItemSetSkillsTable::GetBySkillID(unsigned int SkillSetID) {
 	std::vector<CDItemSetSkills> toReturn;
 
 	for (CDItemSetSkills entry : this->entries) {

dDatabase/CDClientDatabase/CDClientTables/CDItemSetSkillsTable.h

@@ -4,9 +4,9 @@
 #include "CDTable.h"
 
 struct CDItemSetSkills {
-	uint32_t SkillSetID;            //!< The skill set ID
+	unsigned int SkillSetID;            //!< The skill set ID
-	uint32_t SkillID;               //!< The skill ID
+	unsigned int SkillID;               //!< The skill ID
-	uint32_t SkillCastType;         //!< The skill cast type
+	unsigned int SkillCastType;         //!< The skill cast type
 };
 
 class CDItemSetSkillsTable : public CDTable<CDItemSetSkillsTable> {
@@ -20,5 +20,5 @@ public:
 
 	const std::vector<CDItemSetSkills>& GetEntries() const;
 
-	std::vector<CDItemSetSkills> GetBySkillID(uint32_t SkillSetID);
+	std::vector<CDItemSetSkills> GetBySkillID(unsigned int SkillSetID);
 };

dDatabase/CDClientDatabase/CDClientTables/CDItemSetsTable.cpp

@@ -3,7 +3,7 @@
 void CDItemSetsTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM ItemSets");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDItemSetsTable.h

@@ -4,20 +4,20 @@
 #include "CDTable.h"
 
 struct CDItemSets {
-	uint32_t setID;             //!< The item set ID
+	unsigned int setID;             //!< The item set ID
-	uint32_t locStatus;         //!< The loc status
+	unsigned int locStatus;         //!< The loc status
 	std::string itemIDs;       //!< THe item IDs
-	uint32_t kitType;           //!< The item kit type
+	unsigned int kitType;           //!< The item kit type
-	uint32_t kitRank;           //!< The item kit rank
+	unsigned int kitRank;           //!< The item kit rank
-	uint32_t kitImage;          //!< The item kit image
+	unsigned int kitImage;          //!< The item kit image
-	uint32_t skillSetWith2;     //!< The skill set with 2
+	unsigned int skillSetWith2;     //!< The skill set with 2
-	uint32_t skillSetWith3;     //!< The skill set with 3
+	unsigned int skillSetWith3;     //!< The skill set with 3
-	uint32_t skillSetWith4;     //!< The skill set with 4
+	unsigned int skillSetWith4;     //!< The skill set with 4
-	uint32_t skillSetWith5;     //!< The skill set with 5
+	unsigned int skillSetWith5;     //!< The skill set with 5
-	uint32_t skillSetWith6;     //!< The skill set with 6
+	unsigned int skillSetWith6;     //!< The skill set with 6
 	bool localize;          //!< Whether or localize
 	std::string gate_version;  //!< The gate version
-	uint32_t kitID;             //!< The kit ID
+	unsigned int kitID;             //!< The kit ID
 	float priority;         //!< The priority
 };
 

dDatabase/CDClientDatabase/CDClientTables/CDLevelProgressionLookupTable.cpp

@@ -3,7 +3,7 @@
 void CDLevelProgressionLookupTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM LevelProgressionLookup");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDLevelProgressionLookupTable.h

@@ -4,8 +4,8 @@
 #include "CDTable.h"
 
 struct CDLevelProgressionLookup {
-	uint32_t id;                    //!< The Level ID
+	unsigned int id;                    //!< The Level ID
-	uint32_t requiredUScore;        //!< The required LEGO Score
+	unsigned int requiredUScore;        //!< The required LEGO Score
 	std::string BehaviorEffect;    //!< The behavior effect attached to this
 };
 

dDatabase/CDClientDatabase/CDClientTables/CDLootMatrixTable.cpp

@@ -16,7 +16,7 @@ CDLootMatrix CDLootMatrixTable::ReadRow(CppSQLite3Query& tableData) const {
 void CDLootMatrixTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM LootMatrix");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDLootMatrixTable.h

@@ -4,12 +4,12 @@
 #include "CDTable.h"
 
 struct CDLootMatrix {
-	uint32_t LootTableIndex;            //!< The Loot Table Index
+	unsigned int LootTableIndex;            //!< The Loot Table Index
-	uint32_t RarityTableIndex;          //!< The Rarity Table Index
+	unsigned int RarityTableIndex;          //!< The Rarity Table Index
 	float percent;                   //!< The percent that this matrix is used?
-	uint32_t minToDrop;                 //!< The minimum amount of loot from this matrix to drop
+	unsigned int minToDrop;                 //!< The minimum amount of loot from this matrix to drop
-	uint32_t maxToDrop;                 //!< The maximum amount of loot from this matrix to drop
+	unsigned int maxToDrop;                 //!< The maximum amount of loot from this matrix to drop
-	uint32_t flagID;                    //!< ???
+	unsigned int flagID;                    //!< ???
 	UNUSED(std::string gate_version);          //!< The Gate Version
 };
 

dDatabase/CDClientDatabase/CDClientTables/CDLootTableTable.cpp

@@ -40,7 +40,7 @@ CDLootTable CDLootTableTable::ReadRow(CppSQLite3Query& tableData) const {
 void CDLootTableTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM LootTable");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDLootTableTable.h

@@ -4,10 +4,10 @@
 #include "CDTable.h"
 
 struct CDLootTable {
-	uint32_t itemid;                 //!< The LOT of the item
+	unsigned int itemid;                 //!< The LOT of the item
-	uint32_t LootTableIndex;         //!< The Loot Table Index
+	unsigned int LootTableIndex;         //!< The Loot Table Index
 	bool MissionDrop;               //!< Whether or not this loot table is a mission drop
-	uint32_t sortPriority;           //!< The sorting priority
+	unsigned int sortPriority;           //!< The sorting priority
 };
 
 typedef uint32_t LootTableIndex;

dDatabase/CDClientDatabase/CDClientTables/CDMissionEmailTable.cpp

@@ -3,7 +3,7 @@
 void CDMissionEmailTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM MissionEmail");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);
@@ -25,7 +25,7 @@ void CDMissionEmailTable::LoadValuesFromDatabase() {
 		entry.notificationGroup = tableData.getIntField("notificationGroup", -1);
 		entry.missionID = tableData.getIntField("missionID", -1);
 		entry.attachmentLOT = tableData.getIntField("attachmentLOT", 0);
-		entry.localize = static_cast<bool>(tableData.getIntField("localize", 1));
+		entry.localize = (bool)tableData.getIntField("localize", -1);
 		entry.locStatus = tableData.getIntField("locStatus", -1);
 		entry.gate_version = tableData.getStringField("gate_version", "");
 
@@ -50,3 +50,4 @@ std::vector<CDMissionEmail> CDMissionEmailTable::Query(std::function<bool(CDMiss
 const std::vector<CDMissionEmail>& CDMissionEmailTable::GetEntries() const {
 	return this->entries;
 }
+

dDatabase/CDClientDatabase/CDClientTables/CDMissionEmailTable.h

@@ -4,13 +4,13 @@
 #include "CDTable.h"
 
 struct CDMissionEmail {
-	uint32_t ID;
+	unsigned int ID;
-	uint32_t messageType;
+	unsigned int messageType;
-	uint32_t notificationGroup;
+	unsigned int notificationGroup;
-	uint32_t missionID;
+	unsigned int missionID;
-	uint32_t attachmentLOT;
+	unsigned int attachmentLOT;
 	bool localize;
-	uint32_t locStatus;
+	unsigned int locStatus;
 	std::string gate_version;
 };
 

dDatabase/CDClientDatabase/CDClientTables/CDMissionNPCComponentTable.cpp

@@ -3,7 +3,7 @@
 void CDMissionNPCComponentTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM MissionNPCComponent");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDMissionNPCComponentTable.h

@@ -4,8 +4,8 @@
 #include "CDTable.h"
 
 struct CDMissionNPCComponent {
-	uint32_t id;                //!< The ID
+	unsigned int id;                //!< The ID
-	uint32_t missionID;         //!< The Mission ID
+	unsigned int missionID;         //!< The Mission ID
 	bool offersMission;     //!< Whether or not this NPC offers a mission
 	bool acceptsMission;    //!< Whether or not this NPC accepts a mission
 	std::string gate_version;  //!< The gate version

dDatabase/CDClientDatabase/CDClientTables/CDMissionTasksTable.cpp

@@ -3,7 +3,7 @@
 void CDMissionTasksTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM MissionTasks");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDMissionTasksTable.h

@@ -4,17 +4,17 @@
 #include "CDTable.h"
 
 struct CDMissionTasks {
-	uint32_t id;                //!< The Mission ID that the task belongs to
+	unsigned int id;                //!< The Mission ID that the task belongs to
-	UNUSED(uint32_t locStatus);         //!< ???
+	UNUSED(unsigned int locStatus);         //!< ???
-	uint32_t taskType;          //!< The task type
+	unsigned int taskType;          //!< The task type
-	uint32_t target;            //!< The mission target
+	unsigned int target;            //!< The mission target
 	std::string targetGroup;        //!< The mission target group
-	int32_t targetValue;       //!< The target value
+	int targetValue;       //!< The target value
 	std::string taskParam1;    //!< The task param 1
 	UNUSED(std::string largeTaskIcon); //!< ???
-	UNUSED(uint32_t IconID);            //!< ???
+	UNUSED(unsigned int IconID);            //!< ???
-	uint32_t uid;               //!< ???
+	unsigned int uid;               //!< ???
-	UNUSED(uint32_t largeTaskIconID);   //!< ???
+	UNUSED(unsigned int largeTaskIconID);   //!< ???
 	UNUSED(bool localize);          //!< Whether or not the task should be localized
 	UNUSED(std::string gate_version);  //!< ???
 };

dDatabase/CDClientDatabase/CDClientTables/CDMissionsTable.cpp

@@ -5,7 +5,7 @@ CDMissions CDMissionsTable::Default = {};
 void CDMissionsTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM Missions");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDMissionsTable.h

@@ -6,58 +6,58 @@
 #include <cstdint>
 
 struct CDMissions {
-	int32_t id;                        //!< The Mission ID
+	int id;                        //!< The Mission ID
 	std::string defined_type;          //!< The type of mission
 	std::string defined_subtype;       //!< The subtype of the mission
-	int32_t UISortOrder;               //!< The UI Sort Order for the mission
+	int UISortOrder;               //!< The UI Sort Order for the mission
-	int32_t offer_objectID;            //!< The LOT of the mission giver
+	int offer_objectID;            //!< The LOT of the mission giver
-	int32_t target_objectID;           //!< The LOT of the mission's target
+	int target_objectID;           //!< The LOT of the mission's target
 	int64_t reward_currency;           //!< The amount of currency to reward the player
-	int32_t LegoScore;                 //!< The amount of LEGO Score to reward the player
+	int LegoScore;                 //!< The amount of LEGO Score to reward the player
 	int64_t reward_reputation;         //!< The reputation to award the player
 	bool isChoiceReward;            //!< Whether or not the user has the option to choose their loot
-	int32_t reward_item1;              //!< The first rewarded item
+	int reward_item1;              //!< The first rewarded item
-	int32_t reward_item1_count;        //!< The count of the first item to be rewarded
+	int reward_item1_count;        //!< The count of the first item to be rewarded
-	int32_t reward_item2;              //!< The second rewarded item
+	int reward_item2;              //!< The second rewarded item
-	int32_t reward_item2_count;        //!< The count of the second item to be rewarded
+	int reward_item2_count;        //!< The count of the second item to be rewarded
-	int32_t reward_item3;              //!< The third rewarded item
+	int reward_item3;              //!< The third rewarded item
-	int32_t reward_item3_count;        //!< The count of the third item to be rewarded
+	int reward_item3_count;        //!< The count of the third item to be rewarded
-	int32_t reward_item4;              //!< The fourth rewarded item
+	int reward_item4;              //!< The fourth rewarded item
-	int32_t reward_item4_count;        //!< The count of the fourth item to be rewarded
+	int reward_item4_count;        //!< The count of the fourth item to be rewarded
-	int32_t reward_emote;              //!< The first emote to be rewarded
+	int reward_emote;              //!< The first emote to be rewarded
-	int32_t reward_emote2;             //!< The second emote to be rewarded
+	int reward_emote2;             //!< The second emote to be rewarded
-	int32_t reward_emote3;             //!< The third emote to be rewarded
+	int reward_emote3;             //!< The third emote to be rewarded
-	int32_t reward_emote4;             //!< The fourth emote to be rewarded
+	int reward_emote4;             //!< The fourth emote to be rewarded
-	int32_t reward_maximagination;     //!< The amount of max imagination to reward
+	int reward_maximagination;     //!< The amount of max imagination to reward
-	int32_t reward_maxhealth;          //!< The amount of max health to reward
+	int reward_maxhealth;          //!< The amount of max health to reward
-	int32_t reward_maxinventory;       //!< The amount of max inventory to reward
+	int reward_maxinventory;       //!< The amount of max inventory to reward
-	int32_t reward_maxmodel;           //!< ???
+	int reward_maxmodel;           //!< ???
-	int32_t reward_maxwidget;          //!< ???
+	int reward_maxwidget;          //!< ???
-	int32_t reward_maxwallet;          //!< ???
+	int reward_maxwallet;          //!< ???
 	bool repeatable;                //!< Whether or not this mission can be repeated (for instance, is it a daily mission)
 	int64_t reward_currency_repeatable;   //!< The repeatable reward
-	int32_t reward_item1_repeatable;      //!< The first rewarded item
+	int reward_item1_repeatable;      //!< The first rewarded item
-	int32_t reward_item1_repeat_count;    //!< The count of the first item to be rewarded
+	int reward_item1_repeat_count;    //!< The count of the first item to be rewarded
-	int32_t reward_item2_repeatable;      //!< The second rewarded item
+	int reward_item2_repeatable;      //!< The second rewarded item
-	int32_t reward_item2_repeat_count;    //!< The count of the second item to be rewarded
+	int reward_item2_repeat_count;    //!< The count of the second item to be rewarded
-	int32_t reward_item3_repeatable;      //!< The third rewarded item
+	int reward_item3_repeatable;      //!< The third rewarded item
-	int32_t reward_item3_repeat_count;    //!< The count of the third item to be rewarded
+	int reward_item3_repeat_count;    //!< The count of the third item to be rewarded
-	int32_t reward_item4_repeatable;      //!< The fourth rewarded item
+	int reward_item4_repeatable;      //!< The fourth rewarded item
-	int32_t reward_item4_repeat_count;    //!< The count of the fourth item to be rewarded
+	int reward_item4_repeat_count;    //!< The count of the fourth item to be rewarded
-	int32_t time_limit;                //!< The time limit of the mission
+	int time_limit;                //!< The time limit of the mission
 	bool isMission;                 //!< Maybe to differentiate between missions and achievements?
-	int32_t missionIconID;             //!< The mission icon ID
+	int missionIconID;             //!< The mission icon ID
 	std::string prereqMissionID;       //!< A '|' seperated list of prerequisite missions
 	bool localize;                  //!< Whether or not to localize the mission
 	bool inMOTD;                    //!< In Match of the Day(?)
 	int64_t cooldownTime;              //!< The mission cooldown time
 	bool isRandom;                  //!< ???
 	std::string randomPool;            //!< ???
-	int32_t UIPrereqID;                //!< ???
+	int UIPrereqID;                //!< ???
 	UNUSED(std::string gate_version);          //!< The gate version
 	UNUSED(std::string HUDStates);             //!< ???
-	UNUSED(int32_t locStatus);                 //!< ???
+	UNUSED(int locStatus);                 //!< ???
-	int32_t reward_bankinventory;      //!< The amount of bank space this mission rewards
+	int reward_bankinventory;      //!< The amount of bank space this mission rewards
 };
 
 class CDMissionsTable : public CDTable<CDMissionsTable> {

dDatabase/CDClientDatabase/CDClientTables/CDMovementAIComponentTable.cpp

@@ -3,7 +3,7 @@
 void CDMovementAIComponentTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM MovementAIComponent");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDMovementAIComponentTable.h

@@ -4,7 +4,7 @@
 #include "CDTable.h"
 
 struct CDMovementAIComponent {
-	uint32_t id;
+	unsigned int id;
 	std::string MovementType;
 	float WanderChance;
 	float WanderDelayMin;

dDatabase/CDClientDatabase/CDClientTables/CDObjectSkillsTable.cpp

@@ -3,7 +3,7 @@
 void CDObjectSkillsTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM ObjectSkills");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);

dDatabase/CDClientDatabase/CDClientTables/CDObjectSkillsTable.h

@@ -4,10 +4,10 @@
 #include "CDTable.h"
 
 struct CDObjectSkills {
-	uint32_t objectTemplate;        //!< The LOT of the item
+	unsigned int objectTemplate;        //!< The LOT of the item
-	uint32_t skillID;               //!< The Skill ID of the object
+	unsigned int skillID;               //!< The Skill ID of the object
-	uint32_t castOnType;            //!< ???
+	unsigned int castOnType;            //!< ???
-	uint32_t AICombatWeight;        //!< ???
+	unsigned int AICombatWeight;        //!< ???
 };
 
 class CDObjectSkillsTable : public CDTable<CDObjectSkillsTable> {

dDatabase/CDClientDatabase/CDClientTables/CDObjectsTable.cpp

@@ -2,7 +2,7 @@
 
 void CDObjectsTable::LoadValuesFromDatabase() {
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM Objects");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);
@@ -40,7 +40,7 @@ void CDObjectsTable::LoadValuesFromDatabase() {
 	m_default.id = 0;
 }
 
-const CDObjects& CDObjectsTable::GetByID(uint32_t LOT) {
+const CDObjects& CDObjectsTable::GetByID(unsigned int LOT) {
 	const auto& it = this->entries.find(LOT);
 	if (it != this->entries.end()) {
 		return it->second;

dDatabase/CDClientDatabase/CDClientTables/CDObjectsTable.h

@@ -4,30 +4,30 @@
 #include "CDTable.h"
 
 struct CDObjects {
-	uint32_t id;                            //!< The LOT of the object
+	unsigned int id;                            //!< The LOT of the object
 	std::string name;                      //!< The internal name of the object
-	UNUSED(uint32_t placeable);                     //!< Whether or not the object is placable
+	UNUSED(unsigned int placeable);                     //!< Whether or not the object is placable
 	std::string type;                      //!< The object type
 	UNUSED(std::string description);               //!< An internal description of the object
-	UNUSED(uint32_t localize);                      //!< Whether or not the object should localize
+	UNUSED(unsigned int localize);                      //!< Whether or not the object should localize
-	UNUSED(uint32_t npcTemplateID);                 //!< Something related to NPCs...
+	UNUSED(unsigned int npcTemplateID);                 //!< Something related to NPCs...
 	UNUSED(std::string displayName);               //!< The display name of the object
 	float interactionDistance;          //!< The interaction distance of the object
-	UNUSED(uint32_t nametag);                       //!< ???
+	UNUSED(unsigned int nametag);                       //!< ???
 	UNUSED(std::string _internalNotes);            //!< Some internal notes (rarely used)
-	UNUSED(uint32_t locStatus);                     //!< ???
+	UNUSED(unsigned int locStatus);                     //!< ???
 	UNUSED(std::string gate_version);              //!< The gate version for the object
-	UNUSED(uint32_t HQ_valid);                      //!< Probably used for the Nexus HQ database on LEGOUniverse.com
+	UNUSED(unsigned int HQ_valid);                      //!< Probably used for the Nexus HQ database on LEGOUniverse.com
 };
 
 class CDObjectsTable : public CDTable<CDObjectsTable> {
 private:
-	std::map<uint32_t, CDObjects> entries;
+	std::map<unsigned int, CDObjects> entries;
 	CDObjects m_default;
 
 public:
 	void LoadValuesFromDatabase();
 	// Gets an entry by ID
-	const CDObjects& GetByID(uint32_t LOT);
+	const CDObjects& GetByID(unsigned int LOT);
 };
 

dDatabase/CDClientDatabase/CDClientTables/CDPackageComponentTable.cpp

@@ -3,7 +3,7 @@
 void CDPackageComponentTable::LoadValuesFromDatabase() {
 
 	// First, get the size of the table
-	uint32_t size = 0;
+	unsigned int size = 0;
 	auto tableSize = CDClientDatabase::ExecuteQuery("SELECT COUNT(*) FROM PackageComponent");
 	while (!tableSize.eof()) {
 		size = tableSize.getIntField(0, 0);