From 503c82fcd7d453db9b992b4e10db1898199111f9 Mon Sep 17 00:00:00 2001 From: "aditya.chandel" <8075870+adityachandelgit@users.noreply.github.com> Date: Wed, 10 Dec 2025 13:08:21 -0700 Subject: [PATCH] Fix tests --- .../booklore/service/metadata/BookMetadataUpdater.java | 2 +- .../adityachandel/booklore/service/BookMarkServiceTest.java | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/booklore-api/src/main/java/com/adityachandel/booklore/service/metadata/BookMetadataUpdater.java b/booklore-api/src/main/java/com/adityachandel/booklore/service/metadata/BookMetadataUpdater.java index c5473ede2..8ed686c2d 100644 --- a/booklore-api/src/main/java/com/adityachandel/booklore/service/metadata/BookMetadataUpdater.java +++ b/booklore-api/src/main/java/com/adityachandel/booklore/service/metadata/BookMetadataUpdater.java @@ -81,7 +81,7 @@ public class BookMetadataUpdater { log.info("No changes in metadata for book ID {}. Skipping update.", bookId); return; } - + // If all fields are locked we must allow unlocking, hasValueChanges will be false if (metadata.areAllFieldsLocked() && hasValueChanges) { log.warn("All fields are locked for book ID {}. Skipping update.", bookId); diff --git a/booklore-api/src/test/java/com/adityachandel/booklore/service/BookMarkServiceTest.java b/booklore-api/src/test/java/com/adityachandel/booklore/service/BookMarkServiceTest.java index 4a075ecf2..792c58894 100644 --- a/booklore-api/src/test/java/com/adityachandel/booklore/service/BookMarkServiceTest.java +++ b/booklore-api/src/test/java/com/adityachandel/booklore/service/BookMarkServiceTest.java @@ -81,7 +81,8 @@ class BookMarkServiceTest { CreateBookMarkRequest request = new CreateBookMarkRequest(bookId, "new-cfi", "New Bookmark"); when(authenticationService.getAuthenticatedUser()).thenReturn(userDto); - when(userRepository.getReferenceById(userId)).thenReturn(userEntity); + when(bookMarkRepository.existsByCfiAndBookIdAndUserId("new-cfi", bookId, userId)).thenReturn(false); + when(userRepository.findById(userId)).thenReturn(Optional.of(userEntity)); when(bookRepository.findById(bookId)).thenReturn(Optional.of(bookEntity)); when(bookMarkRepository.save(any(BookMarkEntity.class))).thenReturn(bookmarkEntity); when(mapper.toDto(bookmarkEntity)).thenReturn(bookmarkDto); @@ -98,7 +99,8 @@ class BookMarkServiceTest { CreateBookMarkRequest request = new CreateBookMarkRequest(bookId, "new-cfi", "New Bookmark"); when(authenticationService.getAuthenticatedUser()).thenReturn(userDto); - when(userRepository.getReferenceById(userId)).thenReturn(userEntity); + when(bookMarkRepository.existsByCfiAndBookIdAndUserId("new-cfi", bookId, userId)).thenReturn(false); + when(userRepository.findById(userId)).thenReturn(Optional.of(userEntity)); when(bookRepository.findById(bookId)).thenReturn(Optional.empty()); assertThrows(EntityNotFoundException.class, () -> bookMarkService.createBookmark(request));