mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-02-23 15:38:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

CPack/DragNDrop: Release CoreFoundation objects after they are used

Browse Source 
Otherwise we will be leaking memory.
This commit is contained in:
AZero13
2025-05-26 15:22:15 -04:00
committed by Brad King
parent cfcff29087
commit 07d9e9b5fe
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/CPack/cmCPackDragNDropGenerator.cxx
View File

@@ -597,6 +597,7 @@ int cmCPackDragNDropGenerator::CreateDMG(std::string const& src_dir,
CFStringRef iso_language =
CFLocaleCreateCanonicalLanguageIdentifierFromString(
nullptr, language_cfstring);
CFRelease(language_cfstring);
if (!iso_language) {
cmCPackLogger(cmCPackLog::LOG_ERROR,
language << " is not a recognized language"
@@ -606,6 +607,7 @@ int cmCPackDragNDropGenerator::CreateDMG(std::string const& src_dir,
CFStringGetCString(iso_language, iso_language_cstr,
sizeof(iso_language_cstr) - 1,
kCFStringEncodingMacRoman);
CFRelease(iso_language);
LangCode lang = 0;
RegionCode region = 0;
#if HAVE_CoreServices