From 07d9e9b5fe29de189e778b15e92efb839ece0760 Mon Sep 17 00:00:00 2001 From: AZero13 Date: Mon, 26 May 2025 15:22:15 -0400 Subject: [PATCH] CPack/DragNDrop: Release CoreFoundation objects after they are used Otherwise we will be leaking memory. --- Source/CPack/cmCPackDragNDropGenerator.cxx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Source/CPack/cmCPackDragNDropGenerator.cxx b/Source/CPack/cmCPackDragNDropGenerator.cxx index 1d55274b6c..c673f484cb 100644 --- a/Source/CPack/cmCPackDragNDropGenerator.cxx +++ b/Source/CPack/cmCPackDragNDropGenerator.cxx @@ -597,6 +597,7 @@ int cmCPackDragNDropGenerator::CreateDMG(std::string const& src_dir, CFStringRef iso_language = CFLocaleCreateCanonicalLanguageIdentifierFromString( nullptr, language_cfstring); + CFRelease(language_cfstring); if (!iso_language) { cmCPackLogger(cmCPackLog::LOG_ERROR, language << " is not a recognized language" @@ -606,6 +607,7 @@ int cmCPackDragNDropGenerator::CreateDMG(std::string const& src_dir, CFStringGetCString(iso_language, iso_language_cstr, sizeof(iso_language_cstr) - 1, kCFStringEncodingMacRoman); + CFRelease(iso_language); LangCode lang = 0; RegionCode region = 0; #if HAVE_CoreServices