mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-11 16:32:14 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmMakefile: Use find_if instead of manual loop

Browse Source 
...in the `cmMakefile::ValidateCustomCommand()` as it was a warning
issued by `clang-tidy`.
This commit is contained in:
Alex Turbov
2024-07-06 10:55:02 +04:00
committed by Brad King
parent e0294fa310
commit 0a0a826b86
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Source/cmMakefile.cxx
View File

@@ -1131,15 +1131,17 @@ bool cmMakefile::ValidateCustomCommand(
const cmCustomCommandLines& commandLines) const
{
// TODO: More strict?
for (cmCustomCommandLine const& cl : commandLines) {
if (!cl.empty() && !cl[0].empty() && cl[0][0] == '"') {
this->IssueMessage(
MessageType::FATAL_ERROR,
cmStrCat("COMMAND may not contain literal quotes:\n ", cl[0], '\n'));
return false;
}
const auto it =
std::find_if(commandLines.begin(), commandLines.end(),
[](const cmCustomCommandLine& cl) {
return !cl.empty() && !cl[0].empty() && cl[0][0] == '"';
});
if (it != commandLines.end()) {
this->IssueMessage(
MessageType::FATAL_ERROR,
cmStrCat("COMMAND may not contain literal quotes:\n ", (*it)[0], '\n'));
return false;
}
return true;
}