mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-03-09 10:00:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

cmComputeLinkInformation: Fix out-of-bounds read in error case

Browse Source 
In commit aba1c9d172 (target_link_libraries: Add support for the
LINKER: prefix, 2024-10-06) we added a call to `ResolveLinkerWrapper`.
Update the call site to account for the possibility of an empty result
vector on error.
This commit is contained in:
Brad King
2025-01-20 10:39:25 -05:00
parent 1d5c1b0023
commit 0fbc300bec
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Source/cmComputeLinkInformation.cxx
View File

@@ -1904,11 +1904,14 @@ void cmComputeLinkInformation::AddUserItem(LinkEntry const& entry,
this->Items.emplace_back(item, ItemIsPath::No);
return;
}
if (cmHasPrefix(item.Value, LINKER)) {
std::vector<BT<std::string>> linkerFlag{ 1, item };
this->Target->ResolveLinkerWrapper(linkerFlag, this->GetLinkLanguage(),
true);
this->Items.emplace_back(linkerFlag.front(), ItemIsPath::No);
/* joinItems = */ true);
if (!linkerFlag.empty()) {
this->Items.emplace_back(linkerFlag.front(), ItemIsPath::No);
}
return;
}