mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-03-03 05:08:47 -06:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: Enable performance-inefficient-string-concatenation

Browse Source 
Enables the clang-tidy test performance-inefficient-string-concatenation
and replaces all inefficient string concatenations with `cmStrCat`.

Closes: #19555
This commit is contained in:
Sebastian Holtermann
2019-08-03 13:20:31 +02:00
parent 2327cc0e05
commit 18b0330b86
41 changed files with 150 additions and 155 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/cmFileAPI.cxx
View File

@@ -94,7 +94,7 @@ void cmFileAPI::RemoveOldReplyFiles()
std::vector<std::string> files = this->LoadDir(reply_dir);
for (std::string const& f : files) {
if (this->ReplyFiles.find(f) == this->ReplyFiles.end()) {
std::string file = reply_dir + "/" + f;
std::string file = cmStrCat(reply_dir, "/", f);
cmSystemTools::RemoveFile(file);
}
}