mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-05-03 12:49:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: Enable performance-inefficient-string-concatenation

Browse Source 
Enables the clang-tidy test performance-inefficient-string-concatenation
and replaces all inefficient string concatenations with `cmStrCat`.

Closes: #19555
This commit is contained in:
Sebastian Holtermann
2019-08-03 13:20:31 +02:00
parent 2327cc0e05
commit 18b0330b86
41 changed files with 150 additions and 155 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmTargetIncludeDirectoriesCommand.cxx
+3 -2
View File
@@ -9,6 +9,7 @@
#include "cmListFileCache.h"
#include "cmMakefile.h"
#include "cmMessageType.h"
#include "cmStringAlgorithms.h"
#include "cmSystemTools.h"
#include "cmTarget.h"
@@ -39,9 +40,9 @@ std::string cmTargetIncludeDirectoriesCommand::Join(
for (std::string const& it : content) {
if (cmSystemTools::FileIsFullPath(it) ||
cmGeneratorExpression::Find(it) == 0) {
dirs += sep + it;
dirs += cmStrCat(sep, it);
} else {
dirs += sep + prefix + it;
dirs += cmStrCat(sep, prefix, it);
}
sep = ";";
}