mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-04 21:00:17 -06:00
Code Issues Packages Projects Releases Wiki Activity

strings: Remove cmStdString references

Browse Source 
Casts from std::string -> cmStdString were high on the list of things
taking up time. Avoid such implicit casts across function calls by just
using std::string everywhere.

The comment that the symbol name is too long is no longer relevant since
modern debuggers alias the templates anyways and the size is a
non-issue since the underlying methods are generated since it's
inherited.
This commit is contained in:
Ben Boeckel
2014-02-10 00:21:34 -05:00
committed by Brad King
parent 215b1addf0
commit 270eb96df0
152 changed files with 805 additions and 841 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Source/cmDependsJavaParserHelper.h
View File

@@ -59,15 +59,15 @@ public:
const char* GetCurrentCombine() { return this->CurrentCombine.c_str(); }
void UpdateCombine(const char* str1, const char* str2);
std::vector<cmStdString>& GetClassesFound() { return this->ClassesFound; }
std::vector<std::string>& GetClassesFound() { return this->ClassesFound; }
std::vector<cmStdString> GetFilesProduced();
std::vector<std::string> GetFilesProduced();
private:
class CurrentClass
{
public:
cmStdString Name;
std::string Name;
std::vector<CurrentClass>* NestedClasses;
CurrentClass()
{
@@ -93,16 +93,16 @@ private:
{
(*this) = c;
}
void AddFileNamesForPrinting(std::vector<cmStdString> *files,
void AddFileNamesForPrinting(std::vector<std::string> *files,
const char* prefix, const char* sep);
};
cmStdString CurrentPackage;
cmStdString::size_type InputBufferPos;
cmStdString InputBuffer;
std::string CurrentPackage;
std::string::size_type InputBufferPos;
std::string InputBuffer;
std::vector<char> OutputBuffer;
std::vector<cmStdString> ClassesFound;
std::vector<cmStdString> PackagesImport;
cmStdString CurrentCombine;
std::vector<std::string> ClassesFound;
std::vector<std::string> PackagesImport;
std::string CurrentCombine;
std::vector<CurrentClass> ClassStack;