mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-07 22:30:13 -06:00
Code Issues Packages Projects Releases Wiki Activity

strings: Remove cmStdString references

Browse Source 
Casts from std::string -> cmStdString were high on the list of things
taking up time. Avoid such implicit casts across function calls by just
using std::string everywhere.

The comment that the symbol name is too long is no longer relevant since
modern debuggers alias the templates anyways and the size is a
non-issue since the underlying methods are generated since it's
inherited.
This commit is contained in:
Ben Boeckel
2014-02-10 00:21:34 -05:00
committed by Brad King
parent 215b1addf0
commit 270eb96df0
152 changed files with 805 additions and 841 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Source/cmXCodeObject.h
View File

@@ -30,7 +30,7 @@ public:
PBXCopyFilesBuildPhase,
None
};
class StringVec: public std::vector<cmStdString> {};
class StringVec: public std::vector<std::string> {};
static const char* PBXTypeNames[];
virtual ~cmXCodeObject();
cmXCodeObject(PBXType ptype, Type type);
@@ -131,7 +131,7 @@ public:
}
this->DependLibraries[configName].push_back(l);
}
std::map<cmStdString, StringVec> const& GetDependLibraries()
std::map<std::string, StringVec> const& GetDependLibraries()
{
return this->DependLibraries;
}
@@ -144,27 +144,27 @@ public:
}
this->DependTargets[configName].push_back(tName);
}
std::map<cmStdString, StringVec> const& GetDependTargets()
std::map<std::string, StringVec> const& GetDependTargets()
{
return this->DependTargets;
}
std::vector<cmXCodeObject*> const& GetObjectList() { return this->List;}
void SetComment(const char* c) { this->Comment = c;}
static void PrintString(std::ostream& os,cmStdString String);
static void PrintString(std::ostream& os,std::string String);
protected:
void PrintString(std::ostream& os) const;
cmTarget* Target;
Type TypeValue;
cmStdString Id;
std::string Id;
PBXType IsA;
int Version;
cmStdString Comment;
cmStdString String;
std::string Comment;
std::string String;
cmXCodeObject* Object;
std::vector<cmXCodeObject*> List;
std::map<cmStdString, StringVec> DependLibraries;
std::map<cmStdString, StringVec> DependTargets;
std::map<cmStdString, cmXCodeObject*> ObjectAttributes;
std::map<std::string, StringVec> DependLibraries;
std::map<std::string, StringVec> DependTargets;
std::map<std::string, cmXCodeObject*> ObjectAttributes;
};
#endif