mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-02-28 11:48:36 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmCTestSubmitHandler: Remove unnecessary type alias

Browse Source
This commit is contained in:
Brad King
2025-05-15 08:04:41 -04:00
parent 8f698e1708
commit 2a9cfc2da3
2 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
Source/CTest/cmCTestSubmitHandler.cxx
View File

@@ -32,8 +32,6 @@
#define SUBMIT_TIMEOUT_IN_SECONDS_DEFAULT 120 #define SUBMIT_TIMEOUT_IN_SECONDS_DEFAULT 120
using cmCTestSubmitHandlerVectorOfChar = std::vector<char>;
class cmCTestSubmitHandler::ResponseParser : public cmXMLParser class cmCTestSubmitHandler::ResponseParser : public cmXMLParser
{ {
public: public:
@@ -101,8 +99,7 @@ static size_t cmCTestSubmitHandlerWriteMemoryCallback(void* ptr, size_t size,
{ {
int realsize = static_cast<int>(size * nmemb); int realsize = static_cast<int>(size * nmemb);
char const* chPtr = static_cast<char*>(ptr); char const* chPtr = static_cast<char*>(ptr);
cm::append(*static_cast<cmCTestSubmitHandlerVectorOfChar*>(data), chPtr, cm::append(*static_cast<std::vector<char>*>(data), chPtr, chPtr + realsize);
chPtr + realsize);
return realsize; return realsize;
} }
@@ -111,8 +108,7 @@ static size_t cmCTestSubmitHandlerCurlDebugCallback(CURL* /*unused*/,
char* chPtr, size_t size, char* chPtr, size_t size,
void* data) void* data)
{ {
cm::append(*static_cast<cmCTestSubmitHandlerVectorOfChar*>(data), chPtr, cm::append(*static_cast<std::vector<char>*>(data), chPtr, chPtr + size);
chPtr + size);
return 0; return 0;
} }
@@ -321,8 +317,8 @@ bool cmCTestSubmitHandler::SubmitUsingHTTP(
cmCTestSubmitHandlerCurlDebugCallback); cmCTestSubmitHandlerCurlDebugCallback);
/* we pass our 'chunk' struct to the callback function */ /* we pass our 'chunk' struct to the callback function */
cmCTestSubmitHandlerVectorOfChar chunk; std::vector<char> chunk;
cmCTestSubmitHandlerVectorOfChar chunkDebug; std::vector<char> chunkDebug;
::curl_easy_setopt(curl, CURLOPT_FILE, &chunk); ::curl_easy_setopt(curl, CURLOPT_FILE, &chunk);
::curl_easy_setopt(curl, CURLOPT_DEBUGDATA, &chunkDebug); ::curl_easy_setopt(curl, CURLOPT_DEBUGDATA, &chunkDebug);
@@ -447,8 +443,7 @@ bool cmCTestSubmitHandler::SubmitUsingHTTP(
return true; return true;
} }
void cmCTestSubmitHandler::ParseResponse( void cmCTestSubmitHandler::ParseResponse(std::vector<char> chunk)
cmCTestSubmitHandlerVectorOfChar chunk)
{ {
std::string output; std::string output;
output.append(chunk.begin(), chunk.end()); output.append(chunk.begin(), chunk.end());

5
Source/CTest/cmCTestSubmitHandler.h
View File

@@ -53,10 +53,7 @@ private:
std::vector<std::string> const& files, std::vector<std::string> const& files,
std::string const& remoteprefix, std::string const& remoteprefix,
std::string const& url); std::string const& url);
void ParseResponse(std::vector<char> chunk);
using cmCTestSubmitHandlerVectorOfChar = std::vector<char>;
void ParseResponse(cmCTestSubmitHandlerVectorOfChar chunk);
std::string GetSubmitResultsPrefix(); std::string GetSubmitResultsPrefix();
int GetSubmitInactivityTimeout(); int GetSubmitInactivityTimeout();