mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-11 16:32:14 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmAlgorithms: Make cmHasPrefix and cmHasSuffix cm::string_view based

Browse Source 
Make `cmHasPrefix`, `cmHasSuffix` and `cmStripSuffixIfExists` accept
arguments as `cm::string_view` instead of `const std::string&`.
This lets them accept literal strings without having to allocate a temporary
`std::string`.
Add variants of `cmHasPrefix`, `cmHasSuffix` and `cmStripSuffixIfExists` that
accept a single character as second argument.
This commit is contained in:
Sebastian Holtermann
2019-07-20 11:17:12 +02:00
parent 4cd039b78a
commit 301f5356fd
1 changed files with 29 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
Source/cmAlgorithms.h
View File

@@ -8,6 +8,7 @@
#include "cmRange.h"
#include "cm_kwiml.h"
#include "cm_string_view.hxx"
#include <algorithm>
#include <functional>
#include <iterator>
@@ -314,23 +315,41 @@ std::reverse_iterator<Iter> cmMakeReverseIterator(Iter it)
return std::reverse_iterator<Iter>(it);
}
inline bool cmHasPrefix(std::string const& str, std::string const& prefix)
/** Returns true if string @a str starts with the character @a prefix. **/
inline bool cmHasPrefix(cm::string_view str, char prefix)
{
return !str.empty() && (str.front() == prefix);
}
/** Returns true if string @a str starts with string @a prefix. **/
inline bool cmHasPrefix(cm::string_view str, cm::string_view prefix)
{
if (str.size() < prefix.size()) {
return false;
}
return str.compare(0, prefix.size(), prefix) == 0;
}
inline bool cmHasSuffix(const std::string& str, const std::string& suffix)
/** Returns true if string @a str ends with the character @a suffix. **/
inline bool cmHasSuffix(cm::string_view str, char suffix)
{
if (str.size() < suffix.size()) {
return false;
}
return str.compare(str.size() - suffix.size(), suffix.size(), suffix) == 0;
return !str.empty() && (str.back() == suffix);
}
inline void cmStripSuffixIfExists(std::string& str, const std::string& suffix)
/** Returns true if string @a str ends with string @a suffix. **/
inline bool cmHasSuffix(cm::string_view str, cm::string_view suffix)
{
return str.size() >= suffix.size() &&
str.compare(str.size() - suffix.size(), suffix.size(), suffix) == 0;
}
/** Removes an existing suffix character of from the string @a str. **/
inline void cmStripSuffixIfExists(std::string& str, char suffix)
{
if (cmHasSuffix(str, suffix)) {
str.pop_back();
}
}
/** Removes an existing suffix string of from the string @a str. **/
inline void cmStripSuffixIfExists(std::string& str, cm::string_view suffix)
{
if (cmHasSuffix(str, suffix)) {
str.resize(str.size() - suffix.size());