mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-11 08:20:18 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmFileTimeComparison: Replace anonymous private class with std::map

Browse Source 
After the switch to `cmFileTime`, the anonymous private class of
`cmFileTimeComparison` held only a `std::map`.  This moves the
`std::map` to the `cmFileTimeComparison` class itself and removes the
instantiation of an anonymous private class.
This commit is contained in:
Sebastian Holtermann
2019-03-13 19:03:35 +01:00
parent 103aa9e46a
commit 3160258393
2 changed files with 23 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

77
Source/cmFileTimeComparison.cxx
View File

@@ -6,71 +6,32 @@
#include <unordered_map>
#include <utility>
class cmFileTimeComparisonInternal
{
public:
inline bool Load(std::string const& fname, cmFileTime& ftm);
inline bool FileTimeCompare(std::string const& f1, std::string const& f2,
int* result);
cmFileTimeComparison::cmFileTimeComparison() = default;
bool FileTimesDiffer(std::string const& f1, std::string const& f2);
private:
typedef std::unordered_map<std::string, cmFileTime> FileStatsMap;
FileStatsMap Files;
};
bool cmFileTimeComparisonInternal::Load(std::string const& fname,
cmFileTime& ftm)
{
// Use the stored time if available.
{
auto fit = this->Files.find(fname);
if (fit != this->Files.end()) {
ftm = fit->second;
return true;
}
}
// Read file time from OS
if (!ftm.Load(fname)) {
return false;
}
// Store file time in cache
this->Files[fname] = ftm;
return true;
}
cmFileTimeComparison::cmFileTimeComparison()
{
this->Internals = new cmFileTimeComparisonInternal;
}
cmFileTimeComparison::~cmFileTimeComparison()
{
delete this->Internals;
}
cmFileTimeComparison::~cmFileTimeComparison() = default;
bool cmFileTimeComparison::Load(std::string const& fileName,
cmFileTime& fileTime)
{
return this->Internals->Load(fileName, fileTime);
// Use the stored time if available.
{
auto fit = this->FileTimes.find(fileName);
if (fit != this->FileTimes.end()) {
fileTime = fit->second;
return true;
}
}
// Read file time from OS
if (!fileTime.Load(fileName)) {
return false;
}
// Store file time in cache
this->FileTimes[fileName] = fileTime;
return true;
}
bool cmFileTimeComparison::FileTimeCompare(std::string const& f1,
std::string const& f2, int* result)
{
return this->Internals->FileTimeCompare(f1, f2, result);
}
bool cmFileTimeComparison::FileTimesDiffer(std::string const& f1,
std::string const& f2)
{
return this->Internals->FileTimesDiffer(f1, f2);
}
bool cmFileTimeComparisonInternal::FileTimeCompare(std::string const& f1,
std::string const& f2,
int* result)
{
// Get the modification time for each file.
cmFileTime ft1, ft2;
@@ -84,8 +45,8 @@ bool cmFileTimeComparisonInternal::FileTimeCompare(std::string const& f1,
return false;
}
bool cmFileTimeComparisonInternal::FileTimesDiffer(std::string const& f1,
std::string const& f2)
bool cmFileTimeComparison::FileTimesDiffer(std::string const& f1,
std::string const& f2)
{
// Get the modification time for each file.
cmFileTime ft1, ft2;

8
Source/cmFileTimeComparison.h
View File

@@ -7,8 +7,7 @@
#include "cmFileTime.h"
#include <string>
class cmFileTimeComparisonInternal;
#include <unordered_map>
/** \class cmFileTimeComparison
* \brief Caches file modification times in an internal map for fast lookups.
@@ -45,8 +44,9 @@ public:
*/
bool FileTimesDiffer(std::string const& f1, std::string const& f2);
protected:
cmFileTimeComparisonInternal* Internals;
private:
typedef std::unordered_map<std::string, cmFileTime> FileTimeMap;
FileTimeMap FileTimes;
};
#endif