Merge topic 'simplify-sources-check'

634c461b22 cmGlobalGenerator: Simplify CheckTargetsForMissingSources

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !5043
This commit is contained in:
Brad King
2020-07-23 12:25:47 +00:00
committed by Kitware Robot

View File

@@ -309,17 +309,7 @@ bool cmGlobalGenerator::CheckTargetsForMissingSources() const
continue;
}
std::vector<std::string> configs =
target->Makefile->GetGeneratorConfigs(cmMakefile::IncludeEmptyConfig);
std::vector<cmSourceFile*> srcs;
for (std::string const& config : configs) {
target->GetSourceFiles(srcs, config);
if (!srcs.empty()) {
break;
}
}
if (srcs.empty()) {
if (target->GetAllConfigSources().empty()) {
std::ostringstream e;
e << "No SOURCES given to target: " << target->GetName();
this->GetCMakeInstance()->IssueMessage(