mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-05 21:31:08 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmStringAlgorithms: Add faster cmJoin overloads for strings

Browse Source 
cmJoin() is often used with std::string ranges. Generic implementation
uses std::ostringstream which is not optimal. With strings we can avoid
operator<<() and make much faster implementation. Additional 'initial'
argument is useful for cmStringCommand.cxx:HandleAppendCommand().
This commit is contained in:
Oleksandr Koval
2020-09-03 23:25:37 +03:00
parent ca5babfd7a
commit 38928ee3ee
3 changed files with 69 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Source/cmStringCommand.cxx
View File

@@ -11,6 +11,7 @@
#include <memory>
#include <cm/iterator>
#include <cm/string_view>
#include <cmext/string_view>
#include "cmsys/RegularExpression.hxx"
@@ -534,11 +535,14 @@ bool HandleAppendCommand(std::vector<std::string> const& args,
return true;
}
const std::string& variable = args[1];
auto const& variableName = args[1];
cm::string_view oldView{ status.GetMakefile().GetSafeDefinition(
variableName) };
auto const newValue = cmJoin(cmMakeRange(args).advance(2), {}, oldView);
status.GetMakefile().AddDefinition(variableName, newValue);
std::string value = status.GetMakefile().GetSafeDefinition(variable);
value += cmJoin(cmMakeRange(args).advance(2), std::string());
status.GetMakefile().AddDefinition(variable, value);
return true;
}