From 3a089cd2560db80f9534b9c86a0a7af495533466 Mon Sep 17 00:00:00 2001 From: Raul Tambre Date: Sat, 22 Jan 2022 17:40:10 +0200 Subject: [PATCH] CMP0128: Prefix test names with mode Makes clear that these tests are for the NEW behaviour. --- ...NewExtensionsStandardDefault-build-check.cmake} | 0 ...e => CMP0128NewExtensionsStandardDefault.cmake} | 0 ...28NewExtensionsStandardUnset-build-check.cmake} | 0 ...ake => CMP0128NewExtensionsStandardUnset.cmake} | 0 ... CMP0128NewNoUnnecessaryFlag-build-check.cmake} | 0 ...lag.cmake => CMP0128NewNoUnnecessaryFlag.cmake} | 0 Tests/RunCMake/CompileFeatures/RunCMakeTest.cmake | 14 +++++++------- 7 files changed, 7 insertions(+), 7 deletions(-) rename Tests/RunCMake/CompileFeatures/{ExtensionsStandardDefault-build-check.cmake => CMP0128NewExtensionsStandardDefault-build-check.cmake} (100%) rename Tests/RunCMake/CompileFeatures/{ExtensionsStandardDefault.cmake => CMP0128NewExtensionsStandardDefault.cmake} (100%) rename Tests/RunCMake/CompileFeatures/{ExtensionsStandardUnset-build-check.cmake => CMP0128NewExtensionsStandardUnset-build-check.cmake} (100%) rename Tests/RunCMake/CompileFeatures/{ExtensionsStandardUnset.cmake => CMP0128NewExtensionsStandardUnset.cmake} (100%) rename Tests/RunCMake/CompileFeatures/{NoUnnecessaryFlag-build-check.cmake => CMP0128NewNoUnnecessaryFlag-build-check.cmake} (100%) rename Tests/RunCMake/CompileFeatures/{NoUnnecessaryFlag.cmake => CMP0128NewNoUnnecessaryFlag.cmake} (100%) diff --git a/Tests/RunCMake/CompileFeatures/ExtensionsStandardDefault-build-check.cmake b/Tests/RunCMake/CompileFeatures/CMP0128NewExtensionsStandardDefault-build-check.cmake similarity index 100% rename from Tests/RunCMake/CompileFeatures/ExtensionsStandardDefault-build-check.cmake rename to Tests/RunCMake/CompileFeatures/CMP0128NewExtensionsStandardDefault-build-check.cmake diff --git a/Tests/RunCMake/CompileFeatures/ExtensionsStandardDefault.cmake b/Tests/RunCMake/CompileFeatures/CMP0128NewExtensionsStandardDefault.cmake similarity index 100% rename from Tests/RunCMake/CompileFeatures/ExtensionsStandardDefault.cmake rename to Tests/RunCMake/CompileFeatures/CMP0128NewExtensionsStandardDefault.cmake diff --git a/Tests/RunCMake/CompileFeatures/ExtensionsStandardUnset-build-check.cmake b/Tests/RunCMake/CompileFeatures/CMP0128NewExtensionsStandardUnset-build-check.cmake similarity index 100% rename from Tests/RunCMake/CompileFeatures/ExtensionsStandardUnset-build-check.cmake rename to Tests/RunCMake/CompileFeatures/CMP0128NewExtensionsStandardUnset-build-check.cmake diff --git a/Tests/RunCMake/CompileFeatures/ExtensionsStandardUnset.cmake b/Tests/RunCMake/CompileFeatures/CMP0128NewExtensionsStandardUnset.cmake similarity index 100% rename from Tests/RunCMake/CompileFeatures/ExtensionsStandardUnset.cmake rename to Tests/RunCMake/CompileFeatures/CMP0128NewExtensionsStandardUnset.cmake diff --git a/Tests/RunCMake/CompileFeatures/NoUnnecessaryFlag-build-check.cmake b/Tests/RunCMake/CompileFeatures/CMP0128NewNoUnnecessaryFlag-build-check.cmake similarity index 100% rename from Tests/RunCMake/CompileFeatures/NoUnnecessaryFlag-build-check.cmake rename to Tests/RunCMake/CompileFeatures/CMP0128NewNoUnnecessaryFlag-build-check.cmake diff --git a/Tests/RunCMake/CompileFeatures/NoUnnecessaryFlag.cmake b/Tests/RunCMake/CompileFeatures/CMP0128NewNoUnnecessaryFlag.cmake similarity index 100% rename from Tests/RunCMake/CompileFeatures/NoUnnecessaryFlag.cmake rename to Tests/RunCMake/CompileFeatures/CMP0128NewNoUnnecessaryFlag.cmake diff --git a/Tests/RunCMake/CompileFeatures/RunCMakeTest.cmake b/Tests/RunCMake/CompileFeatures/RunCMakeTest.cmake index ebd981b3d5..fc2fa06f29 100644 --- a/Tests/RunCMake/CompileFeatures/RunCMakeTest.cmake +++ b/Tests/RunCMake/CompileFeatures/RunCMakeTest.cmake @@ -68,7 +68,7 @@ macro(mangle_flags variable) list(APPEND flags "${result}") endmacro() -function(test_extensions_opposite) +function(test_cmp0128_new_extensions_opposite) if(extensions_opposite) set(flag_ext "_EXT") endif() @@ -83,16 +83,16 @@ function(test_extensions_opposite) # Make sure we enable/disable extensions when: # 1. LANG_STANDARD is unset. - set(name ExtensionsStandardUnset) + set(name CMP0128NewExtensionsStandardUnset) set(RunCMake_TEST_OPTIONS -DCMAKE_POLICY_DEFAULT_CMP0128=NEW) test_build(--verbose) # 2. LANG_STANDARD matches CMAKE_LANG_STANDARD_DEFAULT. - set(name ExtensionsStandardDefault) + set(name CMP0128NewExtensionsStandardDefault) test_build(--verbose) endfunction() -function(test_no_unnecessary_flag) +function(test_cmp0128_new_no_unnecessary_flag) set(standard_flag "${${lang}${${lang}_STANDARD_DEFAULT}_FLAG}") set(extension_flag "${${lang}${${lang}_STANDARD_DEFAULT}_EXT_FLAG}") @@ -103,7 +103,7 @@ function(test_no_unnecessary_flag) mangle_flags(standard_flag) mangle_flags(extension_flag) - set(name NoUnnecessaryFlag) + set(name CMP0128NewNoUnnecessaryFlag) set(RunCMake_TEST_OPTIONS -DCMAKE_POLICY_DEFAULT_CMP0128=NEW) test_build(--verbose) endfunction() @@ -144,8 +144,8 @@ function(test_lang lang ext) set(extensions_opposite ON) endif() - test_extensions_opposite() - test_no_unnecessary_flag() + test_cmp0128_new_extensions_opposite() + test_cmp0128_new_no_unnecessary_flag() test_cmp0128_warn_match() test_cmp0128_warn_unset() endfunction()