From 3d0ac2daface107f2edb1e0e4636d3960b6e856d Mon Sep 17 00:00:00 2001 From: Brad King Date: Tue, 22 Apr 2025 17:12:54 -0400 Subject: [PATCH] clang-tidy: fix bugprone-unhandled-self-assignment lint --- Source/cmSourceGroup.cxx | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Source/cmSourceGroup.cxx b/Source/cmSourceGroup.cxx index 3a3ca595b3..4a7f8e2e91 100644 --- a/Source/cmSourceGroup.cxx +++ b/Source/cmSourceGroup.cxx @@ -40,11 +40,13 @@ cmSourceGroup::cmSourceGroup(cmSourceGroup const& r) cmSourceGroup& cmSourceGroup::operator=(cmSourceGroup const& r) { - this->Name = r.Name; - this->GroupRegex = r.GroupRegex; - this->GroupFiles = r.GroupFiles; - this->SourceFiles = r.SourceFiles; - *(this->Internal) = *(r.Internal); + if (this != &r) { + this->Name = r.Name; + this->GroupRegex = r.GroupRegex; + this->GroupFiles = r.GroupFiles; + this->SourceFiles = r.SourceFiles; + *(this->Internal) = *(r.Internal); + } return *this; }