mirror of
https://github.com/Kitware/CMake.git
synced 2026-01-25 16:09:42 -06:00
file: Avoid runaway DOWNLOAD/UPLOAD progress reports (#14807)
Curl makes progress callbacks frequently but we round to the nearest percent and report only when that changes so that we make at most 101 progress reports. However, when unexpected data beyond the total are transferred the progress can get beyond 100% and lead to unlimited reports. Avoid this case by capping the reported progress to 100%.
This commit is contained in:
@@ -2539,6 +2539,11 @@ namespace {
|
||||
if (total > 0.0)
|
||||
{
|
||||
this->CurrentPercentage = static_cast<int>(value/total*100.0 + 0.5);
|
||||
if(this->CurrentPercentage > 100)
|
||||
{
|
||||
// Avoid extra progress reports for unexpected data beyond total.
|
||||
this->CurrentPercentage = 100;
|
||||
}
|
||||
}
|
||||
|
||||
bool updated = (OldPercentage != this->CurrentPercentage);
|
||||
|
||||
Reference in New Issue
Block a user