mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-06 05:40:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

Debugger: Add Value Formatting support for StackTrace request

Browse Source 
Add support for the "format" property of the Debug Adapter Protocol
StackTrace request to fulfill the host's request to format the resulting
StackFrame name differently.
This commit is contained in:
Jonathan Phippen
2024-10-23 21:19:41 -07:00
parent 4b08b10900
commit 41621c3afb
9 changed files with 104 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
Source/cmDebuggerThread.cxx
View File

@@ -14,6 +14,7 @@
#include "cmDebuggerVariablesHelper.h"
#include "cmDebuggerVariablesManager.h"
#include "cmListFileCache.h"
#include "cmStringAlgorithms.h"
namespace cmDebugger {
@@ -117,8 +118,27 @@ dap::VariablesResponse cmDebuggerThread::GetVariablesResponse(
}
dap::StackTraceResponse GetStackTraceResponse(
std::shared_ptr<cmDebuggerThread> const& thread)
std::shared_ptr<cmDebuggerThread> const& thread,
dap::optional<dap::StackFrameFormat> format)
{
dap::boolean showParameters = false;
dap::boolean showParameterValues = false;
dap::boolean showLine = false;
if (format.has_value()) {
auto formatValue = format.value();
if (formatValue.parameters.has_value()) {
showParameters = formatValue.parameters.value();
}
if (formatValue.parameterValues.has_value()) {
showParameterValues = formatValue.parameterValues.value();
}
if (formatValue.line.has_value()) {
showLine = formatValue.line.value();
}
}
dap::StackTraceResponse response;
std::unique_lock<std::mutex> lock(thread->Mutex);
for (int i = static_cast<int>(thread->Frames.size()) - 1; i >= 0; --i) {
@@ -136,10 +156,29 @@ dap::StackTraceResponse GetStackTraceResponse(
#endif
stackFrame.line = thread->Frames[i]->GetLine();
stackFrame.column = 1;
stackFrame.name = thread->Frames[i]->GetFunction().OriginalName();
stackFrame.id = thread->Frames[i]->GetId();
stackFrame.source = source;
auto stackName = thread->Frames[i]->GetFunction().OriginalName();
if (showParameters) {
stackName.push_back('(');
if (showParameterValues && !thread->Frames[i]->GetArguments().empty()) {
for (auto const& arg : thread->Frames[i]->GetArguments()) {
stackName = cmStrCat(stackName, arg.Value, ", ");
}
stackName.erase(stackName.end() - 2, stackName.end());
}
stackName.push_back(')');
}
if (showLine) {
stackName =
cmStrCat(stackName, " Line: ", static_cast<int64_t>(stackFrame.line));
}
stackFrame.name = stackName;
response.stackFrames.push_back(stackFrame);
}