mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-22 06:31:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

Ninja: Do not use module definition .def files for static libraries

Browse Source 
A module definition (`.def`) file specifies symbols to export from
a linked binary.  The librarian tool is not a linker and so should
not be given a `/DEF:...` flag with the `.def` file.  The other
generators already do not do this, so fix Ninja to be consistent.

Closes: #16537
This commit is contained in:
Brad King
2017-01-11 15:56:21 -05:00
parent 728820f3ea
commit 47ffa0ea5d
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Source/cmCommonTargetGenerator.cxx
View File

@@ -63,6 +63,13 @@ void cmCommonTargetGenerator::AddFeatureFlags(std::string& flags,
void cmCommonTargetGenerator::AddModuleDefinitionFlag( void cmCommonTargetGenerator::AddModuleDefinitionFlag(
cmLinkLineComputer* linkLineComputer, std::string& flags) cmLinkLineComputer* linkLineComputer, std::string& flags)
{ {
// A module definition file only makes sense on certain target types.
if (this->GeneratorTarget->GetType() != cmStateEnums::SHARED_LIBRARY &&
this->GeneratorTarget->GetType() != cmStateEnums::MODULE_LIBRARY &&
this->GeneratorTarget->GetType() != cmStateEnums::EXECUTABLE) {
return;
}
if (!this->ModuleDefinitionFile) { if (!this->ModuleDefinitionFile) {
return; return;
} }