mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-12-31 10:50:16 -06:00
Code Issues Packages Projects Releases Wiki Activity

Windows: Prefer junctions for directory symlinks

Browse Source 
Update the approach added by commit afb7f6e4ff (cmake: Add '-E
create_symlink' support on Windows, 2018-06-11, v3.13.0-rc1~75^2) to use
junctions, as suggested [here](https://superuser.com/a/1291446/140450).
This allows them to work under security limitations on Windows.

Fixes: #23257
This commit is contained in:
Sergei Kryvonos
2022-02-22 18:37:30 +02:00
committed by Brad King
parent 82b8bd4ef9
commit 5101d586c4
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Source/cmSystemTools.cxx
View File

@@ -3314,12 +3314,22 @@ cmsys::Status cmSystemTools::CreateSymlink(std::string const& origName,
uv_fs_t req;
int flags = 0;
#if defined(_WIN32)
if (cmsys::SystemTools::FileIsDirectory(origName)) {
flags |= UV_FS_SYMLINK_DIR;
bool const isDir = cmsys::SystemTools::FileIsDirectory(origName);
if (isDir) {
flags |= UV_FS_SYMLINK_JUNCTION;
}
#endif
int err = uv_fs_symlink(nullptr, &req, origName.c_str(), newName.c_str(),
flags, nullptr);
#if defined(_WIN32)
if (err && uv_fs_get_system_error(&req) == ERROR_NOT_SUPPORTED && isDir) {
// Try fallback to symlink for network (requires additional permissions).
flags ^= UV_FS_SYMLINK_JUNCTION | UV_FS_SYMLINK_DIR;
err = uv_fs_symlink(nullptr, &req, origName.c_str(), newName.c_str(),
flags, nullptr);
}
#endif
cmsys::Status status;
if (err) {
#if defined(_WIN32)