From d197474083bb97b65c773dbcf765aa2b7a939de5 Mon Sep 17 00:00:00 2001 From: Matthew Woehlke Date: Tue, 4 Nov 2025 12:43:16 -0500 Subject: [PATCH 1/2] codespell: Ignore test output regexes Ignore RunCMake output regexes (i.e. *-stdout.txt, *-stderr.txt) when checking spelling. Because these are regular expressions, they have a higher likelihood of having false positives, and because they are expected output, any text they contain ought to also appear in whatever code generates it (or else, is probably text that depends on user input and shouldn't be spell-checked anyway). --- .codespellrc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.codespellrc b/.codespellrc index 383e9ce243..1b00317a8e 100644 --- a/.codespellrc +++ b/.codespellrc @@ -20,6 +20,8 @@ skip = Tests/StringFileTest/test.utf8, Utilities/cm*, *.pfx, + *-stdout.txt, + *-stderr.txt # noqa: spellcheck off ignore-words-list = From 7cc114601a134a8a2c17f5da5e436cbdabb06d6d Mon Sep 17 00:00:00 2001 From: Matthew Woehlke Date: Tue, 4 Nov 2025 12:45:30 -0500 Subject: [PATCH 2/2] codespell: Prune ignore list Remove entries from the codespell ignore list that do not seem to be present any more. Also, remove a deliberate typo and instead add a local annotation to ignore it. This list is still uncomfortably long, but unfortunately current versions of codespell do not offer any granularity in between annotating individual uses (which is not practical in most cases) or globally ignoring words (which is overly broad and risks missing real errors). --- .codespellrc | 6 ------ Tests/RunCMake/VisibilityPreset/PropertyTypo.cmake | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/.codespellrc b/.codespellrc index 1b00317a8e..1149f41e04 100644 --- a/.codespellrc +++ b/.codespellrc @@ -26,11 +26,9 @@ skip = # noqa: spellcheck off ignore-words-list = abd, - aci, ags, ake, ans, - ba, ccompiler, cconfiguration, certi, @@ -44,9 +42,6 @@ ignore-words-list = filetest, fo, helpfull, - hiden, - isnt, - keypair, nd, ned, nin, @@ -57,7 +52,6 @@ ignore-words-list = seh, ser, te, - upto, varn, vas, wee, diff --git a/Tests/RunCMake/VisibilityPreset/PropertyTypo.cmake b/Tests/RunCMake/VisibilityPreset/PropertyTypo.cmake index c6e9dd9436..6f93c2587d 100644 --- a/Tests/RunCMake/VisibilityPreset/PropertyTypo.cmake +++ b/Tests/RunCMake/VisibilityPreset/PropertyTypo.cmake @@ -5,4 +5,4 @@ set(CMAKE_CXX_COMPILE_OPTIONS_VISIBILITY_INLINES_HIDDEN "-fvisibility-inlines-hi set(CMAKE_CXX_COMPILE_OPTIONS_VISIBILITY "-fvisibility=") add_library(visibility_preset SHARED lib.cpp) -set_property(TARGET visibility_preset PROPERTY CXX_VISIBILITY_PRESET hiden) +set_property(TARGET visibility_preset PROPERTY CXX_VISIBILITY_PRESET hiden) # codespell:ignore hiden