mirror of
https://github.com/Kitware/CMake.git
synced 2026-01-08 23:00:07 -06:00
use cmSystemTools::MoveFileIfDifferent()
This is better than doing CopyFileIfDifferent() followed by RemoveFile() in two ways: - it is more efficient, as it avoids disk I/O for the data, even if the files here are usually small - it is atomic, so an abort during the copy will not leave a destination file with partial data behind
This commit is contained in:
@@ -3417,8 +3417,7 @@ std::string cmGeneratorTarget::GetPchHeader(const std::string& config,
|
||||
file << pchEpilogue << "\n";
|
||||
}
|
||||
}
|
||||
cmSystemTools::CopyFileIfDifferent(filename_tmp, filename);
|
||||
cmSystemTools::RemoveFile(filename_tmp);
|
||||
cmSystemTools::MoveFileIfDifferent(filename_tmp, filename);
|
||||
}
|
||||
return inserted.first->second;
|
||||
}
|
||||
@@ -3451,8 +3450,7 @@ std::string cmGeneratorTarget::GetPchSource(const std::string& config,
|
||||
cmGeneratedFileStream file(filename_tmp);
|
||||
file << "/* generated by CMake */\n";
|
||||
}
|
||||
cmSystemTools::CopyFileIfDifferent(filename_tmp, filename);
|
||||
cmSystemTools::RemoveFile(filename_tmp);
|
||||
cmSystemTools::MoveFileIfDifferent(filename_tmp, filename);
|
||||
}
|
||||
return inserted.first->second;
|
||||
}
|
||||
|
||||
@@ -2275,8 +2275,7 @@ void cmLocalGenerator::AddUnityBuild(cmGeneratorTarget* target,
|
||||
}
|
||||
}
|
||||
}
|
||||
cmSystemTools::CopyFileIfDifferent(filename_tmp, filename);
|
||||
cmSystemTools::RemoveFile(filename_tmp);
|
||||
cmSystemTools::MoveFileIfDifferent(filename_tmp, filename);
|
||||
|
||||
target->AddSource(filename, true);
|
||||
|
||||
|
||||
@@ -98,7 +98,6 @@ void CopyAndFullPathMesaHeader(const std::string& source,
|
||||
// close the files before attempting to copy
|
||||
fin.close();
|
||||
fout.close();
|
||||
cmSystemTools::CopyFileIfDifferent(tempOutputFile, outFile);
|
||||
cmSystemTools::RemoveFile(tempOutputFile);
|
||||
cmSystemTools::MoveFileIfDifferent(tempOutputFile, outFile);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user