mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-05 13:20:47 -06:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy module: allow header files in test cases

Browse Source
This commit is contained in:
Kyle Edwards
2022-10-31 13:56:06 -04:00
parent c5a945dce8
commit 68a4d97da7
1 changed files with 42 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
Utilities/ClangTidyModule/Tests/RunClangTidy.cmake
View File

@@ -13,12 +13,22 @@ endif()
set(source_file "${RunClangTidy_BINARY_DIR}/${CHECK_NAME}.cxx") set(source_file "${RunClangTidy_BINARY_DIR}/${CHECK_NAME}.cxx")
configure_file("${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}.cxx" "${source_file}" COPYONLY) configure_file("${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}.cxx" "${source_file}" COPYONLY)
file(GLOB header_files RELATIVE "${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}" "${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}/*")
file(REMOVE_RECURSE "${RunClangTiy_BINARY_DIR}/${CHECK_NAME}")
foreach(header_file IN LISTS header_files)
if(NOT header_file MATCHES "-fixit\\.h\$")
file(MAKE_DIRECTORY "${RunClangTidy_BINARY_DIR}/${CHECK_NAME}")
configure_file("${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}/${header_file}" "${RunClangTidy_BINARY_DIR}/${CHECK_NAME}/${header_file}" COPYONLY)
endif()
endforeach()
set(command set(command
"${CLANG_TIDY_COMMAND}" "${CLANG_TIDY_COMMAND}"
"--load=${CLANG_TIDY_MODULE}" "--load=${CLANG_TIDY_MODULE}"
"--checks=-*,${CHECK_NAME}" "--checks=-*,${CHECK_NAME}"
"--fix" "--fix"
"--format-style=file" "--format-style=file"
"--header-filter=/${CHECK_NAME}/"
${config_arg} ${config_arg}
"${source_file}" "${source_file}"
-- --
@@ -44,18 +54,38 @@ if(NOT actual_stdout STREQUAL expect_stdout)
string(APPEND RunClangTidy_TEST_FAILED "Expected stdout:\n${expect_stdout_formatted}\nActual stdout:\n${actual_stdout_formatted}\n") string(APPEND RunClangTidy_TEST_FAILED "Expected stdout:\n${expect_stdout_formatted}\nActual stdout:\n${actual_stdout_formatted}\n")
endif() endif()
if(EXISTS "${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}-fixit.cxx") function(check_fixit expected fallback_expected actual)
set(expect_fixit_file "${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}-fixit.cxx") if(EXISTS "${expected}")
else() set(expect_fixit_file "${expected}")
set(expect_fixit_file "${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}.cxx") else()
endif() set(expect_fixit_file "${fallback_expected}")
file(READ "${expect_fixit_file}" expect_fixit) endif()
file(READ "${source_file}" actual_fixit) file(READ "${expect_fixit_file}" expect_fixit)
if(NOT expect_fixit STREQUAL actual_fixit) file(READ "${actual}" actual_fixit)
string(REPLACE "\n" "\n " expect_fixit_formatted " ${expect_fixit}") if(NOT expect_fixit STREQUAL actual_fixit)
string(REPLACE "\n" "\n " actual_fixit_formatted " ${actual_fixit}") string(REPLACE "\n" "\n " expect_fixit_formatted " ${expect_fixit}")
string(APPEND RunClangTidy_TEST_FAILED "Expected fixit:\n${expect_fixit_formatted}\nActual fixit:\n${actual_fixit_formatted}\n") string(REPLACE "\n" "\n " actual_fixit_formatted " ${actual_fixit}")
endif() string(APPEND RunClangTidy_TEST_FAILED "Expected fixit for ${actual}:\n${expect_fixit_formatted}\nActual fixit:\n${actual_fixit_formatted}\n")
set(RunClangTidy_TEST_FAILED "${RunClangTidy_TEST_FAILED}" PARENT_SCOPE)
endif()
endfunction()
check_fixit(
"${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}-fixit.cxx"
"${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}.cxx"
"${source_file}"
)
foreach(header_file IN LISTS header_files)
if(NOT header_file MATCHES "-fixit\\.h\$")
string(REGEX REPLACE "\\.h\$" "-fixit.h" header_fixit "${header_file}")
check_fixit(
"${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}/${header_fixit}"
"${CMAKE_CURRENT_LIST_DIR}/${CHECK_NAME}/${header_file}"
"${RunClangTidy_BINARY_DIR}/${CHECK_NAME}/${header_file}"
)
endif()
endforeach()
if(RunClangTidy_TEST_FAILED) if(RunClangTidy_TEST_FAILED)
string(REPLACE ";" " " command_formatted "${command}") string(REPLACE ";" " " command_formatted "${command}")