mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2025-12-31 19:00:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmGlobalVisualStudio8Generator: Fix the misaligned argument, stdPipesUTF8

Browse Source 
The call to AddCustomCommandToTarget for "Checking File Globs" had misaligned
arguments and previously passed `stdPipesUTF8` as `escapeOldStyle`.

For now, set `escapeOldStyle` as `true`. Also `stdPipesUTF8` is `true` here.
This commit is contained in:
NAKAMURA Takumi
2021-11-14 16:55:38 +09:00
committed by Brad King
parent e37511ae7e
commit 68b4e3b255
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Source/cmGlobalVisualStudio8Generator.cxx
View File

@@ -203,11 +203,17 @@ bool cmGlobalVisualStudio8Generator::AddCheckTarget()
std::vector<std::string> byproducts;
byproducts.push_back(cm->GetGlobVerifyStamp());
lg.AddCustomCommandToTarget(CMAKE_CHECK_BUILD_SYSTEM_TARGET, byproducts,
no_depends, verifyCommandLines,
cmCustomCommandType::PRE_BUILD,
"Checking File Globs", no_working_directory,
cmPolicies::NEW, stdPipesUTF8);
lg.AddCustomCommandToTarget(
CMAKE_CHECK_BUILD_SYSTEM_TARGET, byproducts, no_depends,
verifyCommandLines, cmCustomCommandType::PRE_BUILD,
"Checking File Globs", no_working_directory, cmPolicies::NEW,
/*escapeOldStyle=*/true,
/*uses_terminal=*/false,
/*depfile=*/"",
/*job_pool=*/"",
/*command_expand_lists=*/false,
/*objLibCommands=*/cmObjectLibraryCommands::Reject,
/*stdPipesUTF8=*/stdPipesUTF8);
// Ensure ZERO_CHECK always runs in Visual Studio using MSBuild,
// otherwise the prebuild command will not be run.