mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-04-30 11:10:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

cmGeneratedFileStream: Do not remove empty path

Browse Source 
If `Close()` is called when a file was never opened, we have no
temporary file path.  Do not try to remove it.  Some implementations of
`unlink()` crash on an empty path (though the documented behavior is to
fail with `ENOENT`).

Fixes: #23414
This commit is contained in:
Brad King
2022-04-29 11:52:45 -04:00
parent a8c8842101
commit 71ded12a75
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmGeneratedFileStream.cxx
+3 -1
View File
@@ -180,7 +180,9 @@ bool cmGeneratedFileStreamBase::Close()
// Else, the destination was not replaced. // Else, the destination was not replaced.
// //
// Always delete the temporary file. We never want it to stay around. // Always delete the temporary file. We never want it to stay around.
cmSystemTools::RemoveFile(this->TempName); if (!this->TempName.empty()) {
cmSystemTools::RemoveFile(this->TempName);
}
return replaced; return replaced;
} }