From 728f40d4bf6674f06d52aaddf0a95f61e9a39680 Mon Sep 17 00:00:00 2001 From: Dylan Snelgrove Date: Wed, 16 Oct 2024 23:46:16 +0000 Subject: [PATCH] libuv: win/spawn: allow exception through to OS Backport changes from libuv v2 commit `da343e6237` (win: allow fatal errors to trigger WER, 2023-01-17). Issue: #20115 --- Utilities/cmlibuv/src/win/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Utilities/cmlibuv/src/win/process.c b/Utilities/cmlibuv/src/win/process.c index 5cf9fb8066..ba43c04e0e 100644 --- a/Utilities/cmlibuv/src/win/process.c +++ b/Utilities/cmlibuv/src/win/process.c @@ -90,7 +90,6 @@ static void uv__init_global_job_handle(void) { info.BasicLimitInformation.LimitFlags = JOB_OBJECT_LIMIT_BREAKAWAY_OK | JOB_OBJECT_LIMIT_SILENT_BREAKAWAY_OK | - JOB_OBJECT_LIMIT_DIE_ON_UNHANDLED_EXCEPTION | JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE; uv_global_job_handle_ = CreateJobObjectW(&attr, NULL); @@ -1097,7 +1096,7 @@ int uv_spawn(uv_loop_t* loop, startup.hStdOutput = uv__stdio_handle(process->child_stdio_buffer, 1); startup.hStdError = uv__stdio_handle(process->child_stdio_buffer, 2); - process_flags = CREATE_UNICODE_ENVIRONMENT; + process_flags = CREATE_UNICODE_ENVIRONMENT | CREATE_DEFAULT_ERROR_MODE; if ((options->flags & UV_PROCESS_WINDOWS_HIDE_CONSOLE) || (options->flags & UV_PROCESS_WINDOWS_HIDE)) {