From 742c70a5da6d28639b8904b4ae27081b91925c14 Mon Sep 17 00:00:00 2001 From: Brad King Date: Thu, 13 Nov 2025 08:23:56 -0500 Subject: [PATCH] autogen: Remove unnecessary nullptr check In commit b1b3602cda (FASTBuild: remove non-existent autogen byproducts, 2025-11-10) we added an unnecessary nullptr check on a pointer we know to be non-nullptr. Since then, `clang-analyzer` takes that check as a hint that the pointer might be nullptr, and has reported missing nullptr checks elsewhere. --- Source/cmQtAutoGenInitializer.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/cmQtAutoGenInitializer.cxx b/Source/cmQtAutoGenInitializer.cxx index f169687a9b..3955237f6a 100644 --- a/Source/cmQtAutoGenInitializer.cxx +++ b/Source/cmQtAutoGenInitializer.cxx @@ -1395,7 +1395,7 @@ bool cmQtAutoGenInitializer::InitAutogenTarget() if (this->Uic.Enabled) { for (auto const& file : this->Uic.UiHeaders) { this->AddGeneratedSource(file.first, this->Uic); - if (this->GlobalGen && !GlobalGen->IsFastbuild()) { + if (!this->GlobalGen->IsFastbuild()) { autogenByproducts.push_back(file.second); } }