mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-20 05:30:19 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmGlobalVisualStudioGenerator: remove redundant variables

Browse Source
This commit is contained in:
Leonid Pospelov
2019-04-24 17:18:11 +03:00
parent 615fb2633c
commit 75643755a1
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
Source/cmGlobalVisualStudioGenerator.cxx
View File

@@ -203,9 +203,7 @@ void cmGlobalVisualStudioGenerator::AddExtraIDETargets()
// Now make all targets depend on the ALL_BUILD target
for (cmLocalGenerator const* i : gen) {
std::vector<cmGeneratorTarget*> const& targets =
i->GetGeneratorTargets();
for (cmGeneratorTarget* tgt : targets) {
for (cmGeneratorTarget* tgt : i->GetGeneratorTargets()) {
if (tgt->GetType() == cmStateEnums::GLOBAL_TARGET ||
tgt->IsImported()) {
continue;
@@ -392,11 +390,8 @@ bool cmGlobalVisualStudioGenerator::ComputeTargetDepends()
return false;
}
for (auto const& it : this->ProjectMap) {
std::vector<cmLocalGenerator*> const& gen = it.second;
for (const cmLocalGenerator* i : gen) {
std::vector<cmGeneratorTarget*> const& targets =
i->GetGeneratorTargets();
for (cmGeneratorTarget* ti : targets) {
for (const cmLocalGenerator* i : it.second) {
for (cmGeneratorTarget* ti : i->GetGeneratorTargets()) {
this->ComputeVSTargetDepends(ti);
}
}
@@ -448,8 +443,7 @@ void cmGlobalVisualStudioGenerator::ComputeVSTargetDepends(
std::set<cmGeneratorTarget const*> linkDepends;
if (target->GetType() != cmStateEnums::STATIC_LIBRARY) {
for (cmTargetDepend const& di : depends) {
cmTargetDepend dep = di;
if (dep.IsLink()) {
if (di.IsLink()) {
this->FollowLinkDepends(di, linkDepends);
}
}
@@ -458,8 +452,7 @@ void cmGlobalVisualStudioGenerator::ComputeVSTargetDepends(
// Collect explicit util dependencies (add_dependencies).
std::set<cmGeneratorTarget const*> utilDepends;
for (cmTargetDepend const& di : depends) {
cmTargetDepend dep = di;
if (dep.IsUtil()) {
if (di.IsUtil()) {
this->FollowLinkDepends(di, utilDepends);
}
}