mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-11 00:11:07 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmGeneratedFileStreamBase: Optimize string construction in Close

Browse Source 
Use cmStrCat to concatenate two parts of a file name.

This also avoids a bugprone-exception-escape diagnostic from
clang-tidy-8 on macOS.
This commit is contained in:
Brad King
2019-09-09 13:50:12 -04:00
parent 922482dd3a
commit 7c5ec91301
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Source/cmGeneratedFileStream.cxx
View File

@@ -4,6 +4,7 @@
#include <stdio.h>
#include "cmStringAlgorithms.h"
#include "cmSystemTools.h"
#if !defined(CMAKE_BOOTSTRAP)
@@ -149,7 +150,7 @@ bool cmGeneratedFileStreamBase::Close()
// The destination is to be replaced. Rename the temporary to the
// destination atomically.
if (this->Compress) {
std::string gzname = this->TempName + ".temp.gz";
std::string gzname = cmStrCat(this->TempName, ".temp.gz");
if (this->CompressFile(this->TempName, gzname)) {
this->RenameFile(gzname, resname);
}