mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-02 03:39:43 -06:00
Code Issues Packages Projects Releases Wiki Activity

CPackIFW: Fix cppcheck warnings

Browse Source 
The cppcheck warnings about uninitialised variables are likely harmless,
since they are initialised in ParseResource() anyway. Fix the warnings
anyway to reduce linting noise. The warning about a single argument
non-explicit constructor is worth fixing in general.
This commit is contained in:
Craig Scott
2021-02-14 15:24:25 +11:00
parent f388ce5321
commit 7ed7db88a4
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Source/CPack/IFW/cmCPackIFWInstaller.cxx
View File

@@ -275,9 +275,8 @@ void cmCPackIFWInstaller::ConfigureFromOptions()
class cmCPackIFWResourcesParser : public cmXMLParser
{
public:
cmCPackIFWResourcesParser(cmCPackIFWInstaller* i)
explicit cmCPackIFWResourcesParser(cmCPackIFWInstaller* i)
: installer(i)
, file(false)
{
this->path = i->Directory + "/resources";
}
@@ -296,7 +295,9 @@ public:
}
cmCPackIFWInstaller* installer;
bool file, hasFiles, hasErrors;
bool file = false;
bool hasFiles = false;
bool hasErrors = false;
std::string path, basePath;
protected: