mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-04-29 02:19:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

CUDA/Clang: Fail early when mixing clang++ with cl on Windows

Browse Source 
In commit 88c740462c (CUDA/Clang: Add support for MSVC ABI on Windows
using GNU-like frontend, 2024-01-17) we updated the message for the
existing check to mention CUDA, but neglected to update the check
itself.

Issue: #25648
This commit is contained in:
Brad King
2024-01-31 14:08:32 -05:00
parent 16b1f0c3e9
commit 899c8d7b21
1 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Modules/Platform/Windows-Clang.cmake
+8 -13
View File
@@ -167,37 +167,32 @@ macro(__enable_llvm_rc_preprocessing clang_option_prefix extra_pp_flags)
endif() endif()
endmacro() endmacro()
macro(__verify_same_language_values variable) function(__verify_same_language_values variable langs)
foreach(lang "C" "CXX" "HIP") foreach(lang IN LISTS langs)
if(DEFINED CMAKE_${lang}_${variable}) list(APPEND __LANGUAGE_VALUES_${variable} ${CMAKE_${lang}_${variable}})
list(APPEND __LANGUAGE_VALUES_${variable} "${CMAKE_${lang}_${variable}}")
endif()
endforeach() endforeach()
list(REMOVE_DUPLICATES __LANGUAGE_VALUES_${variable}) list(REMOVE_DUPLICATES __LANGUAGE_VALUES_${variable})
list(LENGTH __LANGUAGE_VALUES_${variable} __NUM_VALUES) list(LENGTH __LANGUAGE_VALUES_${variable} __NUM_VALUES)
if(__NUM_VALUES GREATER 1) if(__NUM_VALUES GREATER 1)
message(FATAL_ERROR ${ARGN}) message(FATAL_ERROR ${ARGN})
endif() endif()
unset(__NUM_VALUES) endfunction()
unset(__LANGUAGE_VALUES_${variable})
endmacro()
if("x${CMAKE_C_SIMULATE_ID}" STREQUAL "xMSVC" if("x${CMAKE_C_SIMULATE_ID}" STREQUAL "xMSVC"
OR "x${CMAKE_CXX_SIMULATE_ID}" STREQUAL "xMSVC" OR "x${CMAKE_CXX_SIMULATE_ID}" STREQUAL "xMSVC"
OR "x${CMAKE_CUDA_SIMULATE_ID}" STREQUAL "xMSVC" OR "x${CMAKE_CUDA_SIMULATE_ID}" STREQUAL "xMSVC"
OR "x${CMAKE_HIP_SIMULATE_ID}" STREQUAL "xMSVC") OR "x${CMAKE_HIP_SIMULATE_ID}" STREQUAL "xMSVC")
__verify_same_language_values(COMPILER_ID __verify_same_language_values(COMPILER_ID "C;CXX;HIP"
"The current configuration mixes Clang and MSVC or " "The current configuration mixes Clang and MSVC or "
"some other CL compatible compiler tool. This is not supported. " "some other CL compatible compiler tool. This is not supported. "
"Use either Clang or MSVC as the compiler for all of C, C++, CUDA and/or HIP.") "Use either Clang or MSVC as the compiler for all of C, C++, and/or HIP.")
__verify_same_language_values(COMPILER_FRONTEND_VARIANT __verify_same_language_values(COMPILER_FRONTEND_VARIANT "C;CXX;CUDA;HIP"
"The current configuration uses the Clang compiler " "The current configuration uses the Clang compiler "
"tool with mixed frontend variants, both the GNU and in MSVC CL " "tool with mixed frontend variants, both the GNU and in MSVC CL "
"like variants. This is not supported. Use either clang/clang++ " "like variants. This is not supported. Use either clang/clang++ "
"or clang-cl as all C, C++, CUDA and/or HIP compilers.") "or clang-cl as all C, C++, CUDA, and/or HIP compilers.")
if(NOT CMAKE_RC_COMPILER_INIT) if(NOT CMAKE_RC_COMPILER_INIT)
# Check if rc is already in the path # Check if rc is already in the path