From 6fd6bfab6f1e49833995375fd3f5a259e7fdf565 Mon Sep 17 00:00:00 2001 From: Eduard Voronkin Date: Tue, 14 Oct 2025 12:25:46 -0700 Subject: [PATCH] FASTBuild: fix globbing for large projects FASTBuild will replace `%1%` with all the glob matches, which might exceed command line limit on Windows. Moreover, we don't need to pass all the matches to the VerifyGlobs.cmake script. Fixes: #27305 --- Source/cmGlobalFastbuildGenerator.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/cmGlobalFastbuildGenerator.cxx b/Source/cmGlobalFastbuildGenerator.cxx index b652d598ad..19b5c8d809 100644 --- a/Source/cmGlobalFastbuildGenerator.cxx +++ b/Source/cmGlobalFastbuildGenerator.cxx @@ -1543,8 +1543,8 @@ void cmGlobalFastbuildGenerator::AddGlobCheckExec() FastbuildExecNode globCheck; globCheck.Name = FASTBUILD_GLOB_CHECK_TARGET; globCheck.ExecExecutable = cmSystemTools::GetCMakeCommand(); - globCheck.ExecArguments = "-P " FASTBUILD_1_INPUT_PLACEHOLDER; - globCheck.ExecInput = { this->ConvertToFastbuildPath(globScript) }; + globCheck.ExecArguments = + cmStrCat("-P ", this->ConvertToFastbuildPath(globScript)); globCheck.ExecAlways = false; globCheck.ExecUseStdOutAsOutput = false; auto const cache = this->GetCMakeInstance()->GetGlobCacheEntries();