mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-02-17 12:40:40 -06:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: Replace a "magic" number w/ a named constant

Browse Source
This commit is contained in:
Alex Turbov
2019-07-06 02:53:32 +03:00
committed by Brad King
parent 638383c38f
commit 90f91e4d21
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Source/cmProjectCommand.cxx
View File

@@ -220,13 +220,14 @@ bool cmProjectCommand::InitialPass(std::vector<std::string> const& args,
return true; return true;
} }
constexpr std::size_t MAX_VERSION_COMPONENTS = 4u;
std::string vs; std::string vs;
char vb[4][64]; char vb[MAX_VERSION_COMPONENTS][64];
unsigned int v[4] = { 0, 0, 0, 0 }; unsigned int v[MAX_VERSION_COMPONENTS] = { 0, 0, 0, 0 };
int vc = int vc =
sscanf(version.c_str(), "%u.%u.%u.%u", &v[0], &v[1], &v[2], &v[3]); sscanf(version.c_str(), "%u.%u.%u.%u", &v[0], &v[1], &v[2], &v[3]);
for (int i = 0; i < 4; ++i) { for (auto i = 0u; i < MAX_VERSION_COMPONENTS; ++i) {
if (i < vc) { if (int(i) < vc) {
sprintf(vb[i], "%u", v[i]); sprintf(vb[i], "%u", v[i]);
vs += &"."[size_t(i == 0)]; vs += &"."[size_t(i == 0)];
vs += vb[i]; vs += vb[i];