diff --git a/Source/cmDebuggerAdapter.cxx b/Source/cmDebuggerAdapter.cxx index 7dc6e7f0f8..832897622f 100644 --- a/Source/cmDebuggerAdapter.cxx +++ b/Source/cmDebuggerAdapter.cxx @@ -164,8 +164,7 @@ cmDebuggerAdapter::cmDebuggerAdapter( }); // https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Threads - Session->registerHandler([this](dap::ThreadsRequest const& req) { - (void)req; + Session->registerHandler([this](dap::ThreadsRequest /*unused*/) { std::unique_lock lock(Mutex); dap::ThreadsResponse response; @@ -196,7 +195,7 @@ cmDebuggerAdapter::cmDebuggerAdapter( }); // https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Scopes - Session->registerHandler([this](dap::ScopesRequest const& request) + Session->registerHandler([this](dap::ScopesRequest request) -> dap::ResponseOrError { std::unique_lock lock(Mutex); return DefaultThread->GetScopesResponse(request.frameId, @@ -210,8 +209,7 @@ cmDebuggerAdapter::cmDebuggerAdapter( }); // https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Pause - Session->registerHandler([this](dap::PauseRequest const& req) { - (void)req; + Session->registerHandler([this](dap::PauseRequest /*unused*/) { PauseRequest.store(true); return dap::PauseResponse(); }); @@ -286,8 +284,7 @@ cmDebuggerAdapter::cmDebuggerAdapter( // The ConfigurationDone request is made by the client once all configuration // requests have been made. // https://microsoft.github.io/debug-adapter-protocol/specification#Requests_ConfigurationDone - Session->registerHandler([this](dap::ConfigurationDoneRequest const& req) { - (void)req; + Session->registerHandler([this](dap::ConfigurationDoneRequest /*unused*/) { ConfigurationDoneEvent->Fire(); return dap::ConfigurationDoneResponse(); }); diff --git a/Source/cmDebuggerExceptionManager.cxx b/Source/cmDebuggerExceptionManager.cxx index a2744e1feb..22a577a6f9 100644 --- a/Source/cmDebuggerExceptionManager.cxx +++ b/Source/cmDebuggerExceptionManager.cxx @@ -25,8 +25,7 @@ cmDebuggerExceptionManager::cmDebuggerExceptionManager( }); // https://microsoft.github.io/debug-adapter-protocol/specification#Requests_ExceptionInfo - DapSession->registerHandler([&](dap::ExceptionInfoRequest const& request) { - (void)request; + DapSession->registerHandler([&](dap::ExceptionInfoRequest /*unused*/) { return HandleExceptionInfoRequest(); }); diff --git a/Tests/CMakeLib/testDebuggerAdapter.cxx b/Tests/CMakeLib/testDebuggerAdapter.cxx index c5ad8b3828..cc7c71ab83 100644 --- a/Tests/CMakeLib/testDebuggerAdapter.cxx +++ b/Tests/CMakeLib/testDebuggerAdapter.cxx @@ -83,16 +83,13 @@ bool runTest(std::function onThreadExitedEvent) auto connection = std::make_shared(); std::unique_ptr client = dap::Session::create(); - client->registerHandler([&](dap::InitializedEvent const& e) { - (void)e; + client->registerHandler([&](dap::InitializedEvent /*unused*/) { initializedEventReceivedPromise.set_value(true); }); - client->registerHandler([&](dap::ExitedEvent const& e) { - (void)e; + client->registerHandler([&](dap::ExitedEvent /*unused*/) { exitedEventReceivedPromise.set_value(true); }); - client->registerHandler([&](dap::TerminatedEvent const& e) { - (void)e; + client->registerHandler([&](dap::TerminatedEvent const& /*unused*/) { terminatedEventReceivedPromise.set_value(true); }); client->registerHandler([&](dap::ThreadEvent const& e) { diff --git a/Tests/CMakeLib/testDebuggerAdapterPipe.cxx b/Tests/CMakeLib/testDebuggerAdapterPipe.cxx index 15dc32b477..d7c41341da 100644 --- a/Tests/CMakeLib/testDebuggerAdapterPipe.cxx +++ b/Tests/CMakeLib/testDebuggerAdapterPipe.cxx @@ -76,16 +76,13 @@ bool testProtocolWithPipes() #endif std::unique_ptr client = dap::Session::create(); - client->registerHandler([&](dap::InitializedEvent const& e) { - (void)e; + client->registerHandler([&](dap::InitializedEvent /*unused*/) { initializedEventReceivedPromise.set_value(true); }); - client->registerHandler([&](dap::ExitedEvent const& e) { - (void)e; + client->registerHandler([&](dap::ExitedEvent /*unused*/) { exitedEventReceivedPromise.set_value(true); }); - client->registerHandler([&](dap::TerminatedEvent const& e) { - (void)e; + client->registerHandler([&](dap::TerminatedEvent const& /*unused*/) { terminatedEventReceivedPromise.set_value(true); }); client->registerHandler([&](dap::ThreadEvent const& e) {