cmMakefile: Simplify programmer error to an assert

This commit is contained in:
Stephen Kelly
2016-10-07 20:13:37 +02:00
parent 4079ba20d9
commit a1cfc4fe3d

View File

@@ -1832,14 +1832,9 @@ cmTarget* cmMakefile::AddLibrary(const std::string& lname,
const std::vector<std::string>& srcs,
bool excludeFromAll)
{
// wrong type ? default to STATIC
if ((type != cmState::STATIC_LIBRARY) && (type != cmState::SHARED_LIBRARY) &&
(type != cmState::MODULE_LIBRARY) && (type != cmState::OBJECT_LIBRARY) &&
(type != cmState::INTERFACE_LIBRARY)) {
this->IssueMessage(cmake::INTERNAL_ERROR,
"cmMakefile::AddLibrary given invalid target type.");
type = cmState::STATIC_LIBRARY;
}
assert(type == cmState::STATIC_LIBRARY || type == cmState::SHARED_LIBRARY ||
type == cmState::MODULE_LIBRARY || type == cmState::OBJECT_LIBRARY ||
type == cmState::INTERFACE_LIBRARY);
cmTarget* target = this->AddNewTarget(type, lname);
// Clear its dependencies. Otherwise, dependencies might persist