mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-02-21 14:40:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Windows: Tolerate GetShortPathNameW failure

Browse Source 
This function is used by NMake Makefile generator, but when shortening path
fails, it previously returned an empty string.  `ERROR_ACCESS_DENIED` is
returned for paths within `C:\Program Files\WindowsApps`, which is
a special folder with limited access rights.  It looks like this is
[by design](https://superuser.com/a/1730061/213587).

Fixes: #24853
This commit is contained in:
Oldřich Jedlička
2023-04-26 09:26:43 +02:00
committed by Brad King
parent 827d5b75d4
commit a368a59467
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Source/cmOutputConverter.cxx
View File

@@ -175,7 +175,12 @@ std::string cmOutputConverter::ConvertToOutputForExisting(
}
std::string tmp{};
cmSystemTools::GetShortPath(remote, tmp);
cmsys::Status status = cmSystemTools::GetShortPath(remote, tmp);
if (!status) {
// Fallback for cases when Windows refuses to resolve the short path,
// like for C:\Program Files\WindowsApps\...
tmp = remote;
}
shortPathCache[remote] = tmp;
return tmp;
}();