mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-11 16:32:14 -06:00
Code Issues Packages Projects Releases Wiki Activity

target_link_libraries: Allow linking to UNKNOWN IMPORTED GLOBAL libs

Browse Source 
This combination was accidentally rejected.  Allow it and add a test.

Fixes: #17245
This commit is contained in:
Brad King
2017-08-31 13:04:34 -04:00
parent 4f96641ba2
commit a47a853376
3 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Source/cmTargetLinkLibrariesCommand.cxx
View File

@@ -366,6 +366,7 @@ bool cmTargetLinkLibrariesCommand::HandleLibrary(const std::string& lib,
if (tgt && (tgt->GetType() != cmStateEnums::STATIC_LIBRARY) &&
(tgt->GetType() != cmStateEnums::SHARED_LIBRARY) &&
(tgt->GetType() != cmStateEnums::UNKNOWN_LIBRARY) &&
(tgt->GetType() != cmStateEnums::INTERFACE_LIBRARY) &&
!tgt->IsExecutableWithExports()) {
std::ostringstream e;

1
Tests/RunCMake/target_link_libraries/RunCMakeTest.cmake
View File

@@ -10,3 +10,4 @@ run_cmake(SubDirTarget)
run_cmake(SharedDepNotTarget)
run_cmake(StaticPrivateDepNotExported)
run_cmake(StaticPrivateDepNotTarget)
run_cmake(UNKNOWN-IMPORTED-GLOBAL)

4
Tests/RunCMake/target_link_libraries/UNKNOWN-IMPORTED-GLOBAL.cmake Normal file
View File

@@ -0,0 +1,4 @@
enable_language(C)
add_library(UnknownImportedGlobal UNKNOWN IMPORTED GLOBAL)
add_library(mylib empty.c)
target_link_libraries(mylib UnknownImportedGlobal)