mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-08 23:00:07 -06:00
Code Issues Packages Projects Releases Wiki Activity

TryRun: do not call strcpy()

Browse Source
This commit is contained in:
Rolf Eike Beer
2017-10-08 18:15:31 +02:00
parent 4e96dc02c3
commit a483b7eac2
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Source/cmTryRunCommand.cxx
View File

@@ -4,7 +4,6 @@
#include "cmsys/FStream.hxx"
#include <stdio.h>
#include <string.h>
#include "cmMakefile.h"
#include "cmState.h"
@@ -191,13 +190,15 @@ void cmTryRunCommand::RunExecutable(const std::string& runArgs,
finalCommand.c_str(), out, out, &retVal, nullptr,
cmSystemTools::OUTPUT_NONE, timeout);
// set the run var
char retChar[1000];
char retChar[16];
const char* retStr;
if (worked) {
sprintf(retChar, "%i", retVal);
retStr = retChar;
} else {
strcpy(retChar, "FAILED_TO_RUN");
retStr = "FAILED_TO_RUN";
}
this->Makefile->AddCacheDefinition(this->RunResultVariable, retChar,
this->Makefile->AddCacheDefinition(this->RunResultVariable, retStr,
"Result of TRY_RUN",
cmStateEnums::INTERNAL);
}