mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-04-24 15:18:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

GenEx: Revert "Limit TARGET_PROPERTY transitive closure optimization"

Browse Source 
Revert commit 4a11772618 (GenEx: Limit TARGET_PROPERTY transitive
closure optimization to subgraphs, 2024-05-31, v3.31.0-rc1~114^2).
The change caused substantial performance regressions in some
existing use cases.  Revert it pending further investigation.

Issue: #25728
Fixes: #26457
This commit is contained in:
Brad King
2025-01-09 11:54:50 -05:00
parent 41abd532b6
commit a6b84a438f
7 changed files with 9 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmGeneratorExpressionNode.cxx
+2 -3
View File
@@ -2983,9 +2983,8 @@ static const struct TargetPropertyNode : public cmGeneratorExpressionNode
if (isInterfaceProperty) {
return cmGeneratorExpression::StripEmptyListElements(
target->EvaluateInterfaceProperty(
propertyName, context, dagCheckerParent, usage,
cmGeneratorTarget::TransitiveClosure::Subgraph));
target->EvaluateInterfaceProperty(propertyName, context,
dagCheckerParent, usage));
}
cmGeneratorExpressionDAGChecker dagChecker(