mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-04-21 13:48:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

cmTarget: use static string views for per-config properties

Browse Source
This commit is contained in:
Ben Boeckel
2023-01-29 23:25:20 -05:00
parent 47315d817c
commit a7c29f3ebd
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/cmTarget.cxx
+5 -6
View File
@@ -4,7 +4,6 @@
#include <algorithm> #include <algorithm>
#include <cassert> #include <cassert>
#include <cstring>
#include <initializer_list> #include <initializer_list>
#include <iterator> #include <iterator>
#include <map> #include <map>
@@ -724,10 +723,10 @@ cmTarget::cmTarget(std::string const& name, cmStateEnums::TargetType type,
this->GetType() != cmStateEnums::GLOBAL_TARGET) { this->GetType() != cmStateEnums::GLOBAL_TARGET) {
static const auto configProps = { static const auto configProps = {
/* clang-format needs this comment to break after the opening brace */ /* clang-format needs this comment to break after the opening brace */
"ARCHIVE_OUTPUT_DIRECTORY_", "LIBRARY_OUTPUT_DIRECTORY_", "ARCHIVE_OUTPUT_DIRECTORY_"_s, "LIBRARY_OUTPUT_DIRECTORY_"_s,
"RUNTIME_OUTPUT_DIRECTORY_", "PDB_OUTPUT_DIRECTORY_", "RUNTIME_OUTPUT_DIRECTORY_"_s, "PDB_OUTPUT_DIRECTORY_"_s,
"COMPILE_PDB_OUTPUT_DIRECTORY_", "MAP_IMPORTED_CONFIG_", "COMPILE_PDB_OUTPUT_DIRECTORY_"_s, "MAP_IMPORTED_CONFIG_"_s,
"INTERPROCEDURAL_OPTIMIZATION_" "INTERPROCEDURAL_OPTIMIZATION_"_s
}; };
// Collect the set of configuration types. // Collect the set of configuration types.
std::vector<std::string> configNames = std::vector<std::string> configNames =
@@ -738,7 +737,7 @@ cmTarget::cmTarget(std::string const& name, cmStateEnums::TargetType type,
// Interface libraries have no output locations, so honor only // Interface libraries have no output locations, so honor only
// the configuration map. // the configuration map.
if (this->impl->TargetType == cmStateEnums::INTERFACE_LIBRARY && if (this->impl->TargetType == cmStateEnums::INTERFACE_LIBRARY &&
strcmp(prop, "MAP_IMPORTED_CONFIG_") != 0) { prop != "MAP_IMPORTED_CONFIG_") {
continue; continue;
} }
std::string property = cmStrCat(prop, configUpper); std::string property = cmStrCat(prop, configUpper);