mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-25 07:58:59 -06:00
Code Issues Packages Projects Releases Wiki Activity

ast-grep: simplify cmStrCat calls with one-char strings

Browse Source
This commit is contained in:
Ben Boeckel
2025-10-27 16:17:25 -04:00
parent 514cbbc76e
commit aa477d8768
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Source/cmFastbuildNormalTargetGenerator.cxx
View File

@@ -185,7 +185,7 @@ void cmFastbuildNormalTargetGenerator::GetLinkerExecutableAndArgs(
if (iter != compilers.end()) {
LogMessage("Linker launcher: " + iter->first);
outLinkerExecutable = iter->second.Executable;
outLinkerArgs = cmStrCat(iter->second.Args, " ", command);
outLinkerArgs = cmStrCat(iter->second.Args, ' ', command);
} else {
SplitLinkerFromArgs(command, outLinkerExecutable, outLinkerArgs);
}
@@ -359,7 +359,7 @@ void cmFastbuildNormalTargetGenerator::ApplyLinkRuleLauncher(
this->GetGeneratorTarget(), "RULE_LAUNCH_LINK", Config);
if (cmNonempty(val)) {
LogMessage("RULE_LAUNCH_LINK: " + val);
command = cmStrCat(val, " ", command);
command = cmStrCat(val, ' ', command);
}
}
@@ -550,7 +550,7 @@ void cmFastbuildNormalTargetGenerator::GenerateModuleDefinitionInfo(
execNode.Name = target.Name + "-def-files";
execNode.ExecExecutable = cmSystemTools::GetCMakeCommand();
execNode.ExecArguments =
cmStrCat("-E __create_def ", FASTBUILD_2_INPUT_PLACEHOLDER, " ",
cmStrCat("-E __create_def ", FASTBUILD_2_INPUT_PLACEHOLDER, ' ',
FASTBUILD_1_INPUT_PLACEHOLDER);
std::string const obj_list_file = mdi->DefFile + ".objs";
@@ -1492,7 +1492,7 @@ void cmFastbuildNormalTargetGenerator::GenerateObjects(FastbuildTarget& target)
for (auto& val : nodesPermutations) {
auto& objectListNode = val.second;
objectListNode.Name = cmStrCat(objectListNode.Name, "_", ++groupNameCount);
objectListNode.Name = cmStrCat(objectListNode.Name, '_', ++groupNameCount);
LogMessage(cmStrCat("ObjectList name: ", objectListNode.Name));
}
std::vector<FastbuildObjectListNode>& objects = target.ObjectListNodes;

2
Source/cmGlobalFastbuildGenerator.cxx
View File

@@ -1631,7 +1631,7 @@ void cmGlobalFastbuildGenerator::WriteSolution()
folderName,
{ { "Path", Quote(pathToFolder) },
{ "Projects",
cmStrCat("{", cmJoin(Wrap(projectsInFolder), ","), "}") } },
cmStrCat('{', cmJoin(Wrap(projectsInFolder), ","), '}') } },
1);
folders.emplace_back(std::move(folderName));
}

2
Source/cmProjectCommand.cxx
View File

@@ -273,7 +273,7 @@ bool cmProjectCommand(std::vector<std::string> const& args,
// Note, this intentionally doesn't touch cache variables as the legacy
// behavior did not modify cache
auto checkAndClearVariables = [&](cm::string_view var) {
std::vector<std::string> vv = { "PROJECT_", cmStrCat(projectName, "_") };
std::vector<std::string> vv = { "PROJECT_", cmStrCat(projectName, '_') };
if (mf.IsRootMakefile()) {
vv.push_back("CMAKE_PROJECT_");
}