mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-05-25 01:28:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

cmCTestMultiProcessHandler: Clarify role of StartTestProcess

Browse Source 
Focus its role on actually running the test process.
Move administrative tasks to the call site.
This commit is contained in:
Brad King
2023-11-02 15:04:49 -04:00
parent 0950acb337
commit b17c732e88
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/CTest/cmCTestMultiProcessHandler.cxx
+4 -4
View File
@@ -164,12 +164,8 @@ void cmCTestMultiProcessHandler::RunTests()
void cmCTestMultiProcessHandler::StartTestProcess(int test) void cmCTestMultiProcessHandler::StartTestProcess(int test)
{ {
this->LockResources(test);
cmCTestOptionalLog(this->CTest, HANDLER_VERBOSE_OUTPUT, cmCTestOptionalLog(this->CTest, HANDLER_VERBOSE_OUTPUT,
"test " << test << "\n", this->Quiet); "test " << test << "\n", this->Quiet);
// now remove the test itself
this->ErasePendingTest(test);
auto testRun = cm::make_unique<cmCTestRunTest>(*this, test); auto testRun = cm::make_unique<cmCTestRunTest>(*this, test);
@@ -591,8 +587,12 @@ void cmCTestMultiProcessHandler::StartNextTests()
continue; continue;
} }
// Lock resources needed by this test.
this->LockResources(test);
// The test is ready to run. // The test is ready to run.
numToStart -= processors; numToStart -= processors;
this->ErasePendingTest(test);
this->StartTest(test); this->StartTest(test);
} }