mirror of
https://github.com/Kitware/CMake.git
synced 2026-05-04 05:10:10 -05:00
source: Pass small and trivially copyable types by value
This commit is contained in:
committed by
Brad King
parent
7829ea76ad
commit
b1fdab3cc1
@@ -3848,7 +3848,7 @@ bool ValidateAndConvertPermissions(
|
||||
return true;
|
||||
}
|
||||
|
||||
bool SetPermissions(std::string const& filename, mode_t const& perms,
|
||||
bool SetPermissions(std::string const& filename, mode_t perms,
|
||||
cmExecutionStatus& status)
|
||||
{
|
||||
if (!cmSystemTools::SetPermissions(filename, perms)) {
|
||||
@@ -3953,8 +3953,7 @@ bool HandleChmodCommandImpl(std::vector<std::string> const& args, bool recurse,
|
||||
|
||||
if (cmSystemTools::FileExists(i, true)) {
|
||||
bool success = true;
|
||||
mode_t const& filePermissions =
|
||||
parsedArgs.FilePermissions ? fperms : perms;
|
||||
mode_t filePermissions = parsedArgs.FilePermissions ? fperms : perms;
|
||||
if (filePermissions) {
|
||||
success = SetPermissions(i, filePermissions, status);
|
||||
}
|
||||
@@ -3965,7 +3964,7 @@ bool HandleChmodCommandImpl(std::vector<std::string> const& args, bool recurse,
|
||||
|
||||
else if (cmSystemTools::FileIsDirectory(i)) {
|
||||
bool success = true;
|
||||
mode_t const& directoryPermissions =
|
||||
mode_t directoryPermissions =
|
||||
parsedArgs.DirectoryPermissions ? dperms : perms;
|
||||
if (directoryPermissions) {
|
||||
success = SetPermissions(i, directoryPermissions, status);
|
||||
|
||||
Reference in New Issue
Block a user