mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-03-03 05:08:47 -06:00
Code Issues Packages Projects Releases Wiki Activity

target_sources(): Enforce stricter requirements for FILE_SET name

Browse Source 
Fixes: #23286
This commit is contained in:
Kyle Edwards
2022-03-03 10:15:08 -05:00
parent 04a7200c75
commit b357d334fc
8 changed files with 30 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Source/cmTargetSourcesCommand.cxx
View File

@@ -215,9 +215,10 @@ bool TargetSourcesImpl::HandleFileSetMode(
auto fileSet = this->Target->GetOrCreateFileSet(args.FileSet, type);
if (fileSet.second) {
if (!isDefault) {
if (args.FileSet[0] >= 'A' && args.FileSet[0] <= 'Z') {
this->SetError(
"Non-default file set name must not start with a capital letter");
if (!cmFileSet::IsValidName(args.FileSet)) {
this->SetError("Non-default file set name must contain only letters, "
"numbers, and underscores, and must not start with a "
"capital letter or underscore");
return false;
}
}