ExternalProject: Add policy CMP0114 to refine step target dependencies

`ExternalProject_Add_StepTargets` and `INDEPENDENT_STEP_TARGETS` have
some limitations and lack some sanity checks.  They can cause confusing
build systems to be generated.  The basic problems are:

* The notion of step independence is attached to the step target
  rather than the step itself.

* The custom commands implementing the steps are duplicated in the
  step targets and the primary targets.  This can cause races.
  It is also incompatible with the Xcode "new build system".

Fix this by introducing policy CMP0114 to change the way step target
dependencies are handled.  Define independence from external
dependencies as a property of each individual step regardless of whether
there is a target for it.  Add dependencies among the primary target and
the step targets such that each custom command only appears in one
target.  When some steps are disconnected from the primary target, add
step targets for the steps commonly depended upon so that there is a
place to hold their custom commands uniquely.

Fixes: #18663
This commit is contained in:
Brad King
2020-09-10 10:56:32 -04:00
parent f5791e24c6
commit b4fc4da903
36 changed files with 654 additions and 49 deletions
@@ -0,0 +1,5 @@
ExternalProject-steps-refinement
--------------------------------
* The :module:`ExternalProject` module handling of step target dependencies
has been revised. See policy :policy:`CMP0114`.