mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-06 13:51:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix some occurrences using string by value rather than by const&

Browse Source 
Fix issues diagnosed by clang-tidy
 - performance-unnecessary-value-param
 - performance-unnecessary-copy-initialization

Signed-off-by: Matthias Maennich <matthias@maennich.net>
This commit is contained in:
Matthias Maennich
2017-09-19 15:54:08 +02:00
committed by Brad King
parent 8cc33aeaec
commit bb0ad1bea8
8 changed files with 20 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Source/cmGlobalXCodeGenerator.cxx
View File

@@ -573,7 +573,7 @@ void cmGlobalXCodeGenerator::ClearXCodeObjects()
void cmGlobalXCodeGenerator::addObject(cmXCodeObject* obj)
{
if (obj->GetType() == cmXCodeObject::OBJECT) {
std::string id = obj->GetId();
const std::string& id = obj->GetId();
// If this is a duplicate id, it's an error:
//
@@ -2748,7 +2748,7 @@ bool cmGlobalXCodeGenerator::CreateGroups(
}
cmXCodeObject* cmGlobalXCodeGenerator::CreatePBXGroup(cmXCodeObject* parent,
std::string name)
const std::string& name)
{
cmXCodeObject* parentChildren = nullptr;
if (parent)