From bbc98fb67a43b82861f52a7b0869f85d80d724d7 Mon Sep 17 00:00:00 2001 From: AZero13 Date: Mon, 26 May 2025 15:15:02 -0400 Subject: [PATCH] CPack/DragNDrop: Avoid crash when locale identifier creation fails If `CFLocaleCreateCanonicalLanguageIdentifierFromString` fails, stop gracefully. Otherwise we crash because `CFStringGetCString` cannot work with null `CFStrings`. --- Source/CPack/cmCPackDragNDropGenerator.cxx | 1 + 1 file changed, 1 insertion(+) diff --git a/Source/CPack/cmCPackDragNDropGenerator.cxx b/Source/CPack/cmCPackDragNDropGenerator.cxx index 1d55274b6c..328204aea5 100644 --- a/Source/CPack/cmCPackDragNDropGenerator.cxx +++ b/Source/CPack/cmCPackDragNDropGenerator.cxx @@ -601,6 +601,7 @@ int cmCPackDragNDropGenerator::CreateDMG(std::string const& src_dir, cmCPackLogger(cmCPackLog::LOG_ERROR, language << " is not a recognized language" << std::endl); + return 0; } char iso_language_cstr[65]; CFStringGetCString(iso_language, iso_language_cstr,