mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-11 16:32:14 -06:00
Code Issues Packages Projects Releases Wiki Activity

cmGlobalNinjaGenerator: remove unnecessary virtual method

Browse Source 
The implementation is the same and the called method used internally is
`virtual`, so just make the call non-virtual.
This commit is contained in:
Ben Boeckel
2023-10-19 22:06:23 -04:00
parent 1cfba13004
commit c2e949b700
2 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Source/cmGlobalNinjaGenerator.cxx
View File

@@ -3183,10 +3183,3 @@ std::string cmGlobalNinjaMultiGenerator::OrderDependsTargetForTarget(
return cmStrCat("cmake_object_order_depends_target_", target->GetName(), '_',
cmSystemTools::UpperCase(config));
}
std::string cmGlobalNinjaMultiGenerator::OrderDependsTargetForTargetPrivate(
cmGeneratorTarget const* target, const std::string& config) const
{
return cmStrCat(this->OrderDependsTargetForTarget(target, config),
"_private");
}

5
Source/cmGlobalNinjaGenerator.h
View File

@@ -349,7 +349,7 @@ public:
virtual std::string OrderDependsTargetForTarget(
cmGeneratorTarget const* target, const std::string& config) const;
virtual std::string OrderDependsTargetForTargetPrivate(
std::string OrderDependsTargetForTargetPrivate(
cmGeneratorTarget const* target, const std::string& config) const;
void AppendTargetOutputs(cmGeneratorTarget const* target,
@@ -741,9 +741,6 @@ public:
std::string OrderDependsTargetForTarget(
cmGeneratorTarget const* target, const std::string& config) const override;
std::string OrderDependsTargetForTargetPrivate(
cmGeneratorTarget const* target, const std::string& config) const override;
protected:
bool OpenBuildFileStreams() override;
void CloseBuildFileStreams() override;