mirror/CMake
1
0
Fork 0
mirror of https://github.com/Kitware/CMake.git synced 2026-01-02 11:49:55 -06:00
Code Issues Packages Projects Releases Wiki Activity

KWSys 2020-04-07 (caff9c3b)

Browse Source 
Code extracted from:

    https://gitlab.kitware.com/utils/kwsys.git

at commit caff9c3bf3c9a95f4ac7f700532633603352e506 (master).

Upstream Shortlog
-----------------

Vladimir Menshakov (1):
      66724af8 SystemTools: Teach FindProgram to find non-readable programs
This commit is contained in:
KWSys Upstream
2020-04-07 08:05:31 -04:00
committed by Brad King
parent fe6d7d6c42
commit c5635588ad
2 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
SystemTools.cxx
View File

@@ -2807,7 +2807,7 @@ std::string SystemTools::FindProgram(const std::string& name,
for (std::string const& ext : extensions) {
tryPath = name;
tryPath += ext;
if (SystemTools::FileExists(tryPath, true)) {
if (SystemTools::FileIsExecutable(tryPath)) {
return SystemTools::CollapseFullPath(tryPath);
}
}
@@ -2815,7 +2815,7 @@ std::string SystemTools::FindProgram(const std::string& name,
#endif
// now try just the name
if (SystemTools::FileExists(name, true)) {
if (SystemTools::FileIsExecutable(name)) {
return SystemTools::CollapseFullPath(name);
}
// now construct the path
@@ -2845,7 +2845,7 @@ std::string SystemTools::FindProgram(const std::string& name,
tryPath = p;
tryPath += name;
tryPath += ext;
if (SystemTools::FileExists(tryPath, true)) {
if (SystemTools::FileIsExecutable(tryPath)) {
return SystemTools::CollapseFullPath(tryPath);
}
}
@@ -2853,7 +2853,7 @@ std::string SystemTools::FindProgram(const std::string& name,
// now try it without them
tryPath = p;
tryPath += name;
if (SystemTools::FileExists(tryPath, true)) {
if (SystemTools::FileIsExecutable(tryPath)) {
return SystemTools::CollapseFullPath(tryPath);
}
}
@@ -3008,6 +3008,11 @@ bool SystemTools::FileIsDirectory(const std::string& inName)
}
}
bool SystemTools::FileIsExecutable(const std::string& name)
{
return !FileIsDirectory(name) && TestFileAccess(name, TEST_FILE_EXECUTE);
}
bool SystemTools::FileIsSymlink(const std::string& name)
{
#if defined(_WIN32)
@@ -3172,7 +3177,7 @@ bool SystemTools::FindProgramPath(const char* argv0, std::string& pathOut,
failures.push_back(self);
SystemTools::ConvertToUnixSlashes(self);
self = SystemTools::FindProgram(self);
if (!SystemTools::FileExists(self)) {
if (!SystemTools::FileIsExecutable(self)) {
if (buildDir) {
std::string intdir = ".";
#ifdef CMAKE_INTDIR
@@ -3187,14 +3192,14 @@ bool SystemTools::FindProgramPath(const char* argv0, std::string& pathOut,
}
}
if (installPrefix) {
if (!SystemTools::FileExists(self)) {
if (!SystemTools::FileIsExecutable(self)) {
failures.push_back(self);
self = installPrefix;
self += "/bin/";
self += exeName;
}
}
if (!SystemTools::FileExists(self)) {
if (!SystemTools::FileIsExecutable(self)) {
failures.push_back(self);
std::ostringstream msg;
msg << "Can not find the command line program ";

5
SystemTools.hxx.in
View File

@@ -676,6 +676,11 @@ public:
*/
static bool FileIsDirectory(const std::string& name);
/**
* Return true if the file is an executable
*/
static bool FileIsExecutable(const std::string& name);
/**
* Return true if the file is a symlink
*/